summaryrefslogtreecommitdiffstats
path: root/signal-composer-binding
diff options
context:
space:
mode:
authorRomain Forlot <romain.forlot@iot.bzh>2018-04-30 23:59:35 +0200
committerRomain Forlot <romain.forlot@iot.bzh>2018-07-05 16:22:47 +0200
commit772552a441dae3ef7e25c7144269385c9ca68a4e (patch)
tree13c6b9d691aa71695abcf146c03228c47a5a609b /signal-composer-binding
parent1ca194d352688224d26755a0edebbab6a1841ad9 (diff)
Change when to notify
The notify was in fact called 2 times. It is attended that a callback should "set" the signal value to record it. Setting the signal's value already call notify which an action should do at the end. Notifying has a meaning only if a signal value has been modified. Change-Id: I4a8128317a88bf7459b2c4aa0f575c4b2524e816 Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Diffstat (limited to 'signal-composer-binding')
-rw-r--r--signal-composer-binding/signal.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/signal-composer-binding/signal.cpp b/signal-composer-binding/signal.cpp
index 0b17091..3a448b1 100644
--- a/signal-composer-binding/signal.cpp
+++ b/signal-composer-binding/signal.cpp
@@ -353,7 +353,6 @@ void Signal::onReceivedCB(json_object *eventJ)
source.request = {nullptr, nullptr};
source.context = (void*)get_context();
onReceived_ ? ActionExecOne(&source, onReceived_, eventJ) : defaultReceivedCB(eventJ);
- notify();
}
/// @brief Make a Signal observer observes Signals observables