Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
It was noticed that vshl-capabilities was triggering the reference count
check in json-c and asserting:
../json-c-0.13.1/json_object.c:189: json_object_put: Assertion `jso->_ref_count > 0' failed.
Initially, this was only seen once during ad hoc testing, but
investigation into using the capabilities events started triggering it
reproducibly. The root cause seems to be the capabilities binding
reusing the json-c objects it receives from voiceagent events to send
out itself. That results in the objects getting json_object_put called
on them a second time by the app framework when they're resent. To fix
this, call json_object_put on the reused objects to keep their reference
count correct and avoid triggering the assert.
Bug-AGL: SPEC-3053
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I533bf492e740509cebd8d3487c9658e175fe73f9
(cherry picked from commit 6fc654713a65a0e72ee592fbd5e177702e33fbca)
|
|
Change set_destination/cancel_navigation to match the
setDestination/cancelNavigation that alexa-voiceagent-service seems
to have switched to at some point between 1.3 and 2.0. It does not
seem worthwhile trying to get Amazon to change on their side, and
additionally 2.1 changes the whole API so capabilities will need to
be reworked again anyway.
Bug-AGL: SPEC-3083
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I52c0eb78c6c3c27b8c5714092f235aa409cfcc18
(cherry picked from commit bad0a516cd461f5a5385da841858504b67ee5832)
|
|
It leads to an error during checkout:
fatal: no submodule mapping found in .gitmodules for path 'app-controller'
Fix it.
Bug-AGL: SPEC-2977
.
Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
Change-Id: Id27fd6cee4952f9951c6b926c48f7e6cf2194f91
|
|
No homepage url found. Please set a PROJECT_URL cmake variable in
your config.cmake.
Bug-AGL: SPEC-2804
Change-Id: Ia48f90c209cd592224de290fc47e50cfc84b76c6
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
|
|
Remove old app-controller submodule usage in favor of library from the
toolchain. Also update dynamic API calls for V3.
Bug-AGL: SPEC-2857
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Ib52d00939e0c5998004c96b9ec1a41905f8d71fb
|
|
Remove old afb-helpers submodule usage in favor of library from the
toolchain. Note that json.hpp is no longer shipped with the library,
and is now assumed to be present in the toolchain, which requires a
DEPENDS addition in the recipe to pick it up.
Bug-AGL: SPEC-2855
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I9114b0a0bbe262224a2c12444e589ef7fdb907f5
|
|
Avoid copying over the same file with the wgt output, and prevent
the following error:
cp: 'build/vshl-capabilities.wgt' and 'build/vshl-capabilities.wgt' are the same file
make: *** [autobuild/agl/autobuild:62: package] Error 1
Bug-AGL: SPEC-2430
Change-Id: I596fa8d6bf4b31ad10ca55b475d91ed89ce783e0
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Change-Id: I481616401bfd5ef323c83643f1d7c06146b1fc79
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
|
|
This API is responsible for brokering capbilities related
messages from voiceagents to apps and vice versa.
Verbs exposed are
navigation/publish
navigation/subscribe
phonecontrol/publish
phonecontrol/subscribe
playbackcontroller/publish
playbackcontroller/subscribe
guiMetadata/publish
guiMetadata/subscribe
This API exposes publish and subscribe methods for all
the speech framework domains/capabilities. For eg. navigation,
phonecontrol etc. This API is used by apps and low level voice
agent binding to subscribe and publish these capability messages
whenever applicable.
This specific commit is for vshl-capabilities API.
Change-Id: I822c2e8589e39574d707a7c199bea91a686dced7
Signed-off-by: Naveen Bobbili <nbobbili@amazon.com>
|
|
|