summaryrefslogtreecommitdiffstats
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2020-01-02Fix event JSON reference count issueshalibut_8.0.6halibut_8.0.5halibut/8.0.6halibut/8.0.58.0.68.0.5halibutScott Murray1-0/+24
It was noticed that vshl-capabilities was triggering the reference count check in json-c and asserting: ../json-c-0.13.1/json_object.c:189: json_object_put: Assertion `jso->_ref_count > 0' failed. Initially, this was only seen once during ad hoc testing, but investigation into using the capabilities events started triggering it reproducibly. The root cause seems to be the capabilities binding reusing the json-c objects it receives from voiceagent events to send out itself. That results in the objects getting json_object_put called on them a second time by the app framework when they're resent. To fix this, call json_object_put on the reused objects to keep their reference count correct and avoid triggering the assert. Bug-AGL: SPEC-3053 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: I533bf492e740509cebd8d3487c9658e175fe73f9
2020-01-02Update navigation event namesScott Murray1-4/+2
Change set_destination/cancel_navigation to match the setDestination/cancelNavigation that alexa-voiceagent-service seems to have switched to at some point between 1.3 and 2.0. It does not seem worthwhile trying to get Amazon to change on their side, and additionally 2.1 changes the whole API so capabilities will need to be reworked again anyway. Bug-AGL: SPEC-3083 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: I52c0eb78c6c3c27b8c5714092f235aa409cfcc18
2019-10-15Switch to appcontroller libraryScott Murray12-67/+62
Remove old app-controller submodule usage in favor of library from the toolchain. Also update dynamic API calls for V3. Bug-AGL: SPEC-2857 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: Ia93b162764eb2e700487c05fe9a0dbbdc8843931 (cherry picked from commit 218cc70720fce6235d74fd4d851629dfda34a00e)
2019-10-15Switch to afb-helpers libraryScott Murray3-8/+4
Remove old afb-helpers submodule usage in favor of library from the toolchain. Note that json.hpp is no longer shipped with the library, and is now assumed to be present in the toolchain, which requires a DEPENDS addition in the recipe to pick it up. Bug-AGL: SPEC-2855 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: Ieefd3be424ed9e866debc5e73c9b0995c9cdc31c (cherry picked from commit d8ddb879b61b956d0a7ebd6a181595c9a41a9562)
2019-02-25vshl-capabilities:Naveen Bobbili56-0/+4289
This API is responsible for brokering capbilities related messages from voiceagents to apps and vice versa. Verbs exposed are navigation/publish navigation/subscribe phonecontrol/publish phonecontrol/subscribe playbackcontroller/publish playbackcontroller/subscribe guiMetadata/publish guiMetadata/subscribe This API exposes publish and subscribe methods for all the speech framework domains/capabilities. For eg. navigation, phonecontrol etc. This API is used by apps and low level voice agent binding to subscribe and publish these capability messages whenever applicable. This specific commit is for vshl-capabilities API. Change-Id: I822c2e8589e39574d707a7c199bea91a686dced7 Signed-off-by: Naveen Bobbili <nbobbili@amazon.com>