Adjust method signature to be more efficient.

Return vector reference and doesn't return const ref.

Change-Id: Ibcbc1d72e4baf1a7b8bf017d36d6d37d25312d6d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

# Conflicts:
#	CAN-binder/low-can-binding/can/can-signals.hpp

1 files changed, 5 insertions, 16 deletions

diff --git a/CAN-binder/low-can-binding/can/can-message-definition.cpp b/CAN-binder/low-can-binding/can/can-message-definition.cpp
index 19f06fb..256af88 100644
--- a/CAN-binder/low-can-binding/can/can-message-definition.cpp
+++ b/CAN-binder/low-can-binding/can/can-message-definition.cpp
@@ -17,12 +17,12 @@
 
 #include "can-message-definition.hpp"
 
-can_message_definition_t::can_message_definition_t(const std::string& bus)
+can_message_definition_t::can_message_definition_t(const std::string bus)
 	: parent_{nullptr}, bus_{bus}, last_value_{CAN_MESSAGE_SIZE}
 {}
 
 can_message_definition_t::can_message_definition_t(
-	const std::string& bus,
+	const std::string bus,
 	uint32_t id,
 	frequency_clock_t frequency_clock,
 	bool force_send_changed)
@@ -35,7 +35,7 @@ can_message_definition_t::can_message_definition_t(
 {}
 
 can_message_definition_t::can_message_definition_t(
-	const std::string& bus,
+	const std::string bus,
 	uint32_t id,
 	can_message_format_t format,
 	frequency_clock_t frequency_clock,
@@ -50,12 +50,12 @@ can_message_definition_t::can_message_definition_t(
 {}
 
 can_message_definition_t::can_message_definition_t(
-	const std::string& bus,
+	const std::string bus,
 	uint32_t id,
 	can_message_format_t format,
 	frequency_clock_t frequency_clock,
 	bool force_send_changed,
-	std::vector<std::shared_ptr<can_signal_t> > can_signals)
+	const std::vector<std::shared_ptr<can_signal_t> >& can_signals)
 	:  parent_{nullptr},
 	bus_{bus},
 	id_{id},
@@ -71,17 +71,6 @@ can_message_definition_t::can_message_definition_t(
 	}
 }
 
-/*can_message_definition_t(const can_message_definition_t& b)
-	:  parent_{b.parent_},
-	bus_{b.bus_},
-	id_{b.id_},
-	format_{b.format_},
-	frequency_clock_{b.frequency_clock_},
-	force_send_changed_{b.force_send_changed_},
-	last_value_{b.last_value_},
-	can_signals_{b.can_signals_}
-	{}*/
-
 const std::string can_message_definition_t::get_bus_name() const
 {
 	return bus_;