diff options
| author |   Romain Forlot <romain.forlot@iot.bzh> | 2017-05-23 23:59:27 +0200 |
|---|---|---|
| committer | Romain Forlot <romain.forlot@iot.bzh> | 2017-05-23 23:59:27 +0200 |
| commit | 7747851ca010a3dfe9ffee808376dd5a7af68b91 (patch) | |
| tree | 901e33d39e013c992adab34e7f5af82e5811eade /CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp | |
| parent | f30dc1a18dbb32880bdc0c9021b756c0f846ad53 (diff) | |
Static code review fixes.
Several style errors and mistakes mostly on constructor and passing arguments
as ref.
Change-Id: I2ca921d6aa70b9074392bb7779ade35bebf7bd8d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Diffstat (limited to 'CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp')
| -rw-r--r-- | CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp b/CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp index 4455aa8..df093b0 100644 --- a/CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp +++ b/CAN-binder/low-can-binding/diagnostic/diagnostic-message.cpp @@ -34,10 +34,10 @@ const char *UNIT_NAMES[10] = { "NM" }; -diagnostic_message_t::diagnostic_message_t(uint8_t pid, const std::string generic_name, const int min, +diagnostic_message_t::diagnostic_message_t(uint8_t pid, const std::string& generic_name, const int min, const int max, enum UNIT unit, float frequency, DiagnosticResponseDecoder decoder, DiagnosticResponseCallback callback, bool supported) - : pid_{pid}, generic_name_{generic_name}, min_{min}, max_{max}, unit_{unit}, + : parent_{nullptr}, pid_{pid}, generic_name_{generic_name}, min_{min}, max_{max}, unit_{unit}, frequency_{frequency}, decoder_{decoder}, callback_{callback}, supported_{supported} {} |