summaryrefslogtreecommitdiffstats
path: root/CAN-binder/low-can-binding/utils
diff options
context:
space:
mode:
authorRomain Forlot <romain.forlot@iot.bzh>2017-05-23 23:59:27 +0200
committerRomain Forlot <romain.forlot@iot.bzh>2017-05-23 23:59:27 +0200
commit7747851ca010a3dfe9ffee808376dd5a7af68b91 (patch)
tree901e33d39e013c992adab34e7f5af82e5811eade /CAN-binder/low-can-binding/utils
parentf30dc1a18dbb32880bdc0c9021b756c0f846ad53 (diff)
Static code review fixes.
Several style errors and mistakes mostly on constructor and passing arguments as ref. Change-Id: I2ca921d6aa70b9074392bb7779ade35bebf7bd8d Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Diffstat (limited to 'CAN-binder/low-can-binding/utils')
-rw-r--r--CAN-binder/low-can-binding/utils/config-parser.hpp2
-rw-r--r--CAN-binder/low-can-binding/utils/timer.cpp6
-rw-r--r--CAN-binder/low-can-binding/utils/timer.hpp2
3 files changed, 5 insertions, 5 deletions
diff --git a/CAN-binder/low-can-binding/utils/config-parser.hpp b/CAN-binder/low-can-binding/utils/config-parser.hpp
index 0453110..3115e9b 100644
--- a/CAN-binder/low-can-binding/utils/config-parser.hpp
+++ b/CAN-binder/low-can-binding/utils/config-parser.hpp
@@ -35,7 +35,7 @@ namespace utils
public:
config_parser_t(config_parser_t&&) = default;
config_parser_t(const config_parser_t&) = default;
- config_parser_t(std::string conf_file);
+ explicit config_parser_t(std::string conf_file);
const std::string& filepath() const;
bool check_conf();
diff --git a/CAN-binder/low-can-binding/utils/timer.cpp b/CAN-binder/low-can-binding/utils/timer.cpp
index 9c22bd0..4584b85 100644
--- a/CAN-binder/low-can-binding/utils/timer.cpp
+++ b/CAN-binder/low-can-binding/utils/timer.cpp
@@ -24,7 +24,7 @@
long long int system_time_us()
{
struct timespec t_usec;
- long long int timestamp_usec;
+ long long int timestamp_usec = 0;
if(!::clock_gettime(CLOCK_MONOTONIC, &t_usec))
timestamp_usec = (t_usec.tv_nsec / 1000ll) + (t_usec.tv_sec* 1000000ll);
@@ -34,7 +34,7 @@ long long int system_time_us()
long long int system_time_ms()
{
struct timespec t_msec;
- long long int timestamp_msec;
+ long long int timestamp_msec = 0;
if(!::clock_gettime(CLOCK_MONOTONIC, &t_msec))
timestamp_msec = (t_msec.tv_nsec / 1000000ll) + (t_msec.tv_sec* 1000ll);
@@ -44,7 +44,7 @@ long long int system_time_ms()
long long int system_time_s()
{
struct timespec t_sec;
- long long int timestamp_sec;
+ long long int timestamp_sec = 0;
if(!::clock_gettime(CLOCK_MONOTONIC, &t_sec))
timestamp_sec = t_sec.tv_sec;
diff --git a/CAN-binder/low-can-binding/utils/timer.hpp b/CAN-binder/low-can-binding/utils/timer.hpp
index 432d513..560a818 100644
--- a/CAN-binder/low-can-binding/utils/timer.hpp
+++ b/CAN-binder/low-can-binding/utils/timer.hpp
@@ -42,7 +42,7 @@ private:
public:
frequency_clock_t();
- frequency_clock_t(float frequency);
+ explicit frequency_clock_t(float frequency);
frequency_clock_t(float frequency, uint64_t last_tick, time_function_t time_function);
float get_frequency() const;