summaryrefslogtreecommitdiffstats
path: root/app/mapviewer.qml
diff options
context:
space:
mode:
authorLi Xiaoming <lixm.fnst@cn.fujitsu.com>2019-09-22 20:56:19 +0800
committerLi Xiaoming <lixm.fnst@cn.fujitsu.com>2019-09-22 20:56:19 +0800
commit57881a95bf730dec7dd010bc086a5c42003840d4 (patch)
tree46c93228a9c74366026ceb45b282767e5e9564a6 /app/mapviewer.qml
parentae47635e56c4af4d816a76e5186e945768543679 (diff)
Message: == and != may perform type coercion, use === or !== to avoid it. Description: The non-strict equality comparison is allowed to convert its arguments to a common type. That can lead to unexpected results such as ' \t\r\n' == 0 being true. Use the strict equality operators === and !== and be explicit about conversions you require. Bug-AGL: SPEC-2814 Change-Id: I4dd5848797f445d082242a5c5e2a0148ea790dc0 Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
Diffstat (limited to 'app/mapviewer.qml')
-rw-r--r--app/mapviewer.qml10
1 files changed, 5 insertions, 5 deletions
diff --git a/app/mapviewer.qml b/app/mapviewer.qml
index 6240600..a92a9fd 100644
--- a/app/mapviewer.qml
+++ b/app/mapviewer.qml
@@ -449,8 +449,8 @@ ApplicationWindow {
stackView.showMessage(qsTr("Coordinates"),text);
}
onGeocodeFinished:{
- if (map.geocodeModel.status == GeocodeModel.Ready) {
- if (map.geocodeModel.count == 0) {
+ if (map.geocodeModel.status === GeocodeModel.Ready) {
+ if (map.geocodeModel.count === 0) {
stackView.showMessage(qsTr("Geocode Error"),qsTr("Unsuccessful geocode"))
} else if (map.geocodeModel.count > 1) {
stackView.showMessage(qsTr("Ambiguous geocode"), map.geocodeModel.count + " " +
@@ -458,7 +458,7 @@ ApplicationWindow {
} else {
stackView.showMessage(qsTr("Location"), geocodeMessage(),page)
}
- } else if (map.geocodeModel.status == GeocodeModel.Error) {
+ } else if (map.geocodeModel.status === GeocodeModel.Error) {
stackView.showMessage(qsTr("Geocode Error"),qsTr("Unsuccessful geocode"))
}
}
@@ -467,10 +467,10 @@ ApplicationWindow {
onShowGeocodeInfo: stackView.showMessage(qsTr("Location"),geocodeMessage(),page)
onErrorChanged: {
- if (map.error != Map.NoError) {
+ if (map.error !== Map.NoError) {
var title = qsTr("ProviderError")
var message = map.errorString + "<br/><br/><b>" + qsTr("Try to select other provider") + "</b>"
- if (map.error == Map.MissingRequiredParameterError)
+ if (map.error === Map.MissingRequiredParameterError)
message += "<br/>" + qsTr("or see") + " \'mapviewer --help\' "
+ qsTr("how to pass plugin parameters.")
stackView.showMessage(title,message);