Age | Commit message (Collapse) | Author | Files | Lines |
|
Message:
== and != may perform type coercion, use === or !== to avoid it.
Description:
The non-strict equality comparison is allowed to convert its arguments
to a common type. That can lead to unexpected results such as
' \t\r\n' == 0 being true. Use the strict equality operators === and
!== and be explicit about conversions you require.
Bug-AGL: SPEC-2814
Change-Id: I94130d38621a8775593edab63d409654dd758ef2
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
|
|
Change from ALSA sink to new pipewire sink for output, and add setting
of the pipewire media role property.
Bug-AGL: SPEC-2634
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Idc1dca82c8329071698ef0766a0ec1f50d90a98f
|
|
|
|
Added the missing new audio permission to the widget manifest, and
reworked ringtone audio output to remove 4A support.
Bug-AGL: SPEC-2558
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I7ca5a438333bd046a1634a9056291bd7c215d4e6
|
|
Allow user to request new/initial phonebook OBEX transfers
from connected device.
Bug-AGL: SPEC-2541
Change-Id: I89a49d261fc4aef6219c39cc4b75ec400c0df101
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Bug-AGL: SPEC-2541
Change-Id: I996af8d6025bce0cd44d1da13a0a95cdb4fbefaa
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Add the permission required to access the display
through the wayland socket.
Change-Id: I75225d8b7db445edf2f298271a100250060a0ebe
Bug-AGL: SPEC-2357
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
|
|
|
|
Enable/disable the dialpad based on the handsfree profile connection
status. Note this has nothing to do with if an active call is connected.
Bug-AGL: SPEC-2257
Change-Id: Ibaedab7c6b9a4151fdded73a07a04de9c554e2f0
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Change-Id: I6b56c5038de9f7b04aba38d30c6c45f93365bd59
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
|
|
- Add agl autobuild script to silence build
warnings on yocto.
- Add linux autobuild script to build with
the sdk
These 2 scripts are based on the latest version
of the autobuild script, but they've been
customized to (i) work with the existing qmake
files and (ii) the 'update' and 'package-test'
targets have been removed.
Bug-AGL: SPEC-2164
Change-Id: Ia2a9ce8decb9916a8ebedb757c924b0ff4b0449f
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
|
|
Replace QtMultimedia usage for ringtone playing with a gstreamer
pipeline that uses the provided 4A role ALSA device for output.
For now, a "phone" role is assumed to be available, but it does
not exist in the current set of 4A policy and HALs, and needs to
be added. Testing was done by making the required role changes
locally and using some debug QML tweaks to allow triggering the
ringtone manually.
Bug-AGL: SPEC-1596
Change-Id: I55c2229de1bc5470ee818e5be382b64664fa2d29
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
|
|
Display contact profiles photo when provided in vCards over the PBAP
transport.
Bug-AGL: SPEC-2088
Change-Id: I48117ad76d93ae913775ecdacde6eb34e736dde2
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
The interface of homescreen service will be changed then,
use Event_ShowWindow instead of Event_TapShortcut.
Related changes:
agl-service-homescreen: https://gerrit.automotivelinux.org/gerrit/#/c/17929/
libhomescreen: https://gerrit.automotivelinux.org/gerrit/#/c/17931/
libqthomescreen: https://gerrit.automotivelinux.org/gerrit/#/c/17933/
BUG-AGL: SPEC-1931
Change-Id: Icc1533243941e2a49aa0a35d3948bbc71ef477ac
Signed-off-by: wang_zhiqiang <wang_zhiqiang@dl.cn.nexty-ele.com>
|
|
Window Manager set role name as lower_case,
then change role as lower_case.
Bug-AGL: SPEC-1754
Change-Id: Ib85b00678c3162da9a4c03be48c04e486e237b40
Signed-off-by: Kazumasa Mitsunari <knimitz@witz-inc.co.jp>
|
|
Change-Id: I62a5586254d40bfdc6d0e76d0d9f734c24d99f77
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
because of now homescreen-service emit event to one application,
delete the applciation_name check.
Bug-AGL: SPEC-1764
Change-Id: Ib3ce3d13aeeb957c762f1826ff3c9d8bf8e95f1c
Signed-off-by: wang_zhiqiang <wang_zhiqiang@dl.cn.nexty-ele.com>
|
|
Telephony binding needs to be split into own package, and this requires
it to be removed from the phone application
Bug-AGL: SPEC-1757
Change-Id: Ida29d47abbe254a531d69cce33433cce877e1cf2
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
This reverts commit a90666e63c2ae13003f6e5c32324f9c6b35d0a46.
Bug-AGL: SPEC-1685
Change-Id: I4f6e02a8514ef4a20d67b0ef8c3043060d6900df
Signed-off-by: Tadao Tanikawa <tanikawa.tadao@jp.panasonic.com>
|
|
Use appid between hss and apps, and check event destination in libhomescreen.
So these is no need compare code when recived Event_TapShortcut Event.
BUG-AGL: SPEC-1645
Change-Id: If16b93e3333a4214dc5512f1bf1c93a97f388bed
Signed-off-by: zheng_wenlong <wenlong_zheng@nexty-ele.com>
|
|
To improve output on various monitor with various resolution,
use scale_factor from WM to fit various screen resolution.
Bug-AGL: SPEC-1568, SPEC-1569, SPEC-1611
Change-Id: I89f56fc37a5022fec23cf313f878a77c7a6eb111
Signed-off-by: Tadao Tanikawa <tanikawa.tadao@jp.panasonic.com>
|
|
Remove all of the static contacts model support that was
deprecated by the new ContactModel support in libqtappfw.
Goodbye, Art McGee!
Bug-AGL: SPEC-1436
Change-Id: I4e33d459d389c7d35afceb484eb21541660f9750
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Convert ContactsView to use ContactsModel provided
by libqtappfw. This now displays all contacts and
associated phone number from the connected mobile
phone's PBAP-connected contact database.
Bug-AGL: SPEC-1436
Change-Id: I6a26e0c6627247736470e06ddbd611caa7de79b1
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Show the most recent call list entries by refreshing
the call list using telephony call status notifications.
Refresh the recent call list whenever a call is
disconnected. The PBAP call history on the mobile
device is updated on call disconnect (any time it
transitions from incoming/dialed/active to disconnected)
Bug-AGL: SPEC-1436
Change-Id: If09d0b8ee2461e4859fa543c99b9321a3cfb3af7
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Remove all of the static call history model support that was
deprecated by the new RecentCallModel support.
Bug-AGL: SPEC-1436
Change-Id: Ie4354af26d946b40797f57b359dbe1de9f5a9bc3
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Replace static data and history currently used in phone app
with data populated the the BT PBAP binding. This data is
parsed and exposed to QML by the RecentCallModel in libqtappfw.
The recent call tab and the mini-recent call bar in the dialer
tab now show actual call history from the connected mobile phone.
Bug-AGL: SPEC-1436
Change-Id: I287a1daf54ee88985aac85d71215f7fa4e766556
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds support for searching an incoming or outgoing phone number
for a contact name. If found, displays the contact name as
appropriately when displaying the incoming or outgoing call
information.
Bug-AGL: SPEC-1513
Change-Id: I88c7cb4a91abdc34d17cd80e4fccfdcaf2e0d229
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds support for a tabbed view of contacts, recent call,
and the dialpad. This adjusts the UI to look more like a
modern mobile phone app. The same models populate the
contacts view and the recent call view as before with
the latter being a more useful full screen list. The recent
call history also includes type of call information (missed,
incoming, outgoing) and the UI displays icons accordingly
to indicate type of call that occured as well as a time
stamp. For now, the icons are placeholders but will be
replaced by icons design to match the AGL look and feel.
Bug-AGL: SPEC-1435
Change-Id: I521155a11208e92ece83f20f7f3dd643deb92099
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adjust the call function to accept discrete parameters for
the name and phone number to dial. This prepares the app
for a reworked UI where the contact model is not always
used to invoke a phone call.
Bug-AGL: SPEC-1435
Change-Id: I178a7eb6c4854f755abd94234a648f861d5c1326
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
|
|
The current contact model has a few fixed fields for
phone numbers and only one is displayed and able to be
dialed from the contacts view. Update the model to support
an array of tuples indicating each phone number and type
of phone number (mobile, home, work, other) associated
with a contact entry. Also, update the ContactsView so
we see all phone numbers for a given contact.
Bug-AGL: SPEC-1435
Change-Id: Ie883d3f06c0e4102e79546395dbb1712741bac8b
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Change-Id: Ifcb769e9b837e9c41a3fed85c983d43ea43552b6
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
|
|
The binding currently only queries for a BT HFP enabled modem
once at binding init time.
To support runtime modem changes, use BT binding events to
handle connection and disconnection of BT HFP devices. The
default voice call modem is now torn down on device disconnect
and initialized when a new BT HFP device is connected at runtime.
Bug-AGL: SPEC-1433
Change-Id: Icea7686ef5ecb80b0d33560e4499ca1fd6285147
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Add additional calls to manage runtime connection/disconnection of
voice modem interfaces and querying if there's a valid modem
present.
Bug-AGL: SPEC-1433
Change-Id: I824bfe2ff383fca5516e8581e97278f7b3807364
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Pre-init was implemented but unused. Remove the useless code.
Change-Id: Ie3e9a14666fbd2ff4efa038d30d8e9db823d4972
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Remove unneeded debug/notice message from the new HMI init code.
The logs are verbose enough as is without the HMI-specific messages
drowning out the real phone app-specific info.
Change-Id: I5d17de3a6806a967d4c676b5a2d19ac6599fa204
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
The current application name is very awkward in logs so rename
this to "Phone Dialer Application"
Change-Id: Ib417082717cb8af7e429f6aabc95a59146f14d18
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Remove build warning introduced by migration to new
HMI framework.
Bug-AGL: SPEC-1428
Change-Id: I55638881e000da9f6599026783545b7c225ce471
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
|
|
[Error]
../../git/telephony-binding/gdbus/ofono_voicecallmanager.c:44:7:
error: 'state' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
Bug-AGL: SPEC-1181
Signed-off-by: Changhyeok Bae <changhyeok.bae@gmail.com>
|
|
Acitve/Incactive were inversed for button 7.
Bug-AGL: SPEC-673
Change-Id: Ib5fad062e5b2e886b3fcb9f3267a2beff8915039
Signed-off-by: Tadao Tanikawa <tanikawa.tadao@jp.panasonic.com>
|
|
The color scheme has been changed to new one.
Bug-AGL: SPEC-673
Change-Id: I4aaa397766dd815853ad6a361759774faa986e1a
Signed-off-by: Tadao Tanikawa <tanikawa.tadao@jp.panasonic.com>
|
|
Changes following guidelines given in "Kickstart: New HMI Framework"
document at:
https://wiki.automotivelinux.org/_media/kickstart_apps_migration_guide.pdf
Change-Id: Ia0736b44b19f0375f216d280ac2be8b3857a8802
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
|
|
Removes the QML call timer implementation in favor of a C++
implementation in the Phone class. This allows the call timer
to be started even if the QML application is in the background
(QSG RenderThread not scheduled).
Bug-AGL: SPEC-1083
Change-Id: I0cb9087d73862992d25b105f97b830eef5c83ef0
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds a Phone class that implements ringtone logic. This
allows for the ringtone to be started/stopped even if the phone
app is not visible (QML render thread not executing) and the QML
implementation can be removed.
Bug-AGL: SPEC-1081
Change-Id: I7d0dd5f167ce1f53477d6c9d8053111996033e4c
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Remove the QML/Javascript websocket and appfw message
handling code. This is replaced with libqtappfw's Telephony
class which handles all Telephony API binding communication
in a separate thread.
Bug-AGL: SPEC-1079
Change-Id: I06b352eaf4925fc144c59f8d8f689180376a1f35
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Convert telephony-binding and phone app from broadcast events
to subscribe/unsubscribe events.
Bug-AGL: SPEC-815
Change-Id: I6288db22332277e217b3f1a4e79a391cb63ebc16
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Convert the telephony-binding to the v2 binding format.
Also move to AFB_ message macros and remove propagation
of the interface struct.
Bug-AGL: SPEC-814
Change-Id: Ic9ce86f59af01ce00cece4e29cd5fe36afa7d74c
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds additional error checking and reporting to the binding so
that errors resulting from lack of a telephony modem can be reported
at init. This fixes the issue where the phone app crashes and the
afb-daemon can only report a segfault on start.
AGL-Bug: SPEC-621
Change-Id: Ie3e12cb69a2a04cf7308e6bd244add581b8578db
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds support for disconnection of an alerting incoming call to
the telephony binding via the hangup verb. This is support in
the phone UI by an additional button being loaded in the
incoming call state allowing the user to decline to answer the
call or use the already present answer call button to accept
it.
AGL-Bug: SPEC-601
Change-Id: I56ad0b813c0f1f24688709d180c3c061d7511651
Signed-off-by: Matt Porter <mporter@konsulko.com>
|