Age | Commit message (Collapse) | Author | Files | Lines |
|
Message:
== and != may perform type coercion, use === or !== to avoid it.
Description:
The non-strict equality comparison is allowed to convert its arguments
to a common type. That can lead to unexpected results such as
' \t\r\n' == 0 being true. Use the strict equality operators === and
!== and be explicit about conversions you require.
Bug-AGL: SPEC-2814
Change-Id: I94130d38621a8775593edab63d409654dd758ef2
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
|
|
Enable/disable the dialpad based on the handsfree profile connection
status. Note this has nothing to do with if an active call is connected.
Bug-AGL: SPEC-2257
Change-Id: Ibaedab7c6b9a4151fdded73a07a04de9c554e2f0
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Replace QtMultimedia usage for ringtone playing with a gstreamer
pipeline that uses the provided 4A role ALSA device for output.
For now, a "phone" role is assumed to be available, but it does
not exist in the current set of 4A policy and HALs, and needs to
be added. Testing was done by making the required role changes
locally and using some debug QML tweaks to allow triggering the
ringtone manually.
Bug-AGL: SPEC-1596
Change-Id: I55c2229de1bc5470ee818e5be382b64664fa2d29
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
|
|
Remove all of the static contacts model support that was
deprecated by the new ContactModel support in libqtappfw.
Goodbye, Art McGee!
Bug-AGL: SPEC-1436
Change-Id: I4e33d459d389c7d35afceb484eb21541660f9750
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Show the most recent call list entries by refreshing
the call list using telephony call status notifications.
Refresh the recent call list whenever a call is
disconnected. The PBAP call history on the mobile
device is updated on call disconnect (any time it
transitions from incoming/dialed/active to disconnected)
Bug-AGL: SPEC-1436
Change-Id: If09d0b8ee2461e4859fa543c99b9321a3cfb3af7
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Replace static data and history currently used in phone app
with data populated the the BT PBAP binding. This data is
parsed and exposed to QML by the RecentCallModel in libqtappfw.
The recent call tab and the mini-recent call bar in the dialer
tab now show actual call history from the connected mobile phone.
Bug-AGL: SPEC-1436
Change-Id: I287a1daf54ee88985aac85d71215f7fa4e766556
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds support for searching an incoming or outgoing phone number
for a contact name. If found, displays the contact name as
appropriately when displaying the incoming or outgoing call
information.
Bug-AGL: SPEC-1513
Change-Id: I88c7cb4a91abdc34d17cd80e4fccfdcaf2e0d229
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds support for a tabbed view of contacts, recent call,
and the dialpad. This adjusts the UI to look more like a
modern mobile phone app. The same models populate the
contacts view and the recent call view as before with
the latter being a more useful full screen list. The recent
call history also includes type of call information (missed,
incoming, outgoing) and the UI displays icons accordingly
to indicate type of call that occured as well as a time
stamp. For now, the icons are placeholders but will be
replaced by icons design to match the AGL look and feel.
Bug-AGL: SPEC-1435
Change-Id: I521155a11208e92ece83f20f7f3dd643deb92099
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adjust the call function to accept discrete parameters for
the name and phone number to dial. This prepares the app
for a reworked UI where the contact model is not always
used to invoke a phone call.
Bug-AGL: SPEC-1435
Change-Id: I178a7eb6c4854f755abd94234a648f861d5c1326
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
The current contact model has a few fixed fields for
phone numbers and only one is displayed and able to be
dialed from the contacts view. Update the model to support
an array of tuples indicating each phone number and type
of phone number (mobile, home, work, other) associated
with a contact entry. Also, update the ContactsView so
we see all phone numbers for a given contact.
Bug-AGL: SPEC-1435
Change-Id: Ie883d3f06c0e4102e79546395dbb1712741bac8b
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Removes the QML call timer implementation in favor of a C++
implementation in the Phone class. This allows the call timer
to be started even if the QML application is in the background
(QSG RenderThread not scheduled).
Bug-AGL: SPEC-1083
Change-Id: I0cb9087d73862992d25b105f97b830eef5c83ef0
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds a Phone class that implements ringtone logic. This
allows for the ringtone to be started/stopped even if the phone
app is not visible (QML render thread not executing) and the QML
implementation can be removed.
Bug-AGL: SPEC-1081
Change-Id: I7d0dd5f167ce1f53477d6c9d8053111996033e4c
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Remove the QML/Javascript websocket and appfw message
handling code. This is replaced with libqtappfw's Telephony
class which handles all Telephony API binding communication
in a separate thread.
Bug-AGL: SPEC-1079
Change-Id: I06b352eaf4925fc144c59f8d8f689180376a1f35
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds support for disconnection of an alerting incoming call to
the telephony binding via the hangup verb. This is support in
the phone UI by an additional button being loaded in the
incoming call state allowing the user to decline to answer the
call or use the already present answer call button to accept
it.
AGL-Bug: SPEC-601
Change-Id: I56ad0b813c0f1f24688709d180c3c061d7511651
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds support to the telephony binding for generating events when
a call's state changes to active or disconnected states (when a
remote/local party answers or disconnects the call). These events
are used to drive a call duration display in the phone app UI.
AGL-Bug: SPEC-599
Change-Id: Ib4b0b115ca1d0573a7ae046082627f561f0d8d8a
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds an answer verb and associated incoming call lifecycle
management to the telephony binding. Leverages the binding
answer support to activate the call answer button when the
binding reports that we are in an incoming call state. Once
the incoming call is answered, the ring tone is deactivated.
AGL-Bug: SPEC-600
Change-Id: I4f2db2d248cfd0f4945fc17d450e9b691061cc9e
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Add supports for incoming call, dialing call, and terminated call events
in the telephony binding. The phone UI is enhanced to make use of these
telephony binding events to display a notifications of phone call
status. These include generate a ring tone and displaying incoming phone
number information, outgoing phone number being dialed, and halt of the
ring tone and clearing of the notification space when a call is
terminated.
AGL-Bug: SPEC-598
Change-Id: Ied610b70c2e6edb1f631decd417cdbd39746a558
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Adds support for initiating and hanging up a voice call from the
phone app dial pad. This support leverages the basic telephony
binder API and pulseaudio as an ofono agent.
AGL-Bug: SPEC-597
Change-Id: I94e8c64a76164f04c6573d7126a8cc725b3c679d
Signed-off-by: Matt Porter <mporter@konsulko.com>
|
|
Change-Id: Id7ad21f47ea50d15156171a7dfa139da46c4f977
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
|