summaryrefslogtreecommitdiffstats
path: root/alsa-hook
diff options
context:
space:
mode:
authorJonathan Aillet <jonathan.aillet@iot.bzh>2018-07-19 11:56:59 +0200
committerJonathan Aillet <jonathan.aillet@iot.bzh>2018-07-20 11:39:22 +0000
commit22043a68d0fe0652dd7e0b1041f6f448e867390b (patch)
tree6cad9b1e8b50b98fe6ed561f4c3670612b087b1e /alsa-hook
parent4303ba22a8cacea808eaf8f487303d1360ac4150 (diff)
Correct warning that was raised at compilation
Correct warning that was raised at compilation concerning 3 subjects : - Too short strings for 'snprintf'. - Forget cast returns of 'json_object_array_length' function. - Checking return of 'asprintf' function. Change-Id: I0fc702750841a0f8da921c3c3b1453c5afee0fd8 Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
Diffstat (limited to 'alsa-hook')
-rw-r--r--alsa-hook/PolicyAlsaHook.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/alsa-hook/PolicyAlsaHook.c b/alsa-hook/PolicyAlsaHook.c
index e93edae..62b1a2f 100644
--- a/alsa-hook/PolicyAlsaHook.c
+++ b/alsa-hook/PolicyAlsaHook.c
@@ -275,7 +275,10 @@ static int CallWithTimeout(afbClientT *afbClient, afbRequestT *afbRequest, int c
int err;
// create a unique tag for request
- (void)asprintf(&afbRequest->callIdTag, "%d:%s", count, afbRequest->apiverb);
+ if(asprintf(&afbRequest->callIdTag, "%d:%s", count, afbRequest->apiverb) < 0) {
+ printf("Couldn't allocate request call unique id tag string\n");
+ goto OnErrorExit;
+ }
// create a timer with ~250us accuracy
sd_event_now(afbClient->sdLoop, CLOCK_MONOTONIC, &usec);
@@ -673,10 +676,13 @@ int PLUGIN_ENTRY_POINT (snd_pcm_t *pcm, snd_config_t *conf) {
afbClient->pcm = pcm;
afbClient->name= strdup(snd_pcm_name(pcm));
afbClient->verbose = 0;
- (void) asprintf(&afbClient->uid, "hook:%s:%d", afbClient->name, getpid());
+ if(asprintf(&afbClient->uid, "hook:%s:%d", afbClient->name, getpid()) < 0) {
+ SNDERR("Couldn't allocate client uid string");
+ goto OnErrorExit;
+ }
// Get PCM arguments from asoundrc
- printf("HookEntry handle=0x%x pcm=%s\n", afbClient, afbClient->name);
+ printf("HookEntry handle=0x%p pcm=%s\n", afbClient, afbClient->name);
snd_config_for_each(it, next, conf) {
snd_config_t *node = snd_config_iterator_entry(it);
const char *id;