summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-06-15desktop: Remove commiting code for the panelMarius Vlad3-73/+1
We no longer use older qtwayland version so there's no need to keep in place anymore. Bug-AGl: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Icad3d208ea96739b780dfef5911e855a7a39af6a
2020-06-15shell: Do not remove the black surface if we don't have a backgroundMarius Vlad1-1/+2
set for that output Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I07ca7108e37dcdb992de0e2223bde3f9fa200863
2020-06-15desktop: Display a black surface for apps being moved using config fileMarius Vlad1-3/+9
Just like the 'remote' surface roles, put back a black surface if there's no background set and if it is the last surface on that output. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I7bd7ae55fc668753223a23462b697071faa16525
2020-06-15layout: Remove black surface when trying to use migrate views to otherMarius Vlad1-0/+7
outputs We install a black surface in the fullscreen layer for each output, and we need to remove it before adding the new surfaces/views. We did that aleady for 'remote' type of surfaces when categorizing the type, but here we use the configuration file to determine the output, but we were missing the black surface for that output. This verifies that the black surface for that output is in use, and removes the black surface if so. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I3c4ae90ee0983bc424c932715d9a1ff082117bef
2020-06-15src/: Use agl-shell-app-id to set-up views on a different outputMarius Vlad3-9/+46
This makes it easier to specify the application directly in the configuration file, without the ned to modify the application code. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ic38ca0aaf05ce8f1c4993341c9d767acfd25eb43
2020-06-15layout: Add a wrapper to print out the surface roleMarius Vlad3-4/+57
With this we add a few more debug statements to the log file. Nothing too spurious but helps debugging more quickly if needed. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: If345903428cbb9c895e22980fdf64aec3c03d3b7
2020-06-14src: Insert a black surface/remove it when the last remoteMarius Vlad3-5/+40
surface role is present Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ia47c0539ff26d1378bb9ac75e19592d7b8b2b3bf
2020-06-14layout, desktop: Treat the remote surface role like the desktop oneMarius Vlad2-7/+55
Necessary changes so that we can handle the remote surface just like the regular desktop one. We use the same code when committing the surface but modify the completion part to only modify the pending output as to avoid remote surfaces interfering with the enum representing each surface type. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ied770c8fd8cd7021a7efb5cf07bc44ab2cf93cce
2020-06-14layout: Remove the quirks as now we have the policy hooks in placeMarius Vlad3-25/+2
to handle that With the policy hooks in place we no longer need this quirk to activate surfaces by default when starting up, and was potentially seen as hole to bypass the policy hooks. Remove it and just allow the policy hook to control how that happens. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I4c28648f0805e5c593c082c644d2e126b1d9df6b
2020-06-14src/: Add the remote surface roleMarius Vlad4-0/+87
This patch adds the 'remote' surface role, which clients can make use of to hint the compositor that it should place the surface on other output. While both private extension protocols (agl-shell and agl-shell-desktop) explicitly require a wl_output when activating or when setting surface roles, we still need the inform the compositor that the surface should be placed on another output. This is due to the activate_by_default functionality that requires having an output being present, with the default regular XDG desktop role deriving its output by using the output of the backgound surface (which is being normally set by the client shell). Just like pop-up dialog role and split surface role this patch adds another temporary hold up place before the surface is actually created. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ic67246ecc183826ae59b2c99a671885d61040249
2020-06-08src/: Add all surface roles to a wrapper for retrieving the outputMarius Vlad3-15/+18
Adds the other surface roles to the it. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ia0c659bfd0dbf96d53ee6f24d3c4296b3ffdad2d
2020-06-08layout: Do not attempt to activate a split or a fs surfaceMarius Vlad1-2/+23
As long as there is (an already created) surface in a split/fs type of role there's no point in trying to activate it. Users can mistakenly try to do that so have some logic in place to avoid it. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Id9b8e039b6d53fbfb4e310166a91c2cb6a45cb4e
2020-06-08layout: Resize the active surface when doing the splitMarius Vlad3-6/+71
This adds an intermediate geometry variable which is used to save and restore to the original available geometry when destroying the split surface. This takes care to inform the client that a new resize is needed when the split surface is destroyed or when the split surface is committed. The width and height of the split surface is derived from the available geometry area size (the available size of the background surface) but this can further adapted to be based on the split window size (that is, it could be specified by the client). This assumption is there to simplify the implementation. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ia484a922a7cbd314db2c878f81cb548458d1c1cd
2020-06-08layout: Allow to commit the fullscreen and split surface rolesMarius Vlad4-1/+119
Now that we have the ability to discern between fullscreend and split roles, use specific functions when doing the commit to further customize them. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Idf4ed55533c46925638a466e9713465d710b6845
2020-06-08layout: Remove unused ivi_compositor referenceMarius Vlad1-1/+0
Removes a unused warning about ivi_compositor. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I40dbbdfe6036f7aa7d9c38638c1fc79e13681765
2020-06-08shell: Determine the role typeMarius Vlad1-8/+4
Now that we have the ability to determine the role type between pop-up diaglos, full-screen, or split ones use the wrappers installed previously to make use of them. Keep the same functionality by activating the desktop surface if we determine we have one. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ibce3bc040ce3683ab41709d68d5fbf90d90ea539
2020-06-08shell: Introduce fullscreen and split role type of a surfaceMarius Vlad5-13/+206
With it, this also adds two pending lists, for each role type and aggregates the checks used to compare against the roles type when the surface is being created. There's no functional at this stage. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I1900399fe35d9dbc26a93c374ac2f86efa860ba6
2020-06-08desktop: Missing assert includeMarius Vlad1-0/+1
Commit a2f9566bdbfcb8ee added an assert but failed to include the proper header causing an warning and a failure when building locally. Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I5bd0754f0a8dee74e9d5b09d34d80633cb96e666
2020-06-08desktop: Handle correctly panel and bg removal of agl-shell unbindMarius Vlad2-15/+23
We don't need to free the ivi_surface when un-binding the agl-shell, as that should happen when `desktop_surface_removed()` is called. We'll just invalidate them depending on the role so that next time we're going to able to bind again. Bug-AGL: SPEC-3404 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I6e06b6a1029989bf3e09156b602b6eab6addc5da
2020-06-03README.md: Add documentation details about agl-shell and agl-shell-desktopMarius Vlad1-9/+169
This adds a few words about: - overall architecture and design - protocol extension, agl-shell and agl-shell-desktop - add inline code backticks for missing function names in policy API Bug-AGL: SPEC-3386 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I96f2b08d80ec10dda4e080a772bd2f2456535631
2020-05-12main: Convert to using the logging/debuggging fraemworkMarius Vlad1-25/+51
With this in place we're now using the new logging framework. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I5782b9a9fa825351c630af39bf7542d4bfa14efa
2020-05-12main: Add a (valid) return code when exitingMarius Vlad1-1/+6
Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Id466a9d5bc253e5c65f7f2db328b6ea794457726
2020-05-12main: We don't have weston-debug extension availableMarius Vlad1-2/+0
Copy-pasta mistake, as we don't really have the weston-debug extension added. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I56c36f4d5af830ba5a869a80f73f7f9df3d2e106
2020-05-12meson.build: Add a meson variable to track libweston versionMarius Vlad1-3/+4
Avoids the need to modify, and potentially to forget (like I did), to modify multiple places when moving/migrating to newer libweston version. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ibab581f3e5a6b8253fad0a53dfd870cd4143b797
2020-05-12main: Subscribe to the logger scopeMarius Vlad1-0/+1
This is a no-op as the compositor isn't yet using the logging framework, but will be added in subsequent patches. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ieda47de45de621b095163d0e682e665c36484175
2020-05-12meson.build: Update build versionMarius Vlad0-0/+0
There have been suficient changes like the recent changes in the agl-shell-desktop to require another version update. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ibead5b3e8d474f5608785680528fb92a481380ed
2020-05-12policy-default: Install default for the state event notifyMarius Vlad1-0/+8
Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Id5840ecd1384f15c67a5dd6070f4d02c0e6df690
2020-05-12policy: Add another hook for controlling the application state changeMarius Vlad2-0/+8
event With the introduction of the events that notify regular applications of others' application state we require some way of controlling that. This patch adds another hook for controlling just that. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I2ade01eb5dfa454e360edd2e3943df91975da88f
2020-05-12protocol: agl-shell-desktop: Send notification for application state changeMarius Vlad4-4/+67
The events are sent straight after the activation took place. The state changes are the surface role (for instance, pop-up) and the activate/de-activate type of event. With that information there's also a string type of data which can be used as easy way to forward data. Note that this isn't the proper way for applications to communicate with each other, but merely as a convenient way to pass data from one application to another. In order to hang-off the data, the 'activate_app' request also got an additional argument which is relayed back with the event. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I0c9be86f6ff227b59271cac1c060563b5aac9b6c
2020-05-12policy-default: Install default policy for deactivate requestMarius Vlad1-0/+8
Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I9ea70e6f49eda0a475a185fc037cb2c86b2b2890
2020-05-12policy: Add a new policy hook for deactivating appsMarius Vlad2-0/+7
Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I7260626819b78ff7e2a245dc0a5ef566919220f7
2020-05-12policy-default: Add the de-activate request to the default policyMarius Vlad1-1/+1
We didn't have a valid de-activate for it, but with the 'deactivate_app' that is no longer true to make use of it. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ife520e61360744231a13968f15bc0941ca163966
2020-05-12agl-shell-desktop: Add the ability to hide client windowsMarius Vlad4-2/+132
This would be particularly useful to pop-up kind of window(s). It implements the 'deactivate_app' request. For the pop-up role we just remove the view from the layer while for the desktop we store the previous surface and re-use it if that's set. Otherwise we just display the background surface. As we now allow to hide client windows, we need to able to activate/show them back so this also adds a slight modification to take care to handle the pop-up role separately when calling the 'activate_app' request. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Iec5ccbe2815f4b0e32086fd49856f5f338147f79
2020-05-12layout: Save the pending outputMarius Vlad1-1/+1
As de-activing apps make use of last_pending to retrieve the output, it is vital to keep pending output as well, as we ultimately depend on it. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I62854c3c886a142c35287d5ef1cf492a1a81ac99
2020-05-12shell: Store the ivi compositor in the desktop_clientMarius Vlad2-0/+4
Allows to retrieve the ivi compositor without passing addtional resource in the request. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I515e8133a8bdc6400932d3c08a112982546c3ff9
2020-05-12layout, desktop: Implement the pop-up roleMarius Vlad5-4/+160
Temporally store the application details in a list of pending applications as to be used when creating the desktop surface. Store the output alongside the x and y values, useful in setting up the initial positional values of the window. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Icae57378ff405a8770c074a3e2fe1e04535302ef
2020-05-12agl-shell-desktop: Allow to set role properties for the applicationMarius Vlad1-0/+21
This extends the agl-shell-desktop protocol with a new request that allows to set further properties on the window/client. Bug-AGL: SPEC-3269 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ia88e23c8c1cbc55c5423de480bba7f86c79897d0
2020-05-11shell: Display previously pending surface once the ready request was receivedMarius Vlad1-1/+7
Surfaces are being added to linked list of pending surfaces as long as the 'ready' request wasn't received, and are being categorized as regular apps once the 'ready' request is handled. But, in order to display it, the surface has to be activated. With this patch we force to display/show the last pending surface that was added before issueing a 'ready' request. Obviously, multiple surfaces of this kind will be displayed, but only the last one will remain displayed on the output, hence the refernce of just the last pending surface. A particular use-case that will benifit from this is when for instance the launcher application is started before homescreen. When homescreen starts it will also activate/display the launcher surface. Bug-AGL: SPEC-3341 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Iace641c3b65d0c5500fe336e592d2e8ada57d7e9
2020-05-04meson.build: Increase agl-compositor version for libweston8 upgradeMarius Vlad1-2/+2
Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I03f38948de5676d1c73325045fa1badee01765e2
2020-05-04main: Update weston_compositor_add_log_scope to libweston8Marius Vlad1-1/+1
weston_compositor_add_log_scope() got an additional argument from libweston8. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I359fce11ba3e73ca54a2df99caee6d7333fd78f4
2020-05-04meson.build: Increase to libweston8 dependencyMarius Vlad1-2/+2
Trivial increase dependency. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: If78393eb961eb4f5ac8d605903b8adb354463f05
2020-05-04main: Use bool for weston_config_section_get_bool()Marius Vlad2-5/+5
weston_config_section_get_bool() uses bool instead of integer from libweston8. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I5a3f661824f494f0ba4a02eca5a41b25a460214e
2020-04-14layout: Mark activated surface by defaultMarius Vlad3-1/+10
Necessary to avoid client surfaces that continuously update their contents (i.e., a video) to effectively nullify a valid activate_app request, causing a short flip for the new client surfaces, but resume back once the first surface updated its contents. Bug-AGL: SPEC-3297 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I450dc58d2fa0202f42b7ab58216db98a1bbbf178
2020-04-10desktop: Remove the active surface only if matches the one being displayedMarius Vlad1-1/+1
We incorrectly removed the active surface being displayed even if it wasn't the one currently displayed, so this patch only removes the active surface if the surface being removed is the same as the one being displayed. Bug-AGL: SPEC-3318 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I78c19692d59c3e355b2d140b75d8aadc9d8f2009
2020-03-11meson.build: Increase the build version of agl-compositorMarius Vlad1-2/+2
Increase the version for when policy part was added. Makes tracking of issues much easier in the future. Bug-AGL: SPEC-3217 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I77cf5e5d44b0621745f2c3dd113ab46938fd0c1d
2020-03-11README.md: Start adding some light documentation on the policy partMarius Vlad1-0/+51
Bug-AGL: SPEC-3217 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ifdd6dda9dbe91e2783c4d3546e542aa2320d3707
2020-03-11layout: Allow by default to activate the applicationMarius Vlad2-3/+14
Installs, for the default policy, a callback that allows it. Bug-AGL: SPEC-3217 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ic0f1a7db93df480d263db8240592f65a8864ccd6
2020-03-11policy-default: Install a default policy engineMarius Vlad3-0/+111
This is just an example on how to use the policy framework API and allows all actions to performed by default. Bug-AGL: SPEC-3217 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I83c9e61a2f2a89c373352232009cea4c6f6a3ad6
2020-03-11policy: Init policy framework APIMarius Vlad6-0/+527
This patch adds the policy framework, comprised from hooks which a policy engine can further customize, and which are checked upon surface creation, commit and activation. Users should create specialized versions of these callbacks when creating/desining a policy engine. Further more, it adds the posibility to further customize the policy engine by adding new states, events and policy rules. By default, the policy API is aware of known states like 'start' or 'stop', but also 'show' and 'hide' as events. A policy rule would allow to define the setup in which an event can happen based on the state of the rule compared to that of the system, the action event itself, the application and (optional) an timeout. The policy rules are there to specify the state, the event, and application, but it is ultimately handled by a hook which will be called to handle the event. The compositor will arrange to pass all that information back to the handler, so the policy engine is in control to check in what circumstances the policy can be satisfied. These policy rules allow to handle transitional states which are common in AGL. For instance: If one would want to display the application 'navigation' in 3 seconds after and state has been changed to 'start', it should do add the following rule: ('navigation', STATE_START, EVENT_SHOW, timeout, main_output) Then, when a 'STATE_START' state is propagated to the compositor the policy API will trigger a state change signal which in turn wil arm an timer to execute the event handler after a timeout 'timeout'. Bug-AGL: SPEC-3217 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ie03c5f9b1ddb964949e4f9797cbbe2dd2b32a6b6
2020-03-11ivi-compositor: Use the helpers for array lengthMarius Vlad2-2/+1
Bug-AGL: SPEC-3217 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I11f5b2a761062aeb5b8c146c2b3617362a353e76