summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-07-29shell: Assume consistency with the desktop rolesMarius Vlad1-0/+4
While looking into activation by default of other surfaces, noticed that we're missing consistency on how we handle other types of surface roles. This patch, activate all other surfaces by default when starting up, even if they are started before or after the client shell. Expecting and assuming the same behaviour is important into trying to establish some common work-flow for applications. Bug-AGL: SPEC-3494 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I90e764c6c3a7ed543934ee6f68fa716d90ff151e
2020-07-14policy-*: Remove any private binding restrictions for allow-all policyjellyfish_9.99.2jellyfish/9.99.29.99.2Marius Vlad2-51/+49
As we don't have any proper mechanisms in place to perform some level of authentication on the clients binding to the private extensions, we will resort to allow that to happen, under the default, allow-all policy. In the same time we add some helpers for checking which applications can bind to the private extensions but this is for the deny-all policy. This also includes cluster-receiver and cluster-dashboard application to that array, as without it the cluster-demo will not all work when using the deny-all policy. Bug-AGL: SPEC-3382 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I9ea0d8fd63a323bfcee6aa146a1617aa572d131f
2020-07-03desktop: Fix destruction of applications that fallback to the desktop roleMarius Vlad1-2/+7
With commit 9827cfd25578, application not having a valid app_id will fallback to being assigned the desktop role. In this case, destroying those kind of surfaces will not have an output assigned, so add a code path for those as well. Found while testing cluster-receiver with waylandsink and sub-surfaces. Bug-AGL: SPEC-3382 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: If20bdcf02810c16167fdbfbf30f3fd367c43069b
2020-06-29shell: Avoid checking against surfaces that do not have an app_idMarius Vlad1-4/+4
Not all application will set-up an app_id and we might end up checking against those. So avoid doing that because str* kind of like functions do not like that. Discovered when playing with cluster receiver and sub-surfaces. Bug-AGL: SPEC-3382 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I31b454fd3ccb1770775a00b1c953d9cbef827909
2020-06-26README: Add a few words about the deny-all policy enginejellyfish_9.99.1jellyfish/9.99.19.99.1Marius Vlad2-6/+14
Replaces the agl-shell-desktop mention that all clients can bind to the interface with a mention that that happens only if the policy engine allows. Bug-AGL: SPEC-3413 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ieb6b9df1181cb7a0ad6da09519655ebd8f73a1a5
2020-06-26desktop: Allow desktop_api to handle surface removalMarius Vlad1-3/+7
This patch fixes the situation where the application wasnt't allowed to create an (ivi) surface, leading to an illegal access of the surface by the destroyer desktop_api callback. In case we deny the applications to create the (ivi) surface we let the desktop_api handle the removal of the surface. A surface without a role won't have an output set so we use that to determine if we can remove the link for it. We also avoid dealing with the surface destruction in the desktop api itself rather than handling it on the error path of the hook itself. Bug-AGL: SPEC-3413 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I0fd4d83924b0188f606544b41e70b631c90fc8ee
2020-06-26policy: Add a deny-all policy as an exampleMarius Vlad3-1/+220
Note this will deny any binding to the private extensions by default, if the compositor is not built with SMACK support. Defines a potential lists of applications permitted to create/display/activate surfaces/applications. Bug-AGL: SPEC-3413 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I2dbd3b3ef0d519fde7952f97e0303ff2b151aaa0
2020-06-26policy-default: Use libsmack to check client labelMarius Vlad2-0/+54
Use the client file descriptor to find out the SMACK label of that client. Enforces homescreen to bind to agl_shell and launcher and alexa-viewer to bind to the agl-shell-desktop interface. Allows access to agl_shell_desktop to tbtnavi and hvac as those contain example code on use it for moving it to other outputs. Bug-AGL: SPEC-3396 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I1a1abf2d2786624ffa484b6577de17f5010d5ac6
2020-06-26policy: Add a new policy hook to restrict access to private extensionsMarius Vlad3-1/+33
In this manner we can control which clients can bind to which interface (either the agl_shell one or the agl_shell_desktop one). Bug-AGL: SPEC-3394 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I9da4b3596dc5980b325aada8f8fcc7a11431c755
2020-06-24desktop: Avoid referencing the output's surface for pending surfacesMarius Vlad1-0/+7
Pending surfaces will only get a valid role when the client shell sends out ready() request to start presenting. Corner-case would be that pending surface is destroyed, moment in which we realise we never set-up an output. This is corner-case and treat as is. Bug-AGL: SPEC-3448 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I2eb9c937878fb6af56f3fbcf0d5da10a8003f634
2020-06-16doc: Added arch diagramMarius Vlad3-0/+1762
Bug-AGL: SPEC-3386 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: If98632458b11f3fce0843fbf44e34d04bc1320cf
2020-06-16README: move README.md to doc/Marius Vlad1-0/+0
Bug-AGL: SPEC-3386 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: If1acb6f0c4cfb9cdfa16e9fb8b57b29a1a596459
2020-06-15layout: Clip the view to the size specified by width and heightMarius Vlad1-9/+9
This uses the bx and by as origin for the bounding box if those were passed on. The compositor will set up a mask clip for the window if the both width and height are positive. This also removes the geometry of the surface and passes the x and y values directly. Bug-AGL: SPEC-3419 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I174f1ccbffad3c99e74fbb5ee90888b4ad879230
2020-06-15shell: Pass the bounding box values to the pop-up surfaceMarius Vlad2-5/+26
Necessary in order to make use options passed in with the protocol. Bug-AGL: SPEC-3419 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I0a2b973526572db18349642782082906544830a9
2020-06-15agl-shell-desktop: Add the ability to pass width and height asMarius Vlad1-3/+29
area of the bounding box The width and height will represent a rectangle which can be used to define the maxium area to have the surface in. Any part of the surface area that exceeds the area delimited by this bounding box will be clipped away. The initial position of the bounding box is specified using the bx and by values. Bug-AGL: SPEC-3419 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ie24f469662dd686c49f658c415ccd2664d9a9b5b
2020-06-15shell: Advertise application_id event for other surface rolesMarius Vlad1-7/+21
application_id event is sent just when a client binds to the agl_desktop_shell interface and when new desktop role surface were created, skipping split, fullscreen and pop-up kind of surface. This patch sends the application_id event for those as well. Makes SPEC-3412 much easier to determine when the application itself was started. Bug-AGL: SPEC-3412 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ic5c0ebf130fda45c5fda89e0e27e81dea96195cd
2020-06-15layout: Do not attempt to activate the surface on the remote outputMarius Vlad1-0/+10
Once the view has been placed on remote output do not attempt to activate it on other output, as it would make quite confusing to have same view on multiple outputs. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I36a8df18a174e3d5fd5f49ff5bdf70f1a16c86cb
2020-06-15src: Mark surfaces with the 'remote' role if configuration file says soMarius Vlad5-4/+18
As we don't have an explicit way to do it, like we have with the protocol, we try to determine if the surface was being assigned a remote output and use that, when the surface is created. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Idd95acd9ae69c5ac37b50d447956b0ee46a94677
2020-06-15main: Do the installment of black surfaces for remote outputs as wellMarius Vlad1-2/+2
The change to enable the remote outputs later than local ones, means we need to make sure we still have a black surface installed for the remoting output. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I3af4ee802eab377adf9c368a800b04ba13ead8af
2020-06-15shell: Add some extra checks to make sure we don't trip ourselvesMarius Vlad1-2/+18
Dynamically removing and inserting surfaces on outputs requires making sure the surface is still mapped on that output. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I125f9788718655ee88fa389fb14bd2c36342f8fe
2020-06-15main: Enable remote outputs later than local (DRM) outputsMarius Vlad1-20/+29
Will allow the client shell to receive, and to use as primary output, the local outputs first, without the need to (pre-)configure the client shell or the launcher. Makes integration much easier and will retain the same functionality we had with weston. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ib8ac80074ea515487ffe79b0801f5bfd069e9ff7
2020-06-15main, layout: Minor clean-ups and added some further loggingMarius Vlad2-30/+14
Identifies the output being used, and removes the need to have the macro set. At the moment purely informative, but might be needed in case of debugging. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I7bdb49e7f97ce49afb035ee7b089094fc4aad3a2
2020-06-15main: Retrieve the agl-shell-app-id from the config fileMarius Vlad1-0/+1
Just like local outputs, use the agl-shell-app-id specified in the 'remote-output' section to assign that output to the specific application id. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I43ba74889b8ea529ab9ec0ebdf8a8dd56762cc40
2020-06-15main: Retrieve the transform and scale from config fileMarius Vlad1-3/+12
We were missing retrieving the scale and transform for the remote-output. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I0842f62487a665d02e0cf9c005755a6260fad180
2020-06-15src: Create an ivi_output for the remote outputMarius Vlad1-14/+51
Ensures that we can retrieve the ivi_output from a weston_output using its destroy listener. Necessary for setting and retrieving the wl_output when activating/moving surfaces to that 'remote' output. Bug-AGl: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I1457c27c90826f4c71e64820c3d359566445eb5e
2020-06-15src: Hold a reference for remoting_api in the ivi_compositorMarius Vlad2-6/+9
This will be necesary a bit in the future, to ensure that we can't later on enable the remote output so we need access to the api. Bug-AGl: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ica13548c852efb7ae4cabade634a6629ed6fe215
2020-06-15main: Add the ability to load the remote pluginMarius Vlad3-0/+250
Streaming to 'remote' outputs needs the remote-plugin library. We build it automatically if we determine that the gst dependencies are satisfied, otherwise we're using a stub version for it. Unfortunatelly, upstream doesn't provide necessary header for the remoting.h so we copy-paste directly. Will follow up with upstream to provide headers for the plugins. Bug-AGl: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ide277b402c511ed075fa1c5aaaf7770b50359c35
2020-06-15desktop: Remove commiting code for the panelMarius Vlad3-73/+1
We no longer use older qtwayland version so there's no need to keep in place anymore. Bug-AGl: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Icad3d208ea96739b780dfef5911e855a7a39af6a
2020-06-15shell: Do not remove the black surface if we don't have a backgroundMarius Vlad1-1/+2
set for that output Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I07ca7108e37dcdb992de0e2223bde3f9fa200863
2020-06-15desktop: Display a black surface for apps being moved using config fileMarius Vlad1-3/+9
Just like the 'remote' surface roles, put back a black surface if there's no background set and if it is the last surface on that output. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I7bd7ae55fc668753223a23462b697071faa16525
2020-06-15layout: Remove black surface when trying to use migrate views to otherMarius Vlad1-0/+7
outputs We install a black surface in the fullscreen layer for each output, and we need to remove it before adding the new surfaces/views. We did that aleady for 'remote' type of surfaces when categorizing the type, but here we use the configuration file to determine the output, but we were missing the black surface for that output. This verifies that the black surface for that output is in use, and removes the black surface if so. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I3c4ae90ee0983bc424c932715d9a1ff082117bef
2020-06-15src/: Use agl-shell-app-id to set-up views on a different outputMarius Vlad3-9/+46
This makes it easier to specify the application directly in the configuration file, without the ned to modify the application code. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ic38ca0aaf05ce8f1c4993341c9d767acfd25eb43
2020-06-15layout: Add a wrapper to print out the surface roleMarius Vlad3-4/+57
With this we add a few more debug statements to the log file. Nothing too spurious but helps debugging more quickly if needed. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: If345903428cbb9c895e22980fdf64aec3c03d3b7
2020-06-14src: Insert a black surface/remove it when the last remoteMarius Vlad3-5/+40
surface role is present Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ia47c0539ff26d1378bb9ac75e19592d7b8b2b3bf
2020-06-14layout, desktop: Treat the remote surface role like the desktop oneMarius Vlad2-7/+55
Necessary changes so that we can handle the remote surface just like the regular desktop one. We use the same code when committing the surface but modify the completion part to only modify the pending output as to avoid remote surfaces interfering with the enum representing each surface type. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ied770c8fd8cd7021a7efb5cf07bc44ab2cf93cce
2020-06-14layout: Remove the quirks as now we have the policy hooks in placeMarius Vlad3-25/+2
to handle that With the policy hooks in place we no longer need this quirk to activate surfaces by default when starting up, and was potentially seen as hole to bypass the policy hooks. Remove it and just allow the policy hook to control how that happens. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I4c28648f0805e5c593c082c644d2e126b1d9df6b
2020-06-14src/: Add the remote surface roleMarius Vlad4-0/+87
This patch adds the 'remote' surface role, which clients can make use of to hint the compositor that it should place the surface on other output. While both private extension protocols (agl-shell and agl-shell-desktop) explicitly require a wl_output when activating or when setting surface roles, we still need the inform the compositor that the surface should be placed on another output. This is due to the activate_by_default functionality that requires having an output being present, with the default regular XDG desktop role deriving its output by using the output of the backgound surface (which is being normally set by the client shell). Just like pop-up dialog role and split surface role this patch adds another temporary hold up place before the surface is actually created. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ic67246ecc183826ae59b2c99a671885d61040249
2020-06-08src/: Add all surface roles to a wrapper for retrieving the outputMarius Vlad3-15/+18
Adds the other surface roles to the it. Bug-AGL: SPEC-3280 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ia0c659bfd0dbf96d53ee6f24d3c4296b3ffdad2d
2020-06-08layout: Do not attempt to activate a split or a fs surfaceMarius Vlad1-2/+23
As long as there is (an already created) surface in a split/fs type of role there's no point in trying to activate it. Users can mistakenly try to do that so have some logic in place to avoid it. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Id9b8e039b6d53fbfb4e310166a91c2cb6a45cb4e
2020-06-08layout: Resize the active surface when doing the splitMarius Vlad3-6/+71
This adds an intermediate geometry variable which is used to save and restore to the original available geometry when destroying the split surface. This takes care to inform the client that a new resize is needed when the split surface is destroyed or when the split surface is committed. The width and height of the split surface is derived from the available geometry area size (the available size of the background surface) but this can further adapted to be based on the split window size (that is, it could be specified by the client). This assumption is there to simplify the implementation. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ia484a922a7cbd314db2c878f81cb548458d1c1cd
2020-06-08layout: Allow to commit the fullscreen and split surface rolesMarius Vlad4-1/+119
Now that we have the ability to discern between fullscreend and split roles, use specific functions when doing the commit to further customize them. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Idf4ed55533c46925638a466e9713465d710b6845
2020-06-08layout: Remove unused ivi_compositor referenceMarius Vlad1-1/+0
Removes a unused warning about ivi_compositor. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I40dbbdfe6036f7aa7d9c38638c1fc79e13681765
2020-06-08shell: Determine the role typeMarius Vlad1-8/+4
Now that we have the ability to determine the role type between pop-up diaglos, full-screen, or split ones use the wrappers installed previously to make use of them. Keep the same functionality by activating the desktop surface if we determine we have one. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ibce3bc040ce3683ab41709d68d5fbf90d90ea539
2020-06-08shell: Introduce fullscreen and split role type of a surfaceMarius Vlad5-13/+206
With it, this also adds two pending lists, for each role type and aggregates the checks used to compare against the roles type when the surface is being created. There's no functional at this stage. Bug-AGL: SPEC-3334 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I1900399fe35d9dbc26a93c374ac2f86efa860ba6
2020-06-08desktop: Missing assert includeMarius Vlad1-0/+1
Commit a2f9566bdbfcb8ee added an assert but failed to include the proper header causing an warning and a failure when building locally. Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I5bd0754f0a8dee74e9d5b09d34d80633cb96e666
2020-06-08desktop: Handle correctly panel and bg removal of agl-shell unbindMarius Vlad2-15/+23
We don't need to free the ivi_surface when un-binding the agl-shell, as that should happen when `desktop_surface_removed()` is called. We'll just invalidate them depending on the role so that next time we're going to able to bind again. Bug-AGL: SPEC-3404 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I6e06b6a1029989bf3e09156b602b6eab6addc5da
2020-06-03README.md: Add documentation details about agl-shell and agl-shell-desktopMarius Vlad1-9/+169
This adds a few words about: - overall architecture and design - protocol extension, agl-shell and agl-shell-desktop - add inline code backticks for missing function names in policy API Bug-AGL: SPEC-3386 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I96f2b08d80ec10dda4e080a772bd2f2456535631
2020-05-12main: Convert to using the logging/debuggging fraemworkMarius Vlad1-25/+51
With this in place we're now using the new logging framework. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I5782b9a9fa825351c630af39bf7542d4bfa14efa
2020-05-12main: Add a (valid) return code when exitingMarius Vlad1-1/+6
Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Id466a9d5bc253e5c65f7f2db328b6ea794457726
2020-05-12main: We don't have weston-debug extension availableMarius Vlad1-2/+0
Copy-pasta mistake, as we don't really have the weston-debug extension added. Bug-AGL: SPEC-3352 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I56c36f4d5af830ba5a869a80f73f7f9df3d2e106