diff options
| author |   José Bollo <jose.bollo@iot.bzh> | 2017-01-05 15:23:35 +0100 |
|---|---|---|
| committer | José Bollo <jose.bollo@iot.bzh> | 2017-01-05 15:23:35 +0100 |
| commit | b8bcf15d19e77a6b255c11e8d95fa655a3f7c3eb (patch) | |
| tree | 20e0a6f61f0688aad8b52694bd4c50260808999c | |
| parent | 84e049cf2312286ad1895cbebc82cabd5c30b9bb (diff) | |
Improves logging
Adds error message for errors related to HTTP.
Change-Id: I5a3069528f8e9a7fe9a8dae6c201a783948a565a
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
| -rw-r--r-- | src/afb-hsrv.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/afb-hsrv.c b/src/afb-hsrv.c index 6bc8ffa3..91dff296 100644 --- a/src/afb-hsrv.c +++ b/src/afb-hsrv.c @@ -118,6 +118,7 @@ static int access_handler( method = get_method(methodstr); method &= afb_method_get | afb_method_post; if (method == afb_method_none) { + WARNING("Unsupported HTTP operation %s", methodstr); reply_error(connection, MHD_HTTP_BAD_REQUEST); return MHD_YES; } @@ -125,6 +126,7 @@ static int access_handler( /* create the request */ hreq = calloc(1, sizeof *hreq); if (hreq == NULL) { + ERROR("Can't allocate 'hreq'"); reply_error(connection, MHD_HTTP_INTERNAL_SERVER_ERROR); return MHD_YES; } @@ -153,12 +155,15 @@ static int access_handler( hreq->method = afb_method_get; } else if (strcasestr(type, FORM_CONTENT) != NULL) { hreq->postform = MHD_create_post_processor (connection, 65500, postproc, hreq); - if (hreq->postform == NULL) + if (hreq->postform == NULL) { + ERROR("Can't create POST processor"); afb_hreq_reply_error(hreq, MHD_HTTP_INTERNAL_SERVER_ERROR); + } return MHD_YES; } else if (strcasestr(type, JSON_CONTENT) != NULL) { return MHD_YES; } else { + WARNING("Unsupported media type %s", type); afb_hreq_reply_error(hreq, MHD_HTTP_UNSUPPORTED_MEDIA_TYPE); return MHD_YES; } @@ -169,6 +174,7 @@ static int access_handler( if (*upload_data_size) { if (hreq->postform != NULL) { if (!MHD_post_process (hreq->postform, upload_data, *upload_data_size)) { + ERROR("error in POST processor"); afb_hreq_reply_error(hreq, MHD_HTTP_INTERNAL_SERVER_ERROR); return MHD_YES; } @@ -187,6 +193,7 @@ static int access_handler( rc = MHD_destroy_post_processor(hreq->postform); hreq->postform = NULL; if (rc == MHD_NO) { + ERROR("error detected in POST processing"); afb_hreq_reply_error(hreq, MHD_HTTP_BAD_REQUEST); return MHD_YES; } @@ -219,6 +226,7 @@ static int access_handler( } /* no handler */ + WARNING("Unhandled request to %s", hreq->url); afb_hreq_reply_error(hreq, MHD_HTTP_NOT_FOUND); return MHD_YES; } |