diff options
| author |   Jose Bollo <jose.bollo@iot.bzh> | 2019-01-04 14:30:04 +0100 |
|---|---|---|
| committer |   Loïc Collignon <loic.collignon@iot.bzh> | 2019-01-04 16:52:24 +0100 |
| commit | 80c3e53bcb564d6eda86bbc014f3d67001884de0 (patch) | |
| tree | 3123b49482cc9a9b950353c5c7956e1944b3285d | |
| parent | 1defe4ce2cedff5c34581b04a48e12c581af9dbb (diff) | |
afb-api-v3: Fix potential buffer overflow
Change-Id: I170e127ebf96d2accfdd6d6a4ec322afeaa2782f
Signed-off-by: Jose Bollo <jose.bollo@iot.bzh>
| -rw-r--r-- | src/afb-api-v3.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/afb-api-v3.c b/src/afb-api-v3.c index 660fac11..1fc6ebe4 100644 --- a/src/afb-api-v3.c +++ b/src/afb-api-v3.c @@ -158,21 +158,22 @@ struct json_object *afb_api_v3_make_description_openAPIv3(struct afb_api_v3 *api json_object_object_add(i, "version", json_object_new_string("0.0.0")); json_object_object_add(i, "description", json_object_new_string(api->info)); + buffer[0] = '/'; + buffer[sizeof buffer - 1] = 0; + p = json_object_new_object(); json_object_object_add(r, "paths", p); iter = api->verbs; end = iter + api->count; while (iter != end) { verb = *iter++; - buffer[0] = '/'; - strncpy(buffer + 1, verb->verb, sizeof buffer - 1); + strncpy(buffer + 1, verb->verb, sizeof buffer - 2); json_object_object_add(p, buffer, describe_verb_v3(verb)); } verb = api->verbsv3; if (verb) while(verb->verb) { - buffer[0] = '/'; - strncpy(buffer + 1, verb->verb, sizeof buffer - 1); + strncpy(buffer + 1, verb->verb, sizeof buffer - 2); json_object_object_add(p, buffer, describe_verb_v3(verb)); verb++; } |