aboutsummaryrefslogtreecommitdiffstats
path: root/src/afb-api-ws.c
diff options
context:
space:
mode:
authorJosé Bollo <jose.bollo@iot.bzh>2018-07-31 19:02:18 +0200
committerJosé Bollo <jose.bollo@iot.bzh>2018-08-02 15:49:43 +0200
commit10aa15afc5bc7321d0049823dd173dda11ff3724 (patch)
tree9d801d6c2336f8e98bf42c0a622b1b510b9429ea /src/afb-api-ws.c
parentdf67c029363f6d42a3e91cd62774c74b3ef66670 (diff)
afb-socket: Separate socket creation
The objective is to have a well identified and possibly reusable internally. Change-Id: Icdb6ce7d85ae26373cfe4f0b492fe97b74ed747c Signed-off-by: José Bollo <jose.bollo@iot.bzh>
Diffstat (limited to 'src/afb-api-ws.c')
-rw-r--r--src/afb-api-ws.c192
1 files changed, 29 insertions, 163 deletions
diff --git a/src/afb-api-ws.c b/src/afb-api-ws.c
index 4f4ac72a..24ffefef 100644
--- a/src/afb-api-ws.c
+++ b/src/afb-api-ws.c
@@ -29,18 +29,18 @@
#include <sys/socket.h>
#include <sys/un.h>
-#include "afb-fdev.h"
-#include "afb-systemd.h"
#include "afb-api.h"
#include "afb-apiset.h"
#include "afb-api-ws.h"
+#include "afb-fdev.h"
+#include "afb-socket.h"
#include "afb-stub-ws.h"
#include "verbose.h"
#include "fdev.h"
struct api_ws
{
- char *path; /* path of the object for the API */
+ char *uri; /* uri of the object for the API */
char *api; /* api name of the interface */
struct fdev *fdev; /* fdev handler */
struct afb_apiset *apiset;
@@ -49,29 +49,29 @@ struct api_ws
/******************************************************************************/
/*
- * create a structure api_ws not connected to the 'path'.
+ * create a structure api_ws not connected to the 'uri'.
*/
-static struct api_ws *api_ws_make(const char *path)
+static struct api_ws *api_ws_make(const char *uri)
{
struct api_ws *api;
size_t length;
/* allocates the structure */
- length = strlen(path);
+ length = strlen(uri);
api = calloc(1, sizeof *api + 1 + length);
if (api == NULL) {
errno = ENOMEM;
goto error;
}
- /* path is copied after the struct */
- api->path = (char*)(api+1);
- memcpy(api->path, path, length + 1);
+ /* uri is copied after the struct */
+ api->uri = (char*)(api+1);
+ memcpy(api->uri, uri, length + 1);
- /* api name is at the end of the path */
- while (length && path[length - 1] != '/' && path[length - 1] != ':')
+ /* api name is at the end of the uri */
+ while (length && uri[length - 1] != '/' && uri[length - 1] != ':')
length = length - 1;
- api->api = &api->path[length];
+ api->api = &api->uri[length];
if (api->api == NULL || !afb_api_is_valid_name(api->api)) {
errno = EINVAL;
goto error2;
@@ -85,162 +85,30 @@ error:
return NULL;
}
-static int api_ws_socket_unix(const char *path, int server)
-{
- int fd, rc;
- struct sockaddr_un addr;
- size_t length;
-
- length = strlen(path);
- if (length >= 108) {
- errno = ENAMETOOLONG;
- return -1;
- }
-
- if (server && path[0] != '@')
- unlink(path);
-
- fd = socket(AF_UNIX, SOCK_STREAM, 0);
- if (fd < 0)
- return fd;
-
- memset(&addr, 0, sizeof addr);
- addr.sun_family = AF_UNIX;
- strcpy(addr.sun_path, path);
- if (addr.sun_path[0] == '@')
- addr.sun_path[0] = 0; /* implement abstract sockets */
- if (server) {
- rc = bind(fd, (struct sockaddr *) &addr, (socklen_t)(sizeof addr));
- } else {
- rc = connect(fd, (struct sockaddr *) &addr, (socklen_t)(sizeof addr));
- }
- if (rc < 0) {
- close(fd);
- return rc;
- }
- return fd;
-}
-
-static int api_ws_socket_inet(const char *path, int server)
-{
- int rc, fd;
- const char *service, *host, *api;
- struct addrinfo hint, *rai, *iai;
-
- /* scan the uri */
- api = strrchr(path, '/');
- service = strrchr(path, ':');
- if (api == NULL || service == NULL || api < service) {
- errno = EINVAL;
- return -1;
- }
- host = strndupa(path, service++ - path);
- service = strndupa(service, api - service);
-
- /* get addr */
- memset(&hint, 0, sizeof hint);
- hint.ai_family = AF_INET;
- hint.ai_socktype = SOCK_STREAM;
- rc = getaddrinfo(host, service, &hint, &rai);
- if (rc != 0) {
- errno = EINVAL;
- return -1;
- }
-
- /* get the socket */
- iai = rai;
- while (iai != NULL) {
- fd = socket(iai->ai_family, iai->ai_socktype, iai->ai_protocol);
- if (fd >= 0) {
- if (server) {
- rc = bind(fd, iai->ai_addr, iai->ai_addrlen);
- } else {
- rc = connect(fd, iai->ai_addr, iai->ai_addrlen);
- }
- if (rc == 0) {
- freeaddrinfo(rai);
- return fd;
- }
- close(fd);
- }
- iai = iai->ai_next;
- }
- freeaddrinfo(rai);
- return -1;
-}
-
-static int api_ws_socket(const char *path, int server)
-{
- int fd, rc;
-
- /* check for systemd socket */
- if (0 == strncmp(path, "sd:", 3))
- fd = afb_systemd_fds_for(path + 3);
- else {
- /* check for unix socket */
- if (0 == strncmp(path, "unix:", 5))
- /* unix socket */
- fd = api_ws_socket_unix(path + 5, server);
- else
- /* inet socket */
- fd = api_ws_socket_inet(path, server);
-
- if (fd >= 0 && server) {
- rc = 1;
- setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &rc, sizeof rc);
- rc = listen(fd, 5);
- }
- }
- /* configure the socket */
- if (fd >= 0) {
- fcntl(fd, F_SETFD, FD_CLOEXEC);
- fcntl(fd, F_SETFL, O_NONBLOCK);
- }
- return fd;
-}
-
-static struct fdev *api_ws_socket_fdev(const char *path, int server)
-{
- int fd;
- struct fdev *fdev;
-
- fd = api_ws_socket(path, server);
- if (fd < 0)
- fdev = 0;
- else {
- fdev = afb_fdev_create(fd);
- if (!fdev)
- close(fd);
- }
- if (!fdev)
- ERROR("can't make %s socket for %s", server ? "server" : "client", path);
- return fdev;
-}
-
/**********************************************************************************/
-int afb_api_ws_add_client(const char *path, struct afb_apiset *declare_set, struct afb_apiset *call_set, int strong)
+int afb_api_ws_add_client(const char *uri, struct afb_apiset *declare_set, struct afb_apiset *call_set, int strong)
{
struct api_ws *apiws;
struct afb_stub_ws *stubws;
/* create the ws client api */
- apiws = api_ws_make(path);
+ apiws = api_ws_make(uri);
if (apiws == NULL)
goto error;
/* connect to the service */
- apiws->fdev = api_ws_socket_fdev(apiws->path, 0);
+ apiws->fdev = afb_socket_open(apiws->uri, 0);
if (!apiws->fdev)
goto error2;
stubws = afb_stub_ws_create_client(apiws->fdev, apiws->api, call_set);
if (!stubws) {
- ERROR("can't setup client ws service to %s", apiws->path);
+ ERROR("can't setup client ws service to %s", apiws->uri);
goto error3;
}
if (afb_stub_ws_client_add(stubws, declare_set) < 0) {
- ERROR("can't add the client to the apiset for service %s", apiws->path);
+ ERROR("can't add the client to the apiset for service %s", apiws->uri);
goto error3;
}
free(apiws);
@@ -253,14 +121,14 @@ error:
return -!!strong;
}
-int afb_api_ws_add_client_strong(const char *path, struct afb_apiset *declare_set, struct afb_apiset *call_set)
+int afb_api_ws_add_client_strong(const char *uri, struct afb_apiset *declare_set, struct afb_apiset *call_set)
{
- return afb_api_ws_add_client(path, declare_set, call_set, 1);
+ return afb_api_ws_add_client(uri, declare_set, call_set, 1);
}
-int afb_api_ws_add_client_weak(const char *path, struct afb_apiset *declare_set, struct afb_apiset *call_set)
+int afb_api_ws_add_client_weak(const char *uri, struct afb_apiset *declare_set, struct afb_apiset *call_set)
{
- return afb_api_ws_add_client(path, declare_set, call_set, 0);
+ return afb_api_ws_add_client(uri, declare_set, call_set, 0);
}
static int api_ws_server_accept_client(struct api_ws *apiws, struct fdev *fdev)
@@ -278,16 +146,16 @@ static void api_ws_server_accept(struct api_ws *apiws)
lenaddr = (socklen_t)sizeof addr;
fd = accept(fdev_fd(apiws->fdev), &addr, &lenaddr);
if (fd < 0) {
- ERROR("can't accept connection to %s: %m", apiws->path);
+ ERROR("can't accept connection to %s: %m", apiws->uri);
} else {
fdev = afb_fdev_create(fd);
if (!fdev) {
- ERROR("can't hold accepted connection to %s: %m", apiws->path);
+ ERROR("can't hold accepted connection to %s: %m", apiws->uri);
close(fd);
} else {
rc = api_ws_server_accept_client(apiws, fdev);
if (rc < 0)
- ERROR("can't serve accepted connection to %s: %m", apiws->path);
+ ERROR("can't serve accepted connection to %s: %m", apiws->uri);
}
}
}
@@ -316,9 +184,9 @@ static int api_ws_server_connect(struct api_ws *apiws)
api_ws_server_disconnect(apiws);
/* request the service object name */
- apiws->fdev = api_ws_socket_fdev(apiws->path, 1);
+ apiws->fdev = afb_socket_open(apiws->uri, 1);
if (!apiws->fdev)
- ERROR("can't create socket %s", apiws->path);
+ ERROR("can't create socket %s", apiws->uri);
else {
/* listen for service */
fdev_set_events(apiws->fdev, EPOLLIN);
@@ -329,19 +197,19 @@ static int api_ws_server_connect(struct api_ws *apiws)
}
/* create the service */
-int afb_api_ws_add_server(const char *path, struct afb_apiset *declare_set, struct afb_apiset *call_set)
+int afb_api_ws_add_server(const char *uri, struct afb_apiset *declare_set, struct afb_apiset *call_set)
{
int rc;
struct api_ws *apiws;
/* creates the ws api object */
- apiws = api_ws_make(path);
+ apiws = api_ws_make(uri);
if (apiws == NULL)
goto error;
/* check api name */
if (!afb_apiset_lookup(call_set, apiws->api, 1)) {
- ERROR("Can't provide ws-server for %s: API %s doesn't exist", path, apiws->api);
+ ERROR("Can't provide ws-server for %s: API %s doesn't exist", uri, apiws->api);
goto error2;
}
@@ -358,5 +226,3 @@ error2:
error:
return -1;
}
-
-