summaryrefslogtreecommitdiffstats
path: root/pbap/pbap.cpp
diff options
context:
space:
mode:
authorMatt Ranostay <matt.ranostay@konsulko.com>2018-09-12 10:56:00 -0700
committerMatt Ranostay <matt.ranostay@konsulko.com>2018-09-12 11:46:54 -0700
commit051bf8e79c99699704032b7b943459a30aae22c8 (patch)
treec3cc9d5c0349f2d568028c89ed3d560247939a19 /pbap/pbap.cpp
parentee58ffc1da71d296fdae869dbaaa74a1c4a6c664 (diff)
libqtappfw: remove deleteLater instances that aren't usedguppy_6.90.0guppy/6.90.06.90.0
Remove several deleteLater calls that should have been delete's. This should solve race conditions that an object calls deleteLater(), and leaves scope before the QT main loop is called. Outcome of the race condition is that sometimes the memory allocator reallocates it to another message and causes a crash. Bug-AGL: SPEC-1680 Change-Id: Ic83d8c6c204c6e3248bbe9a9def1842e1e384b2b Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Diffstat (limited to 'pbap/pbap.cpp')
-rw-r--r--pbap/pbap.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/pbap/pbap.cpp b/pbap/pbap.cpp
index 98c05b5..71dc7cb 100644
--- a/pbap/pbap.cpp
+++ b/pbap/pbap.cpp
@@ -108,7 +108,7 @@ void Pbap::refreshContacts(int max_entries)
tmsg->createRequest("contacts", parameter);
m_mloop->sendMessage(tmsg);
- tmsg->deleteLater();
+ delete tmsg;
}
void Pbap::refreshCalls(int max_entries)
@@ -122,7 +122,7 @@ void Pbap::refreshCalls(int max_entries)
tmsg->createRequest("history", parameter);
m_mloop->sendMessage(tmsg);
- tmsg->deleteLater();
+ delete tmsg;
}
void Pbap::search(QString number)
@@ -136,7 +136,7 @@ void Pbap::search(QString number)
tmsg->createRequest("search", parameter);
m_mloop->sendMessage(tmsg);
- tmsg->deleteLater();
+ delete tmsg;
}
bool compareContactPtr(QObject *a, QObject *b)
@@ -269,7 +269,7 @@ void Pbap::onConnected()
parameter.insert("value", eventIterator.next());
tmsg->createRequest("subscribe", parameter);
m_mloop->sendMessage(tmsg);
- tmsg->deleteLater();
+ delete tmsg;
}
}
@@ -284,7 +284,7 @@ void Pbap::onDisconnected()
parameter.insert("value", eventIterator.next());
tmsg->createRequest("unsubscribe", parameter);
m_mloop->sendMessage(tmsg);
- tmsg->deleteLater();
+ delete tmsg;
}
}