diff options
author | Matt Ranostay <matt.ranostay@konsulko.com> | 2018-09-12 10:56:00 -0700 |
---|---|---|
committer | Matt Ranostay <matt.ranostay@konsulko.com> | 2018-09-12 19:06:08 +0000 |
commit | fc112fb9066e26e5481b3a434ac9be614f97367a (patch) | |
tree | 0e3a2e26d244a7decba586e68bb154e68298f1d6 /pbap | |
parent | cc65b62a4625188c8aab3406dd50d71c16722a3a (diff) |
libqtappfw: remove deleteLater instances that aren't usedflounder_6.0.2flounder_6.0.1flounder_6.0.0flounder_5.99.7flounder/6.0.2flounder/6.0.1flounder/6.0.0flounder/5.99.76.0.26.0.16.0.05.99.7
Remove several deleteLater calls that should have been delete's.
This should solve race conditions that an object calls deleteLater(), and leaves
scope before the QT main loop is called.
Outcome of the race condition is that sometimes the memory allocator reallocates it
to another message and causes a crash.
Bug-AGL: SPEC-1680
Change-Id: Ic83d8c6c204c6e3248bbe9a9def1842e1e384b2b
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
(cherry picked from commit 051bf8e79c99699704032b7b943459a30aae22c8)
Diffstat (limited to 'pbap')
-rw-r--r-- | pbap/pbap.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/pbap/pbap.cpp b/pbap/pbap.cpp index 98c05b5..71dc7cb 100644 --- a/pbap/pbap.cpp +++ b/pbap/pbap.cpp @@ -108,7 +108,7 @@ void Pbap::refreshContacts(int max_entries) tmsg->createRequest("contacts", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } void Pbap::refreshCalls(int max_entries) @@ -122,7 +122,7 @@ void Pbap::refreshCalls(int max_entries) tmsg->createRequest("history", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } void Pbap::search(QString number) @@ -136,7 +136,7 @@ void Pbap::search(QString number) tmsg->createRequest("search", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } bool compareContactPtr(QObject *a, QObject *b) @@ -269,7 +269,7 @@ void Pbap::onConnected() parameter.insert("value", eventIterator.next()); tmsg->createRequest("subscribe", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } } @@ -284,7 +284,7 @@ void Pbap::onDisconnected() parameter.insert("value", eventIterator.next()); tmsg->createRequest("unsubscribe", parameter); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } } |