diff options
| author |   Matt Ranostay <matt.ranostay@konsulko.com> | 2018-09-12 10:56:00 -0700 |
|---|---|---|
| committer | Matt Ranostay <matt.ranostay@konsulko.com> | 2018-09-12 11:46:54 -0700 |
| commit | 051bf8e79c99699704032b7b943459a30aae22c8 (patch) | |
| tree | c3cc9d5c0349f2d568028c89ed3d560247939a19 /telephony | |
| parent | ee58ffc1da71d296fdae869dbaaa74a1c4a6c664 (diff) | |
libqtappfw: remove deleteLater instances that aren't usedguppy_6.90.0guppy/6.90.06.90.0
Remove several deleteLater calls that should have been delete's.
This should solve race conditions that an object calls deleteLater(), and leaves
scope before the QT main loop is called.
Outcome of the race condition is that sometimes the memory allocator reallocates it
to another message and causes a crash.
Bug-AGL: SPEC-1680
Change-Id: Ic83d8c6c204c6e3248bbe9a9def1842e1e384b2b
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Diffstat (limited to 'telephony')
| -rw-r--r-- | telephony/telephony.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/telephony/telephony.cpp b/telephony/telephony.cpp index 7f6a571..08b80b1 100644 --- a/telephony/telephony.cpp +++ b/telephony/telephony.cpp @@ -41,7 +41,7 @@ void Telephony::dial(QString number) TelephonyMessage *tmsg = new TelephonyMessage(); tmsg->createRequest("dial", number); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } void Telephony::answer() @@ -49,7 +49,7 @@ void Telephony::answer() TelephonyMessage *tmsg = new TelephonyMessage(); tmsg->createRequest("answer"); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } void Telephony::hangup() @@ -57,7 +57,7 @@ void Telephony::hangup() TelephonyMessage *tmsg = new TelephonyMessage(); tmsg->createRequest("hangup"); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } void Telephony::onConnected() @@ -74,7 +74,7 @@ void Telephony::onConnected() tmsg = new TelephonyMessage(); tmsg->createRequest("subscribe", eventIterator.next()); m_mloop->sendMessage(tmsg); - tmsg->deleteLater(); + delete tmsg; } setConnected(true); |