voice: remove vshl-capabilities dependencies

Various fixes for voice component:

- fix incorrect check on vap (voice agent profile) pointers;
- remove dependencies on vshl-capabilities: this module will
communicate via vshl-core api;
- remove dependencis on alexa-voiceagent;
- use a more generic name for cbl related operations. CBL
in this environment is understood as code based
login (for voice agent authorization via user login to a cloud
service), however, in the case of alexa it is known as  code
based linking;
- add check for voice_xxx_event eventdata which in ocasions
is an empty object, i.e., the payload is missing.

Bug-AGL: SPEC-2981
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Icaab7a21bedb3e2696d541567162ec46b047a305

1 files changed, 5 insertions, 4 deletions

diff --git a/voice/voice.h b/voice/voice.h
index 1da7ca6..be3d15d 100644
--- a/voice/voice.h
+++ b/voice/voice.h
@@ -37,8 +37,9 @@ class Voice : public QObject
 			       QObject * parent = Q_NULLPTR);
 		virtual ~Voice();
 
-		// controls
+		//enumerate agents:
 		Q_INVOKABLE void scan();
+		//obtain code based login params:
 		Q_INVOKABLE void getCBLpair(QString id);
 
 	private:
@@ -47,10 +48,10 @@ class Voice : public QObject
 
 		void subscribeAgentToVshlEvents(QString id);
 		void unsubscribeAgentFromVshlEvents(QString id);
-		void subscribeAgentToCblEvents(QString id);
+		void subscribeAgentToLoginEvents(QString id);
 		void parseAgentsList(QJsonArray agents);
 		void processVshlEvent(VoiceMessage *vmsg);
-		void processCblEvent(VoiceMessage *vmsg);
+		void processLoginEvent(VoiceMessage *vmsg);
 
 		void processEvent(VoiceMessage *vmsg);
 		void processReply(ResponseMessage *rmsg);
@@ -65,7 +66,7 @@ class Voice : public QObject
 			"voice_dialogstate_event",
 			"voice_connectionstate_event",
 		};
-		const QStringList cbl_events {
+		const QStringList login_events {
 			"voice_cbl_codepair_received_event",
 			"voice_cbl_codepair_expired_event",
 		};