summaryrefslogtreecommitdiffstats
path: root/weather/weather.cpp
diff options
context:
space:
mode:
authorRaquel Medina <raquel.medina@konsulko.com>2020-03-18 23:56:31 +0100
committerRaquel Medina <raquel.medina@konsulko.com>2020-03-23 14:02:28 +0100
commit0ed292d3ccf93c889734960676a321d1166d3f66 (patch)
treeb8d64d1685d2f4bf599ab3867a0d3ff557ff0479 /weather/weather.cpp
parent5c750385d02116a92fa4c120ccc26abb8267bc97 (diff)
rework message hierarchy
Rework message hierarchy with the final objective of splitting libqtappfw into several libraries. This commit carries the following changes: - Simplify message hierarchy, keeping abstract Message class, adding specialization for call and event messages, keeping ResponseMessage, and removing all module specific specializations. - Add MessageFactory class to create message objects. - Change messages life cycle: using smart pointers and removing QObject from message hierarchy (a Message is not a QObject anymore and thus 'deleteLater()' is not available). - Adapt all modules to use new message hierarchy. - Keep ResponseMessage original constructor to avoid breaking TaskManager. - Message constructors have been kept public, but will go private on a follow-up patch (once TaskManager class has been modified to use new MessageFactory). Bug-AGL: SPEC-3112 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com> Change-Id: I3a7a6325209ddeca2293f1ac745371861a947bfb
Diffstat (limited to 'weather/weather.cpp')
-rw-r--r--weather/weather.cpp46
1 files changed, 28 insertions, 18 deletions
diff --git a/weather/weather.cpp b/weather/weather.cpp
index d4992d4..298f32c 100644
--- a/weather/weather.cpp
+++ b/weather/weather.cpp
@@ -17,8 +17,9 @@
#include <QDebug>
#include <QJsonArray>
-#include "message.h"
-#include "weathermessage.h"
+#include "callmessage.h"
+#include "eventmessage.h"
+#include "messagefactory.h"
#include "messageengine.h"
#include "weather.h"
@@ -40,32 +41,41 @@ Weather::~Weather()
void Weather::onConnected()
{
- WeatherMessage *tmsg = new WeatherMessage();
- tmsg->createRequest("subscribe", "weather");
- m_mloop->sendMessage(tmsg);
- delete tmsg;
+ std::unique_ptr<Message> msg = MessageFactory::getInstance().createOutboundMessage(MessageId::Call);
+ if (!msg)
+ return;
+
+ CallMessage *tmsg = static_cast<CallMessage*>(msg.get());
+ tmsg->createRequest("weather", "subscribe", "weather");
+ m_mloop->sendMessage(std::move(msg));
}
void Weather::onDisconnected()
{
- WeatherMessage *tmsg = new WeatherMessage();
- tmsg->createRequest("unsubscribe", "weather");
- m_mloop->sendMessage(tmsg);
- delete tmsg;
+ std::unique_ptr<Message> msg = MessageFactory::getInstance().createOutboundMessage(MessageId::Call);
+ if (!msg)
+ return;
+
+ CallMessage *tmsg = static_cast<CallMessage*>(msg.get());
+ tmsg->createRequest("weater", "unsubscribe", "weather");
+ m_mloop->sendMessage(std::move(msg));
}
-void Weather::onMessageReceived(MessageType type, Message *message)
+void Weather::onMessageReceived(std::shared_ptr<Message> msg)
{
- if (type == MessageType::WeatherEventMessage) {
- WeatherMessage *tmsg = qobject_cast<WeatherMessage*>(message);
+ if (!msg)
+ return;
+
+ if (msg->isEvent()) {
+ std::shared_ptr<EventMessage> emsg = std::static_pointer_cast<EventMessage>(msg);
+ if (emsg->eventApi() != "weather")
+ return;
- if (tmsg->isEvent()) {
- m_temperature = tmsg->temperature();
- m_condition = tmsg->condition();
+ QJsonObject data = emsg->eventData();
+ m_temperature = QString::number(data.value("main").toObject().value("temp").toDouble());
+ m_condition = data.value("weather").toArray().at(0).toObject().value("description").toString();
emit temperatureChanged(m_temperature);
emit conditionChanged(m_condition);
}
- }
- message->deleteLater();
}