Age | Commit message (Collapse) | Author | Files | Lines |
|
std::hash specializations for some Qt types
are in Qt 5.14, so we dont need the custom
specialization for QString in utils.h.
Note that if this code was to be merged to
previous agl versions with pre 5.14 Qt
version, the custom specialization for
std::hash<QString> would be needed.
Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I81240f4e804ff6c1046a50c486f39eec74edc057
|
|
Share MessageEngine instance among clients in the
same process using a common socket (same url).
- add MessageEngineFactory class;
- extend std::unordered_map<> to use QString as
key;
- use std::shared_ptr<MessageEngine> to share
ownership among MessageEngineFactory and the
engine clients;
- force MessagEngine parent object null to avoid
life cycle dependency on a parent;
- protect insertions & deletions in m_calls map;
Also, not directly related but as part of testing
these changes: cleanup on voice to remove
superflous model sorting (there's just one voice
model for alexa voice agent).
Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Ie2304453dc37723dac13d256286eeb85f84ca2ab
|
|
Needed to trigger onRenderTemplate signal for alexa-viewer.
Bug-AGL: SPEC-3340
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
Change-Id: Ie9ada82af7def4989d1aec94eb5eb3144780f583
|
|
Bug-AGL: SPEC-3339
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Idd496b868764c17f550d15174ff8d702f18bf2d9
|
|
Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I044a406eb2309d4ae0547969cb2bf33b398ba2ae
|
|
Remove extra semicolon which results in received
messages being discarded.
Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I217248f59c7c8e3a5cb5b02e3d068caf36a5bbfa
|
|
Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Ice9f57422b5607e93c07c2f11dc57626e601c463
|
|
Register std::shared_ptr<Message> with QMetaType
to allow for queued signal/slot connections across
threads.
This change is required for the library split
where MessageEngine (signal source) will be part
of a core library while the clients (slots) will
be spread in different library binaries.
TaskManager also requires this change, as it is
already implemented in terms of a queued signal/slot
connection across threads.
Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I0f412e524c7321d35136860ae0d82c022f1c0d3f
|
|
The original message hierarchy rework patch
is missing functionality which results in received
replies being discarded.
Basically, ResponseMessage class is
missing the override required to match replies to
the original calls.
Bug-AGL: SPEC-3112
Fixes: 0ed292d3ccf9 (rework Message hierarchy)
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I39030ef212b2175a590deca02f9f9ff41bf7abf4
|
|
Rework message hierarchy with the final objective
of splitting libqtappfw into several libraries.
This commit carries the following changes:
- Simplify message hierarchy, keeping abstract
Message class, adding specialization for call and
event messages, keeping ResponseMessage, and
removing all module specific specializations.
- Add MessageFactory class to create message
objects.
- Change messages life cycle: using smart pointers
and removing QObject from message hierarchy (a
Message is not a QObject anymore and thus
'deleteLater()' is not available).
- Adapt all modules to use new message hierarchy.
- Keep ResponseMessage original constructor to
avoid breaking TaskManager.
- Message constructors have been kept public, but
will go private on a follow-up patch (once
TaskManager class has been modified to use new
MessageFactory).
Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I3a7a6325209ddeca2293f1ac745371861a947bfb
|
|
- Remove unneeded dependencies from libqtappfw public
headers, specifically MessageEngine and Message
hierarchy header files, in preparation for refactoring
work on these areas.
This change helps shield client apps from the
upcoming changes in the library, and highlight the
separation between the library's core and the various
modules providing public interfaces to those apps.
- Make MessageType an scoped enum to fwd declare it.
- Update Copyright statement on files updated by
this patch.
Bug-AGL: SPEC-3112
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I12fd9cdc034aa1166f6448c07befadd9d2042b05
|
|
To remove QML handling of websockets this patchset is required
to move it to libqtappfw access.
Bug-AGL: SPEC-2984
Change-Id: Ieef6174d2ae7adec2fcaadf44fcb22cf86c7138d
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Add support for subscribing to and using the guimetadata events from
the vshl-capabilities binding. A GuiMetadata class is used to wrap
things as it is likely that users of the other voice capabilities
would not overlap if e.g. navigation event support is later added.
At the moment, only the BodyTemplate1, BodyTemplate2, and
WeatherTemplate guimetadata types are handled, and there is room for
significant improvement in the Qt model exposed, which is somewhat
crude with respect to image URL handling. As well, the weather
template handling does not expose the full forecast, a full
implementation of that would require adding an actual model that
maps to a list view rather than a simple QObject.
Bug-AGL: SPEC-3110
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I33fc2440ebdc2a4a2de79ff0a49acbc422c47da2
|
|
Now that the broken event argument JSON from the vshl-core binding has
a fix, the workaround of selectively reparsing the voice event arguments
needs to be removed, as it breaks with the corrected events.
Bug-AGL: SPEC-3084
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Ie158ae326a3dc9c7cf4b08dbdbc729f5587e3758
(cherry picked from commit 77392aeda562e3bbb4f311a99469156cb1a66d75)
|
|
|
|
Initialize the min/max frequency to zero so they don't show random
values before the binding provides the real limits.
Bug-AGL: SPEC-3041
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I900be56eb5f123e16cf9f25e0c9cfe9a9d6466eb
|
|
Add the vendor name to the voiceagent model to allow using it
applications, and fixed a typo and a couple of possible state name
omissions.
Bug-AGL: SPEC-2981
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I65a59ec17d0e003bc114fa85d120ee773fee0f1a
|
|
commit 21bba7d, introduced extra parsing ops
to process voice_xxxx_event payloads, which
carry extra whitespaces and eol chars; however
that change introduced a regression for other
events.
To solve the parsing issue for all events
processed by libqtappfw, overloading is applied
to 'fromJdoc' method.
Bug-AGL: SPEC-3060
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I175848cba7f9f9e2e8b4e5984e7abc2a2fc12464
|
|
and include signal emit for voice status and cbl
changes.
- fix parsing event payload in presence of whitespaces;
- fix parsing voice events payload in presence of
'\n' chars;
- add missing model updates when status or cbl data
changes;
- fix authorization status enum value typo;
Bug-AGL: SPEC-2981
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I718bdfea1221211ed4c62ce1b695eabe83ab9590
|
|
libqtappfw should register for login events from
start up (along with other vshl events), so that
the information is available even if an user
didnt kick start the authorization process via
settings app.
- register to all vshl events on start up;
- rename 'subscribeToLoginEvents' to
'triggerCBLProcess', which is indeed the operation
implemented behind this method.
Bug-AGL: SPEC-2981
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I8aea5cac0b6d17b8ca3838d0958d2128cc745c0f
|
|
Various fixes for voice component:
- fix incorrect check on vap (voice agent profile) pointers;
- remove dependencies on vshl-capabilities: this module will
communicate via vshl-core api;
- remove dependencis on alexa-voiceagent;
- use a more generic name for cbl related operations. CBL
in this environment is understood as code based
login (for voice agent authorization via user login to a cloud
service), however, in the case of alexa it is known as code
based linking;
- add check for voice_xxx_event eventdata which in ocasions
is an empty object, i.e., the payload is missing.
Bug-AGL: SPEC-2981
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Icaab7a21bedb3e2696d541567162ec46b047a305
|
|
Add steering wheel events for use in tbtnavi and cluster gauges
applications.
Bug-AGL: SPEC-2950
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I51c792ecf131646d46bd027342b7e416f303b9c1
|
|
The units and timestamp fields from signal-composer events may be
useful for applications, so add them to the signal they get.
Bug-AGL: SPEC-3023
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I3c33da9b3afd04f0e18e00674328114e8903ce95
(cherry picked from commit 5f4576999a08efd4ccb401f033cd8183a53566b3)
|
|
Add support for new abstract event.vehicle.speed and event.engine.speed
events from the signal-composer binding. This should help avoid code
duplication in the Qt apps needing events from signal-composer.
Bug-AGL: SPEC-3023
Change-Id: I877f8c1cc057d0d491318ef5ad6a943119ffc8b8
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
|
|
- Add connection, auth and dialog status events
to VshlCoreVoiceMessage private events list.
- Fix logic error in AlexaVoiceMessage's auth events
processing. Error introduced by commit
'da091649e775b23a35eb88df1c2cf9ce3fb350f7'.
Bug-AGL: SPEC-2880
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Ia402c8307b16595be5a8f9a1ed79d5eeb0e08036
|
|
Bug-AGL: SPEC-2981
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I0195d914dc10f4fcdea1cb6df0e6a5859ad8269d
|
|
broadcastWaypoints doesn't actually broadcast out a valid event
currently, and thus just remove for now.
Bug-AGL: SPEC-2880
Change-Id: I9e865113949c236e59e27319b02ea22178a9dc9e
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Add initial navigation service support in qtappfw for new
agl-service-navigation rewrite.
Bug-AGL: SPEC-2880
Change-Id: I276de006af3c1e19e669ae3b9d05c92360893467
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Add missing Qt5Qml dependency for respective pkg-config
configuration.
Bug-AGL: SPEC-2880
Change-Id: I1fdd753875f6c79e18719282e58532d1bc17e576
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
|
|
On storage removal the metadata displayed for the media playing
should be cleared in consumer UI
Bug-AGL: SPEC-1430
Change-Id: I9824c94cf81fc0beb0cc278ac980813e906efbe8
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Update set_properties method arguments to match
agl-service-network binding expectations.
Bug-AGL: SPEC-2676
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I4e4c1c633193270ad14a517fd33eff6bf26b00d3
|
|
- Add new roles to provide UI clients with the
active configuration (values obtained from the
stack: agl-service-network binding + connman).
- Add Q_INVOKABLE methods to feed new values
from the UI client.
SPEC-2676
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Id239ddc549ec8471d44d56f7631d4e9e3efda798
|
|
|
|
|
|
Bug-AGL: SPEC-2737
Change-Id: I96d1f68aab63b29889d44b72dc45596ff104a96a
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Bug-AGL: SPEC-2561
Change-Id: I5c4df78a15cb009a742148a86432729deb434693
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
This commit provides:
- use of specific roles to signal model changes
for wired and wifi network models.
- fix to correctly broadcast wifi strength on
initial connection to previously unknown wifi
service.
Bug-AGL: SPEC-2339
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I35922d6c96b8b89fd4d376cddd8f4113cf18dbca
|
|
- include extra checks for error conditions
- remove some tabs and unused variable
Bug-AGL: SPEC-2636
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I28b38c77979175236a7b115a0f4263840c70eb94
|
|
Add bluetooth-map service support for notifications and message
composition.
Bug-AGL: SPEC-2561
Change-Id: I956150b9db05334eb02640657c1fc7e03258ab41
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
To avoid "SkippingbecauseOE_QMAKE_PATH_EXTERNAL_HOST_BINSisnotdefined" error
messages when building with the SDK add the respective path to CMakeLists.txt
Bug-AGL: SPEC-2535
Change-Id: I76a3204ebb26f7c30535299d8f8582320315c5f0
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Bug-AGL: SPEC-2541
Change-Id: I71961e011b4d4bbce2720896dbc0e2e43774cd14
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
|
|
To allow the switch from on every connection of updating the contact
info to per UI request of syncing.
This patchset adds the 'import' verb call. OBEX transfer are very slow
and ineffective for redundant data.
Also max_entries parameter is still left in for backwards compatiblity
but not used in the actual binding call.
Bug-AGL: SPEC-2541
Change-Id: I94e43b1fb5f6eeae3efde7d14ce7c3816cebe0ad
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
-Add WiredAdapter implementation
-Add WiredNetworkModel implementation
Bug-AGL: SPEC-2293
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Ibed93ae3a3cca1bc8e7a23c872c7ab3b8271e586
|
|
There's no return value if the WifiAdapter is not
found and thus the compiler warning.
Bug-AGL: SPEC-2293
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I59a2e5e7a86c845669b673753ec97dbaee0fc5ab
|
|
Rework WifiNetworkModel implementation to use
AbstractNetworkModel and ConnectionProfile classes.
Bug-AGL: SPEC-2293
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I47dc3dc1ef54ae24e176f8ff269b1219f3fcbc6c
|
|
- AbstractNetworkModel : abstract class which
provides common functionality and data to all
network models.
-ConnectionProfile : super class which aglomerates
connection property information, independently of
the technology type (e.g. wired or wifi).
A network model contains a list of available
connection profiles pertinent to the model.
Bug-AGL: SPEC-2293
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Ic7b9d59802d13067e057948d1fb109852f35c2fd
|
|
This reverts commit b95b16f5fe5671de805403b8067367e5de3044bc.
That commit was introduced to ensure homescreen
built without errors while swapping libqtappfw/network
interface for a new one.
Homescreen is already using the new interface, thus
the commit can be reverted
Bug-AGL: SPEC-2392
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: Ie92a16b9f66ddbca9c2502515e12c63fdc9752bb
|
|
agl-service-bluetooth-pbap now outputs JSON data of processed vCard
information, and now libvcard is no longer needed.
Bug-AGL: SPEC-2392
Change-Id: Ice1ec6e1a22687f4839fd3e8a286d279d8a4f586
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|