aboutsummaryrefslogtreecommitdiffstats
path: root/docs/5_How_To_Contribute/5_Reviewing_Changes.md
diff options
context:
space:
mode:
authorShankho Boron Ghosh <shankhoghosh123@gmail.com>2020-10-30 10:23:28 +0530
committerJan-Simon Moeller <jsmoeller@linuxfoundation.org>2020-11-11 13:36:16 +0000
commitda6cd0b6c26ca9a3760d8a89ce68baf83eeaa1b1 (patch)
tree5621912c4960ff1919f4664f95f4c4f62b347e5d /docs/5_How_To_Contribute/5_Reviewing_Changes.md
parente76766d79c3063b873b75bd2080c654f3f6d71ba (diff)
Added [in-progress] Developer Guides
Updated mkdocs.yml, README.md. Text wrap markdowns at 80. Bug-AGL: [SPEC-3633] Signed-off-by: Shankho Boron Ghosh <shankhoghosh123@gmail.com> Change-Id: I2d7b43cb870e97786d3eb101c60a2071cc50f0be Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/documentation/+/25498 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
Diffstat (limited to 'docs/5_How_To_Contribute/5_Reviewing_Changes.md')
-rw-r--r--docs/5_How_To_Contribute/5_Reviewing_Changes.md37
1 files changed, 18 insertions, 19 deletions
diff --git a/docs/5_How_To_Contribute/5_Reviewing_Changes.md b/docs/5_How_To_Contribute/5_Reviewing_Changes.md
index 14c18bf..e9d6758 100644
--- a/docs/5_How_To_Contribute/5_Reviewing_Changes.md
+++ b/docs/5_How_To_Contribute/5_Reviewing_Changes.md
@@ -14,8 +14,8 @@ title: Reviewing Changes
message and a score, -1, 0 or +1.
- **Patch Sets:** If multiple revisions of a patch exist, this button
- enables navigation among revisions to see the changes. By default,
- the most recent revision is presented.
+ enables navigation among revisions to see the changes. By default, the
+ most recent revision is presented.
- **Download:** This button brings up another window with multiple
options to download or checkout the current changeset. The button on
@@ -25,16 +25,15 @@ title: Reviewing Changes
Underneath the commit information, the files that have been changed by
this patch are displayed.
-3. Click on a filename to review it. Select the code base to
- differentiate against. The default is ``Base`` and it will generally
- be what is needed.
+3. Click on a filename to review it. Select the code base to differentiate
+ against. The default is ``Base`` and it will generally be what is needed.
-4. The review page presents the changes made to the file. At the top of
- the review, the presentation shows some general navigation options.
- Navigate through the patch set using the arrows on the top right
- corner. It is possible to go to the previous or next file in the set
- or to return to the main change screen. Click on the yellow sticky
- pad to add comments to the whole file.
+4. The review page presents the changes made to the file. At the top of the
+ review, the presentation shows some general navigation options. Navigate
+ through the patch set using the arrows on the top right corner. It is
+ possible to go to the previous or next file in the set or to return to the
+ main change screen. Click on the yellow sticky pad to add comments to the
+ whole file.
The focus of the page is on the comparison window. The changes made are
presented in green on the right versus the base version on the left.
@@ -44,13 +43,13 @@ title: Reviewing Changes
5. After adding the comment, it is saved as a *Draft*.
-6. Once you have reviewed all files and provided feedback, click the
- *green up arrow* at the top right to return to the main change page.
- Click the ``Reply`` button, write some final comments, and submit
- your score for the patch set. Click ``Post`` to submit the review of
- each reviewed file, as well as your final comment and score. Gerrit
- sends an email to the change-submitter and all listed reviewers.
- Finally, it logs the review for future reference. All individual
- comments are saved as *Draft* until the ``Post`` button is clicked.
+6. Once you have reviewed all files and provided feedback, click the *green up
+ arrow* at the top right to return to the main change page. Click the
+ ``Reply`` button, write some final comments, and submit your score for the
+ patch set. Click ``Post`` to submit the review of each reviewed file, as well
+ as your final comment and score. Gerrit sends an email to the
+ change-submitter and all listed reviewers. Finally, it logs the review for
+ future reference. All individual comments are saved as *Draft* until the
+ ``Post`` button is clicked.