aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-08-01Add default value for passwd and group tableRonan Le Martret1-1/+2
If someone want to add a value to USERADD_UID_TABLES , USERADD_GID_TABLES, the default value must be set. If not the AGL table won't be scan. Bug-AGL: SPEC-2500 Change-Id: I2325acdc61f6a5f840476b4c96734aed0a5c5744 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2019-08-01meta-rcar-gen3-adas: improve BBFILE descriptionHarunobu Kurokawa1-1/+1
To avoid the followings warning. WARNING: No bb files matched BBFILE_PATTERN_rcar-gen3-cogent Bug-AGL: SPEC-2708 Change-Id: I4bebc3203f947834b9264b4f79b0856c908af493 Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
2019-08-01af-binder: Fix error in synchronous callsJosé Bollo1-1/+1
There fixes a bug with an inversion between info and error in implementation of synchronous calls, leading to bad detection of errors. Includes: * 6bb714c afb-xreq: Remove field 'listener' * d325856 afb-binding.h: Ensure json-c/json.h is sourced * 056c53d AFB.js: Improve default token discovery * daecef1 supervisor: Setup services for local API use * 687d90d Fix detection of error in call synchronous Bug-AGL: SPEC-2697 Change-Id: I20cf2d5219e7cc962862b604e642610b0f8a75b1 Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-07-30bluez5: add obex.service.d conf to fix smack label issuesMatt Ranostay2-0/+7
All data transfer from obexd need to be located in a direcory that has a User::App-Shared label for bindings to be able to access them. This is done by moving the TMPDIR to /run/user/UID/usrshr Bug-AGL: SPEC-2695 Change-Id: I076eb89d0ed14af67811d497217db583e4f5902b Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-07-29lightmediascanner: remove user media directories scanningMatt Ranostay1-1/+1
Since lightmediascanner is now a system service it shouldn't scan user directories of the running user. For any demo uses of preloaded media it should be put in a directory under /media Bug-AGL: SPEC-2655 Change-Id: Ib62527f0742673081e1f225e98fe7eff90738e0e Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-07-26recipes-multimedia: lightmediascanner: move database to globally accessible areaMatt Ranostay1-2/+1
On runtime the agl-service-mediaplayer needs to access the sqlite3 database from lightmediascanner. Thus the database needs to be in an accessible location, and with the correct permissions. Bug-AGL: SPEC-2655 Change-Id: Ia1fc9ce7fa2f782ebc1784e130152baebb441cad Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-07-25intel-corei7-64: Remove ttyS2 from SERIAL_CONSOLESScott Murray1-0/+2
Remove ttyS2 from SERIAL_CONSOLES in the intel-corei7-64 include file. This quiets the log spamming on Up^2 from the device not being present. The commit that added ttyS2 to SERIAL_CONSOLES in meta-intel (61634f8) does not explain what boards need it, but since neither the minnowboard or Up^2 do, not having it by default seems reasonable. Bug-AGL: SPEC-2678 Change-Id: I9afd1584dd7b92e8d15363c3119b770c592b3c52 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-07-25Enable eglfs for QT based application in cluster profileOuyang Jun2-0/+38
Platform eglfs should be enabled if using a qtwayland compositor instead of weston. Bug-AGL: SPEC-2487 Signed-off-by: Ouyang Jun <ouyangj.fnst@cn.fujitsu.com> Signed-off-by: Zhou Mingying <zhoumy@cn.fujitsu.com> Signed-off-by: Liu Wenlong <liuwl.fnst@cn.fujitsu.com> Change-Id: Ic4d35999ea5f3f08b7a47baa5cf2f48bc01df6ee
2019-07-25Post-release bump of distro configJan-Simon Möller1-2/+2
Change-Id: I0f4c7e2b6747a18f7f13f5a4d0851808b5019221 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-07-24Fix i.MX6 multiple package tuning problemScott Murray3-0/+15
Update the i.MX6 machine definition include files to disable the dynamic package architecture logic in meta-freescale, as it conflicts with AGL's setting of DEFAULTTUNE and results in a split package feed. Bug-AGL: SPEC-2665 Change-Id: I66ff03b0bc48b3b768b9ec88c907eaa95e1a2b00 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-07-24Bump cmake-apps-module revisionFrederic Marec1-1/+1
Bump revision following gerrit review 21859 bd9e1c9 Fix new target test-tree d9af887 Add automatic test tree creation 5a26df7 02-variables.cmake: Fix wrong variable tested 7593f0f Recurse path when using fallback zip tool 4e1d47b CMake Nav Panel: Changed configuration title afba79c CMake project arch: Fixed title to match nav panel c26a064 CMake Configuring: Updated topic title. b99684d CMake Overview: Added TOC links and edits. 0c10393 Book manual updates for CMake Templates f46dcf2 02-variables.cmake: project options for 3.12.4 1e0f297 02-variables.cmake: project options for 3.12.4 3490ab7 02-variables.cmake: warns - unset project options 9ad5e65 02-variables.cmake: fix project cmake-commands 74fd1a5 Fix cmake-apps-module document typo. 2345e80 CMake: Complete re-write of the CMake topic. 9c07127 CMake Topic book: Updated for the new file names. 2710740 CMake Section: Complete re-write. 16829a3 cmake-apps-module: New file names. a6daa45 autobuild: fix warnings due to cp command exit code bcdefaf docs: add yaml book f3ce787 Avoid a target to link against itself Bug-AGL: SPEC-2040 Change-Id: I51d60cf572eb2a9a49ed25d3bb162c4f70b0b316 Signed-off-by: Frederic Marec <frederic.marec@iot.bzh>
2019-07-24recipes-multimedia: lightmediascanner: switch from user dbus session to systemMatt Ranostay4-15/+69
To avoid multiple instances of lightmediascanner from being created it should run only once in the system dbus session. Bug-AGL: SPEC-2655 Change-Id: I6c9510926f82ec9eb5625d63d08998a145504227 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-07-24bcm2835-bootfiles.bbappend: Support Raspberry Pi 4Leon Anavi1-0/+11
Use different bootfiles if the machine has been set to the new Raspberry Pi 4 and keep the old files for Raspberry Pi 3. Bug-AGL: SPEC-2656 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Change-Id: I3cbacc45c0f82ce2c70641c008ad2975a9e58fbd
2019-07-24rpi-config_git.bbappend: Update for Raspberry Pi 4Leon Anavi1-0/+20
Extend the deploy task to support Rasppberry Pi 4. Bug-AGL: SPEC-2656 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Change-Id: I3a166a873b431539e154ef6a2b1e69df02a0f2a3
2019-07-24u-boot_2019.07: Bootloader for Raspberry Pi 4Leon Anavi6-0/+457
Add U-Boot version that supports Raspberry Pi 4. Bug-AGL: SPEC-2656 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Change-Id: Ib550e38c7ecaf0ab2149b04666cffdcbaaf08134
2019-07-24linux-raspberrypi: Add 4.19 for Raspberry Pi 4Leon Anavi5-1/+158
Add recipe for Linux kernel 4.19 for Raspberry Pi 4 and keep 4.14 for Raspberry Pi 3. The recipe for 4.19 is backported from master branch of the upstream of meta-raspberrypi. Bug-AGL: SPEC-2656 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Change-Id: I93bbc5527383e26862894859bff6e44a6bc17966 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
2019-07-24raspberrypi4.conf: Add machine definitionLeon Anavi1-0/+25
Add a new machine definition for Raspberry Pi 4 because it is not present in branch thud of meta-raspberrypi. This machine definition is taken from the master branch of the upstream of Yocto/OE layer meta-raspberrypi. Bug-AGL: SPEC-2656 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Change-Id: I368f6c7107ca023da66ce60d2006984f8939cf00
2019-07-24templates: Add templates for Raspberry Pi 4Leon Anavi2-0/+6
Add local.conf and bblayears.conf templates for Raspberry Pi 4. Bug-AGL: SPEC-2656 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Change-Id: I51fb521e4cb8e963420cbe7c68272299a592840e
2019-07-24agl-service-steering-wheel: update SRCREVRaquel Medina1-2/+1
The SRCREV update brings in the following commits: 6d5d619 autobuild: set execute permission for autobuild scripts 932a226 Fix build warning of typecast e47b473 Change markdown syntax 07f4c99 autobuild: add autobuild scripts c404f25 Revert "Change steering to systemd service for ces2019" 1fed2c5 Change steering to systemd service for ces2019 Bug-AGL: SPEC-2164 Change-Id: Ic9e47595cb2a76084d9cd60fffb21c36a338a8cb Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2019-07-24add markdown documentation for all machines and featuresStéphane Desneux46-8/+474
THIS IS STILL WIP - not all features/machines are described Bug-AGL: SPEC-1902 Change-Id: I9bd5a3f57946199e1da90cfbed020742710218a1 Signed-off-by: Stéphane Desneux <stephane.desneux@iot.bzh>
2019-07-23linux-renesas: Add ADSP patch only for m3ulcbPierre Marzin1-1/+1
The patch are only used for the m3ulcb machine. Bug-AGL: SPEC-2564 Change-Id: Idfca2b7a48b7a53efee6dcf2f21b0f8932d7b43d Signed-off-by: Pierre Marzin <pierre.marzin@iot.bzh>
2019-07-23ebisu: Add the support of a custom setup scriptPierre Marzin1-5/+10
Used to customise a setup to add specific stuff. Bug-AGL: SPEC-2564 Change-Id: I8d18d026aaeb7c35a53164ea2f1a62f510ad4217 Signed-off-by: Pierre Marzin <pierre.marzin@iot.bzh>
2019-07-23ebisu: Use a specified path to integrate binariesPierre Marzin1-4/+19
E3 binary should be ZIPped into one archive and the path to its location should be exported to the environnement before setting up the AGL build. Bug-AGL: SPEC-2564 Change-Id: Ie26ba0246e7fbd0fe923fcbe0f4b4160c6d7e0f2 Signed-off-by: Pierre Marzin <pierre.marzin@iot.bzh>
2019-07-23ebisu: Update setup fragment to copy binariesPierre Marzin1-4/+16
Use copy_proprietary_softwares.sh script to manage the zip binaries pasted into "$METADIR/binary-tmp". Bug-AGL: SPEC-2564 Change-Id: I256d1200e03ab9a9482e29d7f42016f99c7ba16c Signed-off-by: Pierre Marzin <pierre.marzin@iot.bzh>
2019-07-23machine: Add new ebisu machinePierre Marzin7-1/+38
* Add ebisu dependency within renesas bootfiles * Delete rcar ADAS layers support * Add weston video output config * Add missing modules and gst plugin Bug-AGL: SPEC-2564 Change-Id: I61a44f831d0bc55210847eade2a1eacc7599fa74 Signed-off-by: Pierre Marzin <pierre.marzin@iot.bzh>
2019-07-23af-binder: Fix circular broadcast of eventsJosé Bollo1-1/+1
Include changes: * 6fe59e2 uuid: Add module for UUID generation * 5b59688 afb-evt: Refactor processing of broadcasted events * 6dfeafe Tag broadcasted events with UUID and hop * 51ab7c2 Fix bad memory access at client disconnection Bug-AGL: SPEC-2625 Change-Id: Ifa81293a783d5119d7a3d4c33598e1eb865e703c Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-07-20aglsetup: add -t|--topic and -V|--version optionsStephane Desneux3-12/+51
New options are: * -t|--topic : add a 'topic' to current setup (default: empty) * -V|--version : display aglsetup version The topic value can be any string and it is propagated to aglsetup.manifest, which in turn is used by distro-build-manifest to put it in DIST_BUILD_TOPIC variable in all build manifests (deploy dir, target image, sdk) Using the --topic option to specify a unique identifier will help to provide a common ID for all builds in the same "family" even if features and layers differ. For this purpose, a topic could be: * a gerrit review id + a patchset number * a project name (git repo) + a Change-Id * a random UUID * ... When run with -V or --version, aglsetup writes its version on stdout and sets the variable AGLSETUP_VERSION then exits. As aglsetup can only be called by being sourced, the AGLSETUP_VERSION variable is finally set in the caller environment. The version can be used for various purposes. The immediate goal is to detect if --topic option is supported or not. Bug-AGL: SPEC-2646 Change-Id: I0b68dfa297509dac07e9b2942948631cfc13c319 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-07-16distro-build-manifest: add DIST_BUILD_TS in all manifestsStephane Desneux2-6/+14
The build timestamp is added to build manifests deployed in target images and SDK. Also, this patch adds a new option '-t|--timestamp' to distro-manifest-generator.sh to let the recipe pass the same timestamp as the one used for the image suffix (in Yocto 2.6/Thud, DATETIME is used). So DIST_BUILD_TS should have the same value as the image version suffix. Bug-AGL: SPEC-2649 Change-Id: I2a9d11b2ce59753bca31ebb8e82d46c224110d68 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-07-16distro-build-manifest: fix incorrect DIST_LAYERSStephane Desneux1-1/+1
Using repo tool, a .repo subfolder is created beside the cloned git repositories. It contains also some git repositories (handled by repo tool). But when enumerating the layers, those extra ".repo/xxxx" git repositories must be ignored to get a consistent signature on layers. This patch excludes hidden folders (starting by '.') from the search. Bug-AGL: SPEC-2648 Change-Id: Ibee41d4efff0898d1bf67ab661ccdf70729b6211 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-07-13Prepare Happy Halibut rc3 v7.99.3halibut_7.99.3halibut/7.99.37.99.3Jan-Simon Möller1-3/+3
Bump the AGLVERSION and the AGLRELEASETYPE. Change-Id: Ia2744798f717c59c28de520220a16d5d13e1a7cf Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-07-13Revert "Fix rpi touchscreen support on master"Jan-Simon Moeller9-1120/+4
We need to reconsider this changeset. It seems to produce a regression. This reverts commit ccb667c35ffdea7a2bc1304750e6b22368cd55f7. Change-Id: I42754a899e8530f4e18a069ed227f18a8d615801
2019-07-13af-binder: Fix of subscribe issueJosé Bollo1-1/+1
Enforce serialization of messages, makes event really asynchronous, and enforce (un)subscribe in living request. Include the following changes: * 909893e afb-evt: Improve compatibility to guppy * 248ec5d afb-evt: send events in separate job * c8cc0d6 Revert "afb-stub-ws: Allow unordered process of messages" * bc38af3 afb-xreq: Forbids (un)subscribes after reply * 0342cd1 afb-client-demo: Allow pipe of messages Bug-AGL: SPEC-2215 Bug-AGL: SPEC-2219 Bug-AGL: SPEC-2542 Bug-AGL: SPEC-2599 Change-Id: I357aeb852e2041ac6056dd563dac42f29dadb52d Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-07-12netboot: adjust SMACK label for /etc/resolv.confStephane Desneux1-0/+1
When using netboot, the kernel is responsible for establishing the IP connection. For this reason, connman is instructed to "forget" this boot interface and /etc/resolv.conf is generated by the initrd script (from /proc/net/pnp). This patch removes the previously set SMACK label 'System' so file has label _, which makes it readable by any process. Bug-AGL: SPEC-2640 Change-Id: I13704827434a795aab2264755dc01ec796be8847 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-07-09af-binder: Fix supervision socket nameJosé Bollo1-1/+1
A typo in the recipe of af-binder avoided to correctly define the supervision socket. Bug-AGL: SPEC-2621 Change-Id: I47dcd94e5454d85d9b5994d4f82a0f8abb400000 Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-07-09agl-service-hvac: Install hvac.json into /etcHarunobu Kurokawa1-0/+4
agl-service-hvac has hvac.json file to set LED and CAN_DEV parameter, however this file is not installed. v2 move to main bb recipe file. fix wrong discription from WORKDIR to {S}. Bug-AGL: SPEC-2600 Change-Id: I8c0a416b3196b67cbb131d9351a1d20cc2dfe74f Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
2019-07-09Flip distro config post rc2Jan-Simon Möller1-2/+2
Change the distro config to post-RC2 . Change-Id: I5135ab220d2b38a5fa049661f2346eed010648a5 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-07-07netboot: systemd must mount /tmp and /runStephane Desneux1-2/+8
When using netboot, the initrd script mounts /tmp and /run before pivoting on the new rootfs and then running systemd. As a consequence, systemd doesn't try to remount /tmp or /run (and the correct smack labels are not applied on /tmp and /run, leading to many issues). This patch unmounts /tmp and /run just before running systemd which will then mount them with correct labels. Bug-AGL: SPEC-2596 Change-Id: I4cd7b67f04c232a6e48c777fb5fefa6c46f6744a Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-07-07Change the AGL mirror setup following the server changeJan-Simon Möller1-11/+22
The download server is currently http only. Add a fallback option to the MIRRORS in the distro configuration. Change-Id: Ic5403d921463a4f6aea813a150950c0d023aa77d Bug-AGL: SPEC-2604 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-07-03agl-core-connectivity: add avahi-daemon when agl-devel feature is setStephane Desneux1-0/+3
Accessing the boards using .local addresses is convenient. But avahi-daemon is not pulled explicitely in images. This patch adds packagegroup-base-zeroconf (containing avahi-daemon) in the core image only when agl-devel feature is set and zeroconf is enabled in DISTRO_FEATURES Bug-AGL: SPEC-2592 Change-Id: Iea899d98cd0d8628f9533641f7b42c04f4580c64 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-07-01Prepare Happy Halibut rc2 releasehalibut_7.99.2halibut/7.99.27.99.2Jan-Simon Möller1-3/+3
Change the distro configuration in preparation of HH rc2. Change-Id: I6ca53cb2a2981c1c63133efd6d0222ede64f09f8 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-06-28recipes-core: systemd: move canbus-can.network scriptMatt Ranostay3-8/+4
Move canbus network script from meta-agl-profile-telematics to meta-profile-core. Since this is useful for more than just telematics Bug-AGL: SPEC-2580 Change-Id: I93666d87f1fb3eb037743d2858a8757d6939c5e3 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-27linux-agl: change aloop to a module instead of built-inScott Murray2-4/+4
Rename the 4a-sound.cfg fragment to the more generic sound.cfg, and change CONFIG_SND_ALOOP to module, not built-in. This still keeps it available if something ends up needing it. Bug-AGL: SPEC-2555 Change-Id: Ib0554800dc704d19b48a7e041d4f2b60a1b42192 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-06-26agl-hmi-framework: remove virtual/navigation over-rideScott Murray1-1/+0
Remove dangling PREFERRED_PROVIDER over-ride of virtual/navigation that was forcing the use of the older navigation application instead of the setting of the newer ondemandnavi application done in the distro configuration. Bug-AGL: SPEC-2576 Change-Id: Id6f7d6636bef5cf40dc5085b02030acd0e7d494d Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-06-26rtl-sdr: Install tweaked udev rulesScott Murray1-2/+8
To enable agl-service-radio to access the RTL-SDR USB devices, install the provided rtl-sdr.rules file in /etc/udev/rules.d, modifying it to tweak the device permissions, group, and SMACK label to meet the requirements for the new application framework audio permission. Bug-AGL: SPEC-2573 Change-Id: I22e2c624b8c57df0b5932ba7f8a377ae2c0d9566 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-06-26Append a new empty line to features' local template file when setting up AGLBechir Mghirbi1-0/+1
A missing empty line at the end of a feature's local template file will lead to a ParseError error. This patchset will automatically append a new line at the end of the feature's local template file when setting up AGL. Bug-AGL: SPEC-2563 Signed-off-by: Bechir Mghirbi <bechir.mghirbi@grammer.com> Change-Id: Ica9decdb0bda182de7e25ace4fca6a9f6f7db5ff
2019-06-25agl-service-unicens: add missing DEPENDSScott Murray1-1/+1
agl-service-unicens now needs libafb-helpers to build, add it to DEPENDS in its recipe. Bug-AGL: SPEC-2562 Change-Id: Ief299b51bffb288f2143bfae3cc7a646ba93b43b Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-06-23Move the agl-service-radio to the graphical profileJan-Simon Möller8-5/+5
The agl-service-radio relies on gstreamer. Unfortunately the gstreamer recipe is currently setup to also pull-in wayland (due to a compile-flag if wayland is in DISTRO_FEATURES). To keep the distro aligned, we don't want to change the DISTRO_FEATURES between the profiles, thus we move the agl-service radio to the graphical profile where we include weston anyway by default. For now this means there is no radio service (or mediaplayer service) w/o wayland installed as well. In case we get this requirement, we'll have to work on the gstreamer recipe and its split. v2: fix bbapend in meta-agl-bsp/meta-rcar-gen3 v3: put packagegroup-agl-graphical-multimedia.bbappend in graphical profile (not the best place IMHO) This fixes the non-graphical build. Bug-AGL: SPEC-2500 Change-Id: I5ebec7d7713510f3fcd50ae425d7f8cbb6328016 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-06-21SPEC-2376: Add config for QEMU arm kernelsCorentin Labbe3-0/+11
The default yocto qemuarm machine is versatilepb which is not the right choice for AGL (ex: Max 256M of RAM). This patchs change qemuarm configs for using the virt machine. Change-Id: Ib5e0ae801ba152318a2455763b1a2f1020d1858e Bug-AGL: SPEC-2376 Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
2019-06-21Add support for nbd protocol v3Ronan Le Martret3-3/+18
Add a new cmdline argument using option 'nbd.v3' that could be parsed by the initrd script used for netboot. Bug-AGL: SPEC-1423 Change-Id: I1cd189c343672631feda5bcee2e393eb46b9d000 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2019-06-20recipes-apis: agl-service-windowmanager: update SRCREVRaquel Medina1-1/+1
* LayerControl: return error if surface is not ready Bug-AGL: SPEC-2291 Change-Id: Iac8596fdb2aeac29c9bb47db906abad4d2498fc8 Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>