| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
We have multiple entries to cover, fix the BBFILE_PATTERN .
Bug-AGL: SPEC-3443
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
Change-Id: I2fe95bf183fafa776668a63f9e28775a6f0547e0
Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/24916
Reviewed-by: Stéphane Desneux <stephane.desneux@iot.bzh>
|
|
We need to see if we leave it as generic IMAGE_INSTALL_append here or
do it elsewhere.
For now this is a straightforward migration and helps clean-up the layer.conf .
Bug-AGL: SPEC-3443
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
Change-Id: If7a482dc411ba7fc4d172f8fdf8493b81475ea93
Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/24915
Reviewed-by: Stéphane Desneux <stephane.desneux@iot.bzh>
|
|
Currently the upstream rcar bsp does need the fix for building perf.
The meta-rcar-gen3-adas layer contains a fix in the big patchqueue.
Thus conditionally apply the perf build fix.
Bug-AGL: SPEC-3443
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
Change-Id: Icbf53add71ed731c35dec149841691c82ae4372c
Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/24914
Reviewed-by: Stéphane Desneux <stephane.desneux@iot.bzh>
|
|
Thanks to the work done by Renesas and members of our community, we can
now directly use meta-renesas from upstream github.
A shout-out to everyone involved (Kurokawa-san, Ronan, Stephane).
It turned-out it is simpler to create a symlink-based slim version
of meta-rcar-gen3-adas layer instead of BBMASK'ing what should
not be in there. See the comments in
meta-agl-bsp/meta-rcar-gen3-adas/conf/NOTES
as to why.
Remaining work is to include the packages outside of the layer.conf
in a follow-up.
Bug-AGL: SPEC-3380
Change-Id: I2be1b44049d74146546380e2eb866f0558a26822
Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/24796
Reviewed-by: Stéphane Desneux <stephane.desneux@iot.bzh>
|
|
The meta-rcar has a patch that change the name of the sound card.
Reintroduce the Cogent layer "meta-rcar" into AGL mean adjust the sound card name.
Bug-AGL: SPEC-3463
Change-Id: I4ff025752314fdbebbdae39c66280943304daefc
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/24760
Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
Tested-by: Jenkins Job builder account <agl-jobbuilder@automotivelinux.org>
|
|
There is a bbappend in the cogent layer which is not forward-compatible with
YP 'dunfell' 3.1.1 . BBMASK it until upstream did fix it.
Bug-AGL: SPEC-3445
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
Change-Id: Ib301bb14e53a37f445c74461982fbbc24bcdae2f
Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/24861
Tested-by: Jenkins Job builder account <agl-jobbuilder@automotivelinux.org>
ci-image-build: Jenkins Job builder account <agl-jobbuilder@automotivelinux.org>
ci-image-boot-test: Jenkins Job builder account <agl-jobbuilder@automotivelinux.org>
|
|
For the upgrade to YP dunfell/3.1 we need to update the layer
compatibility.
Bug-AGL: SPEC-3302
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Ieb1ac9ef1f48f077c9cd312c4ac295ae1cc062b0
|
|
* agl/next:
meta-agl-bsp: Add CONFIG_LSM workaround for 5.1+ kernels
meta-agl-profile-cluster-qt5: disable qtbase patches
zeus updates for dragonboard-410c
meta-security: activates dbus-cynagora
recipes-graphics/wayland/weston: Expose weston_output_damage()
meta-agl-profile-core: tweak udisks2 configuration for AGL
meta-agl-bsp/meta-arago: update weston bbappend
[RCAR] Update rcar driver weston 7 bsp 3.21.0
[RCAR] Update rcar driver weston 7 bsp 3.21.0
[RCAR] Split ADSP path for ulcb and ulcb-kf
Fix nss-localuser post install
meta-agl-bsp: meta-raspberrypi: handle zeus upgrade
meta-agl-profile-core: add patch for systemd-udevd SECLABEL crash
meta-security: disable dbus-cynara patches
meta-agl-bsp: handle ptest-runner upgrade
meta-agl-distro: Add inc file for next branch over-rides
meta-agl-distro: BBMASK problematic upstream meta-security bbappend
meta-agl-distro: prefer linux-yocto 4.19 LTS kernel
meta-agl-profile-graphical-qt5: enable qt5location services
meta-agl-profile-core: update most recipe
meta-agl-profile-core: update neardal recipe
Update base local.conf.sample
meta-agl-profile-graphical: don't always build agl-compositor
meta-agl-profile-graphical: update weston and weston-init
meta-agl-profile-graphical: update wayland-ivi-extension for weston 7.0.0
meta-agl-distro: add polkit to DISTRO_FEATURES
meta-agl-profile-core: update fontconfig bbappend
meta-agl-profile-core: switch to udisks2
meta-security: handle systemd upgrade
meta-agl-profile-graphical-qt5: handle qtwayland upgrade
meta-agl-profile-core: handle freetype upgrade
meta-agl-bsp meta-agl-profile-core: upgrade to opencv 4.x
meta-agl-profile-core: update rtl-sdr recipe for zeus
meta-security meta-app-framework: handle xmlsec1 upgrade
meta-agl-profile-graphical: upgrade to gstreamer 1.16
meta-agl-profile-core: remove libmicrohttpd backport
meta-agl-profile-core: remove backported curl and nghttp2 recipes
meta-agl-profile-core: remove libnfc recipe
meta-agl-profile-core: remove connman backport
meta-agl-profile-graphical: remove weston 5.0.0 patches
meta-agl-profile-core: remove old glibc patch
meta-agl-bsp/meta-intel: remove linux-firmware_git.bbappend
meta-agl-bsp: remove weston and wayland-protocols backports
meta-app-framework: remove libzip recipe
meta-security: remove keyutils recipe
Declare layer compatibility with zeus
Change-Id: Ie8ee1e37958279e7cf2d503c54ffacb46ba0c31c
|
|
- For SOTA we need to use ${nonarch_base_libdir} instead of /lib
Change-Id: I84fbbe44abd9f3a3752b555791c8e1e06c755a9b
Bug-AGL: SPEC-3097
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
|
|
- If we want to build AGL for ulcb board without
the meta-rcar (kingficher board support), we need to
split the patch.
Change-Id: I145887d4619a7132e46f98f30e1fc0dd3de6b29a
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
|
|
For the uprev to YP 3.0 zeus we need to update the layer compatibility.
Change-Id: Ib762915305588c39400c3c8343152b4ecbfa4556
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
|
|
Add a systemd service unit and recipe to install it and a udev rules
file so that the Kingfisher Si4689 radio will be initialized on boot
if present, and the I2C device to access it will be accessible to
applications with the "audio" permission. Note that an accompanying
change to agl-service-radio is required to remove its now unworkable
usage of the si_init script, which is replaced by this change.
Bug-AGL: SPEC-2716
Change-Id: I81cf4b8c439598bdac1eb7910a0d693825141d7b
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
|
|
To avoid the followings warning.
WARNING: No bb files matched BBFILE_PATTERN_rcar-gen3-cogent
Bug-AGL: SPEC-2708
Change-Id: I4bebc3203f947834b9264b4f79b0856c908af493
Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
|
|
|
|
To be merged together with:
https://gerrit.automotivelinux.org/gerrit/#/c/AGL/AGL-repo/+/21389/
v2: fix the aglsetup script
v3: fix scripts to extract m3ulcb
v4: use single folder for BSPs
Bug-AGL: SPEC-2450
Change-Id: I3227896c68ec1413f55cf67ad8f15a7adfe87a52
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
|
|
Bug-AGL: SPEC-2486
Change-Id: Ic0cf9128d1630ede1af8024e3bd5258b7529b683
Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
|
|
Changes include:
- Add LAYERSERIES_COMPAT definitions to layer.conf files
- Remove now unnecessary SECURITY_*FLAGS over-rides from distro
configuration
- Set intel-corei7-64 preferred kernel version to 4.19 to match
latest linux-intel kernel available in meta-intel
- Update qemuarm preferred kernel version to 4.18 to match latest
linux-yocto
- Update firmware package and devicetree file names for raspberrypi3
- Remove linux-firmware bbappend specific to raspberrypi, it seems no
longer required and breaks the cross SDK build
- Update linux-intel bbappend to 4.19, remove now unnecessary patch
- Remove now unnecessary lttng-modules backport
- Update linux-raspberrypi bbappend to 4.14 kernel
- Added kernel configuration fragment for raspberrypi to disable
Kprobes. This is required until linux-raspberrypi is updated to
greater than 4.14.104 to avoid a build failure in lttng-modules
related to a check for known breakage in the kernel CONFIG_OPTPROBES
code.
- Replace obsolete base_conditional usage with oe.utils.conditional
- Add gstreamer1.0-plugins-bad bbappend for raspberrypi3 to disable
faad PACKAGECONFIG to avoid commercial license issues
- Remove unused and unbuildable Vayu gstreamer recipes
- Update linux-ti-staging bbappend for new BSP kernel
- Regen dcan2_pinmux_enable.patch for linux-ti-staging to remove fuzz
warning, and remove upstreamed fix_dcan_addresses.patch
- Remove ipumm-fw from meta-agl-bsp/meta-ti, as newer version is
available in the upstream BSP
- Update meta-agl-bsp/meta-ti weston patch to apply against 5.0.0
- Update meta-agl-bsp/meta-ti wayland-ivi-extension patch to apply
against 2.2.0
- Add ti-sgx-ddk-km patch to add AGL toolchain configuration file
- Remove now unnecessary fdtoverlay recipe
- Update core.cfg and ivishell.cfg in weston-ini-conf recipe to handle
move of ivi-controller.so configuration in Weston 5.0.0
- Update connman-ncurses patch to remove fuzz warning
- Add installation of systemd over-ride file for run-postinsts.service
in run-postinsts bbappend to workaround race condition between
ldconfig.service and the /sbin/ldconfig invocations in the
post-install scripts run by run-postinsts.service. The observed
failure was cynara's post-install script failing and its database
not being created.
- Remove now unnecessary valgrind backport
- Add patches to fix most driver compilation against newer kernels
- Update libmicrohttpd bbappend
- Remove libssp-dev from agl-image-graphical-qt5-crosssdk and
agl-demo-platform-html5-crosssdk, upstream have removed it from
non-mingw32 platform SDKs
- Update wayland-ivi-extension recipe to build 2.2.0, and update
local patches
- Update weston patches for 5.0.0. Patches:
0016-ivi-shell_add_screen_remove_layer_api.patch
0017-ivi-shell-register-ivi_layout_interface.patch
have been removed as they have been applied upstream and are no longer
necessary. Patches:
0018-compositor-add-output-type-to-weston_output.patch
0019-compositor-drm-introduce-drm_get_dmafd_from_view.patch
(both related to Waltham) have been disabled for now as they need
significant rework.
- Remove weston-conf RRECOMMENDS in weston bbappend to avoid conflict
with weston-ini-conf
- Add OECMAKE_GENERATOR = "Unix Makefiles" to aglwgt.bbclass to work
around CMake+ninja issue in cmake-apps-module
- Update dbus cynara patches for 1.12.10
- Add do_install_append in cynara recipe to remove /var/cynara from
cynara package so the directory creation and labelling in the
post-install scriptlet will function as intended
- Remove now unnecessary e2fsprogs backport
- Remove now unnecessary libcap-ng backport
- Update pulseaudio patches to remove fuzz warnings
- Update neardal patch to remove fuzz warning
- Update freetype patch to remove fuzz warning
- Rename opencv bbappend to 3.% to handle 3.x backports in upstream
- Updated qtwayland patch to remove fuzz warning
Changes from Stephane Desneux <stephane.desneux@iot.bzh>:
- Remove wayland-ivi-extension PREFERRED_VERSION
- Remove now unnecessary nativesdk-cmake patch
- Remove now unnecessary ptest-runner patches
- Remove now unnecessary harfbuzz patches
- Disable waltham-transmitter as it does not build against weston 5.0.0
- Update af-main, cynara, and security-manager to use pkg_postinst_ontarget
- Bump connman-ncurses revision to avoid deprecated ncurses functions
- Update libva package usage with new intel-vaapi-driver name
- Add patches to security-manager to fix compilation with gcc8
- Updated systemd bbappend
Changes from Jan-Simon Möller <jsmoeller@linuxfoundation.org>:
- Remove meta-agl-bsp/ROCKO.FIXMEs
- Remove linux-yocto_4.12.bbappend and now unnecessary associated
patch
- Remove now unneeded kern-tools-native patch
- Bump gstreamer PREFERRED_VERSIONs to 1.14.x
- Remove latencytop from packagegroup-agl-core-devel, it has been
dropped by upstream
- Remove now unnecessary rpm patches
- Update pulseaudio bbappend to 12.2
- Update opencv bbappend to 3.4
- Update freetype bbappend to 2.9.1
- Update dbus bbappend to 1.12.10
- Update weston bbappend to 5.0.0
- Update cynara patches to remove fuzz warnings
- Add patch to cynara to fix compilation with gcc8
- Add xmlsec1 bbappend to clear EXTRA_OECONF to fix compilation on
sumo or newer
Changes from Ronan Le Martet <ronan.lemartet@iot.bzh>:
- Update meta-rcar-gen3-adas layer gstreamer1.0-plugin-vspfilter
bbappend to version 1.0.1
Known issues (marked with FIXME):
- CMake+ninja issue in cmake-apps-module has been worked around with
OECMAKE_GENERATOR
- waltham-transmitter and the patches to weston related to it have been
disabled
- Currently unclear if patch to libcap-native is actually required or
not
Bug-AGL: SPEC-1837
Change-Id: I7b8b9ef667aec2d229952eace6663dfc761654d0
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
|
|
This fix is now include cogent BSP (RCAR BSP v3.15.0).
Bug-AGL: SPEC-2185
Change-Id: Ib8de25f269a9c3b953075d33afb6f9d399f1471d
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
|
|
gpsd-defaults was typo as gspd-defaults which causes the incorrect
gpsd default settings on M3+KF
Bug-AGL: SPEC-2111
Change-Id: I47a098893f214054a7cb687e1cf3a6897d077863
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
|
|
Bug-AGL: SPEC-1945
Latest meta-rcar update SDIO frequency for TI's WLAN driver.
However, in M3 case, the this patch raise ti/wlcore driver WANING.
[ 107.009706] ------------[ cut here ]------------
[ 107.014342] WARNING: CPU: 0 PID: 4224 at /kernel-source//drivers/net/wireless/ti/wlcore/sdio.c:145 wl12xx_sdio_raw_write+0xb0/0x160 [wlcore_sdio]
[ 107.027375] Modules linked in: rfcomm 8021q garp stp mrp llc can_bcm can bnep nfc arc4 wl18xx wlcore mac80211 cfg80211 crc32_ce crct10dif_ce btwilink bluetooth ecdh_generic wlcore_sdio rcar_can st_drv rfkill can_dev vspm_if(O) vsp2(O) vspm(O) uvcs_drv(O) sllin(O) pvrsrvkm(O) mmngrbuf(O) mmngr(O) hdm_usb(O) hdm_i2c(O) hdm_dim2(O) aim_v4l2(O) aim_sound(O) aim_network(O) aim_cdev(O) mostcore(O) ipv6
[ 107.062537] CPU: 0 PID: 4224 Comm: wpa_supplicant Tainted: G O 4.14.35-yocto-standard #1
[ 107.071749] Hardware name: Renesas M3ULCB Kingfisher board based on r8a7796 (DT)
[ 107.079138] task: ffff8005fc610e00 task.stack: ffff000020bc8000
[ 107.085054] PC is at wl12xx_sdio_raw_write+0xb0/0x160 [wlcore_sdio]
[ 107.091316] LR is at wl12xx_sdio_raw_write+0x7c/0x160 [wlcore_sdio]
<snip>
[ 107.467808] ---[ end trace 0140d637a5afd50b ]---
[ 107.472613] wl1271_sdio mmc2:0001:2: sdio write failed (-84)
[ 107.478340] ------------[ cut here ]------------
[ 107.483008] WARNING: CPU: 0 PID: 4224 at /kernel-source//drivers/net/wireless/ti/wlcore/main.c:796 wl12xx_queue_recovery_work.part.26+0x58/0x60 [wlcore]
[ 107.496648] Modules linked in: rfcomm 8021q garp stp mrp llc can_bcm can bnep nfc arc4 wl18xx wlcore mac80211 cfg80211 crc32_ce crct10dif_ce btwilink bluetooth ecdh_generic wlcore_sdio rcar_can st_drv rfkill can_dev vspm_if(O) vsp2(O) vspm(O) uvcs_drv(O) sllin(O) pvrsrvkm(O) mmngrbuf(O) mmngr(O) hdm_usb(O) hdm_i2c(O) hdm_dim2(O) aim_v4l2(O) aim_sound(O) aim_network(O) aim_cdev(O) mostcore(O) ipv6
[ 107.531806] CPU: 0 PID: 4224 Comm: wpa_supplicant Tainted: G W O 4.14.35-yocto-standard #1
[ 107.541018] Hardware name: Renesas M3ULCB Kingfisher board based on r8a7796 (DT)
[ 107.548406] task: ffff8005fc610e00 task.stack: ffff000020bc8000
[ 107.554363] PC is at wl12xx_queue_recovery_work.part.26+0x58/0x60 [wlcore]
[ 107.561265] LR is at wl12xx_queue_recovery_work+0x1c/0x28 [wlcore]
Change-Id: I6f15251e6997f52892efd118e8941af5930c5ca9
Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
|
|
virtual/gpsd-conf is a runtime dependency in packagegroup-agl-core-navigation.
So, PREFERRED_RPROVIDER must be used in place of PREFERRED_PROVIDER
Bug-AGL: SPEC-1861
Change-Id: I15b915c2e7a1410000f7527b13f3206242778bc0
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
|
|
The meta-rcar-gen3-adas layer, active on m3ulcb and h3ulcb boards, enables
the Renesas IMR device, which takes the first few /dev/videoX device
file names, shifting the names of all of the other /dev/video devices.
This patch updates the vspfilter configuration files to reflect the change.
Change-Id: I326d3f5bb295f813e58d2318310cf86ad52744b3
Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
|
|
* ti-bt needs to have a correct PN and PR to be
compliant with dnf and so rpm.
Bug-AGL: SPEC-920
Change-Id: I1b83ce54340922a23a6f0de5873e48699c2e1101
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
|
|
* For the Renesas Gen3 extention board Kingfisher,
we must specify the GPS device for gpsd service.
* Create a new machine type kingfisher.
Bug-AGL: SPEC-1538
Change-Id: If6b7e49f6a006218e57c58e15855e0d65eb849cd
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
|
|
- The PACKAGECONFIG value "experimental" was remove recently
(Upgrade Bluez version 5.43 -> 5.44).
(From poky): feacb428b055fd714eb1b15402023f4a726dce54
-PACKAGECONFIG[experimental] = "--enable-experimental,--disable-experimental,"
- So we can remove "experimental" feature to avoid yocto Warning.
Bug-AGL: SPEC-1398
Change-Id: Ibd96a788bd0c4e0d9bc6959012bbbf839d890e9d
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
|
|
* valgrind was backport in meta-rcar from cogent (unidentified reason).
In some builds environement, the build of this recipes failed
(issue hardly reproductible). So remove valgrind backported recipes
should resolve the build issue and upstream recipes from yocto will be
used.
Bug-AGL: SPEC-1374
Change-Id: I1bc3d065badd1e2cd35b2a7b1a3c5fb43c357c06
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
|
|
Change-Id: I115096811662403f34846f434fbc7772024c1634
Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
|
|
This commit is removed from meta-renesas-rcar-gen3
====
commit a5dfadaa3931977a221e0508354e9ab97482b9ab
Author: Scott Murray <scott.murray@konsulko.com>
Date: Thu Dec 21 20:46:30 2017 -0500
====
Some changes to allow integration with the AGL radio binding and
improve FM configuration with some tweaks and additional configuration
options.
Changes include:
- Add command-line option for selecting FM band plan. The default
band plan is US / Canada.
- Add command-line options for setting FM scanning valid SNR and RSSI
thresholds to allow tweaking sensitivity in poor radio environments.
- Increased seeking scan timeout to 3 seconds, which seems to improve
behavior in poor radio environments where powerful stations may be
far apart.
- Removed explicit setting of FM_SOFTMUTE_SNR_LIMITS, as it seemed
like it might be resulting in odd muting behavior when scanning.
- Changed initial FM frequency if not specified to the minimum of the
band plan.
Change-Id: I5d8c95947489b83384babb50285b76d3de45214a
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
|
|
Kingfisher has MedlaLB Interface for most, kernel tree has
most driver as build-in driver. So these configs is enabled.
Howemver AGL use most driver in gerrit repository. So AGL
should be disable it.
Change-Id: Ia46500d58fc16f348a098c58f5e807cf37913e5e
Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
|
|
We need to provide a systemd unit for UIM to be started at boot. We
also do not want the blacklist that Cogent has created, so delete that.
Bug-AGL: SPEC-1175
Change-Id: Ia35a6007722d4e42a7a76fe9d8d26b90b073f73b
Signed-off-by: Matt Porter <mporter@konsulko.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
|
|
Change-Id: Id1b6b88e606d0a102eefbdb9c8deae2dfe0cf73b
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
|
|
Change-Id: I75b9ced887249380a6164296b73acaaca91e3060
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
|
Jan-Simon Möller
Ronan Le Martret
Scott Murray
Harunobu Kurokawa
Matt Ranostay
Stephane Desneux
Damian Hobson-Garcia
Matt Porter