summaryrefslogtreecommitdiffstats
path: root/meta-agl-bsp
AgeCommit message (Collapse)AuthorFilesLines
2018-10-31gpsd-kingfisher-conf: fix PREFERRED_RPROVIDER issueStephane Desneux1-1/+1
virtual/gpsd-conf is a runtime dependency in packagegroup-agl-core-navigation. So, PREFERRED_RPROVIDER must be used in place of PREFERRED_PROVIDER Bug-AGL: SPEC-1861 Change-Id: I15b915c2e7a1410000f7527b13f3206242778bc0 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-10-19meta-agl-bsp: kernel: fix can-bus.cfgKevin Hilman1-1/+0
This config fragment for CAN bus had both an option for enabling as a module: CONFIG_CAN_C_CAN=m and for disabling: # CONFIG_CAN_C_CAN is not set Since the disable came last, disable wins. This caused the C_CAN driver and the C_CAN_PLATFORM driver (used by the TI dra7-evm) to be disabled in the kernel. To fix, remove the option to disable. Change-Id: I5be0cee161318cdfe7deb9c5e9c9f15d79cda7ac Fixes: d870883e7b29d212dc3e2a0e6158d837d4356c6a Signed-off-by: Kevin Hilman <khilman@baylibre.com>
2018-10-19rcar: gstreamer: Update vspfilter device files when using IMR devicesDamian Hobson-Garcia3-0/+7
The meta-rcar-gen3-adas layer, active on m3ulcb and h3ulcb boards, enables the Renesas IMR device, which takes the first few /dev/videoX device file names, shifting the names of all of the other /dev/video devices. This patch updates the vspfilter configuration files to reflect the change. Change-Id: I326d3f5bb295f813e58d2318310cf86ad52744b3 Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
2018-10-15Add dummy iiodevice support for testFrederic Marec2-0/+29
Add new fragment iiodevice.cfg to enable dummy devices For iiodevices test Change-Id: I9f635334aec2f9cd675b522b86cdfa3ad8168f07 Signed-off-by: Frederic Marec <frederic.marec@iot.bzh>
2018-10-12Clean-up of wayland-ivi-extension_1.13.0 related legacy stuffMichael Teyfel1-5/+0
Since the agl demo is now using wayland-ivi-extension v2.0.2 everything related to v1.13.0 should be removed. That means all bitbake recipes and also the used patch files. Change-Id: I326c8e13c6084ec2135d6f75d64db260d347491e Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
2018-10-12[RCAR] ADSP enable and add sound hardware abstraction in DTRonan Le Martret2-0/+126
The ADSP on Renesas SoCs required a reserved memory area to become enabled, and this needs to be done manually. This patch adds sound hardware abstraction information for the m3ulcb and m3ulcb-kf (kingfisher) device trees. This is helpful on-board the ADSP for dynamically determining sound hardware at runtime, allowing single binaries to be used between the two boards. Future work will incorporate the h3ulcb and Salvator boards into the abstraction. Bug-AGL: SPEC-1227 Bug-AGL: SPEC-1424 Bug-AGL: SPEC-1571 Change-Id: I78edc5854a95520276bdcd9fd9766a120d2c04d7 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh> Signed-off-by: Mark Farrugia <mark.farrugia@fiberdyne.com.au> Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-10-12[RCAR] Enable Linux-based hypervisor execution in AGLRonan Le Martret2-0/+33
The upstream version of AGL boots Linux in EL1. This mode is not privileged enough to put in place the correct configuration of an hypervisor (e.g., KVM). This patch leverages the ATF rcar platform configuration variables to boot the Linux kernel in EL2, instead of EL1, allowing Linux-based hypervisors such as KVM to configure all the necessary stubs to properly run virtual machines. This patch has been successfully tested with ATF, KVM and AGL rootfs on the Renesas R-Car M3. Changelog: - Added arm-trusted-firmware patch, which makes this work easy to be tested by the community - This patch version does not contain Linux kernel modifications. In fact, these resulted not necessary with the proposed ATF patch and a recent kernel (higher than 4.6) Bug-AGL: SPEC-497 Bug-AGL: SPEC-1571 Signed-off-by: Michele Paolino <m.paolino@virtualopensystems.com> Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh> Change-Id: I8d20e36a09be1dba35b10193643ea00e4f388e95 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-10-12[RCAR] Update RCAR BSP to 3.9Ronan Le Martret1-2/+2
Bug-AGL: SPEC-1571 Change-Id: Ieefd423b79faa220531a887ff167227044ab6064 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-10-12[RCAR] Change RENESAS_DATADIR valueRonan Le Martret1-0/+2
* AGL doesn't use /usr/local for system files. All the Renesas libraries and binaries will be installed in /usr instead of /usr/local. Bug-AGL: SPEC-1571 Change-Id: Ibc40df5d492517773bf89e4e0f117a02d22d90cd Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-10-08Mutualizes code for ulcb card family conf fileRonan Le Martret5-106/+52
Remove duplicate code between ulcb card configuration card. Since more an more ulcb card and extention, it becomes difficult to maintain the conf file of the ulcb family. Change-Id: Id5648f4e75c464875d3b175c769e1fdd7f4312f5 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-10-05[RCAR] Fix ti-bt package name and revisionRonan Le Martret1-0/+3
* ti-bt needs to have a correct PN and PR to be compliant with dnf and so rpm. Bug-AGL: SPEC-920 Change-Id: I1b83ce54340922a23a6f0de5873e48699c2e1101 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-09-29weston-ini-conf.bbappend: Set 720p for Raspberry PiLeon Anavi2-0/+11
Reduce the screen resolution for Raspberry Pi from Full HD to HD Ready (1280x720) to reduce the memory consumption and improve the behaviour of the whole system. This change is applied only for HDMI display on Raspberry Pi due to the limited hardware resources. Bug-AGL: SPEC-1745 Change-Id: Id2fb571b0822f8166086f5ad6a7fcf8ea25c933a Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
2018-09-20linux-firmware_%.bbappend: Avoid rpi file duplicationLeon Anavi1-0/+5
In releases based on Yocto/OE Rocko firmware files for bcm43430 and bcm43455 are provided by linux-firmware-raspbian. This fix avoids duplication of firmware files for Raspberry Pi 3 Model B and B+ while building agl-demo-platform-crosssdk. Bug-AGL: SPEC-1729, SPEC-1652 Change-Id: Ic9e918f4ffd915b148530bb8e6bf9a6dc6a61c02 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
2018-09-18agl_raspberrypi3.inc: WiFi on Raspberry Pi 3 B & B+Leon Anavi5-119/+1
Use linux-firmware-raspbian packages for bcm43430 and bcm43455. Bug-AGL: SPEC-1729, SPEC-1652 Change-Id: Ib634ee3351fa91d8d1704656f4a40d1b40cd05e3 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
2018-09-13Uprev the nogfx machine include to the same stateJan-Simon Möller1-0/+3
as the ordinary m3 build. Change-Id: If07a26f1cb253b9863ea658e6cd122450f03a38b Bug-AGL: SPEC-1640 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-31meta-agl-bsp: meta-ti: amx3-cm3: Add a fix for security_flags.incTom Rini1-0/+3
The way that the PM firmware for these devices is built takes very specific steps to only get the cross-compiler provided by OE and almost nothing else. Unfortunately when we build with the security_flags.inc file in our distro this changes some of the default behavior of the compiler and in turn we need to make sure to disable this and go back to the default behavior. Change-Id: I1ab8e20f77d7ab6a3c786437e9a9422b24f0e159 Bug-AGL: SPEC-1341 Signed-off-by: Tom Rini <trini@konsulko.com>
2018-08-23[Work-around] Update recipe for ImageMagick to avoid bitbake errorTadao Tanikawa1-7/+4
At www.imagemagick.org/download, tarball archives of old patchsets are deleted when a new patchset is created. This causes error when do_fetch(). Offical source repository is in github, so SRC_URI can be set to pull from there. Unfortunately, github repository has tags only after 6.9.5-4. Therefore, updated to the latest stable, 6.9.10-10. For meta-agl/meta-agl-demo, ImageMagick is not mandatory component, but optee inside Renesas BSP requires it (and python-wand). Upstream optee already remove these dependency, so this is just work-around until meta-renesas-rcar-gen3 will be updated. Change-Id: I1767e2d7588a35d75009843312c484d3d63553ae Signed-off-by: Tadao Tanikawa <tanikawa.tadao@jp.panasonic.com>
2018-08-16Add machine templates for qemuarm and qemuarm64Jan-Simon Möller6-1/+67
This changeset adds the necessary tepmlates to build the qemu targets for ARM 32bit and 64bit. The MACHINE names are 'qemuarm' and 'qemuarm64'. As the compiler flags for qemuarm in Yocto are using the equivalent of armv5te, we need to ship our own machine/qemuarm.conf with our default tuning for armv7-a (YP name armv7ve), and overrides to build a v7 kernel and use a v7 capable QEMU machine. For qemuarm64, some additional kernel configuration is enabled to allow building and loading of the MOST drivers. Bug-AGL: SPEC-756 Change-Id: I0a688a1d61a75f1287902fc2733a8a54b0485a34 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org> Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2018-08-15Revert "[rcar-gen3] Disable ipv6"Ronan Le Martret2-7/+2
Bug-AGL: SPEC-490 This reverts commit d88997d1d16897abb83a161c215cbec25d9b5e0f. Change-Id: I7c7a989fb1bf1df1de3c0557792ea4b013fec709 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-08-14linux-firmware: Enable WiFi for Raspberry Pi 3 B+Leon Anavi4-0/+118
Add binary blobs for brcmfmac43455 to enable WiFi for the new Raspberry Pi 3 Model 3 B+. At the moment meta-raspberrypi provides this for latest releases but not for Rocko. This fix should remain in meta-agl until AGL moves to sumo or until we backport the required changes to meta-raspberrypi branch rocko. Bug-AGL: SPEC-1652 Change-Id: I644938ac3799b0e831f022fff9b2bc85aa8fd27c Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
2018-08-14[RCAR] Update URL of R-Car's Evaluation SoftwareRonan Le Martret1-11/+11
New Link: * https://www.renesas.com/us/en/solutions/automotive/rcar-download/rcar-demoboard-2.html Change-Id: I4451bbb8ff151c0ab5af0163e667a170e2a078cb Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-08-08weston.ini: set proper configuration to panel-positionHarunobu Kurokawa1-1/+1
"panel-location" configuration is old. The current weston uses panel-position. Change-Id: Iae50bc72c4ece64effe0b9b5f57e8d5e76057478 Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
2018-08-06Reduce fixed memory split on RPi3Jan-Simon Möller1-1/+1
As it turns out, the driver uses cma and the fixed memory split is only needed at boot time before cma takes over or for the old driver. Thus we can safely reduce it down again as it does not help with the limited cma memory at all. Change-Id: Ibd5da5da931d02777e8d69543ce44e6b536402b1 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-03meta-rcar-gen3: weston-ini-conf: drop v4l2 featureHarunobu Kurokawa2-4/+0
Though R-Car has V4l2 renderer but it is special case. Then it makes no sence to add v4l2 configration into weston.ini file for AGL. Change-Id: Id91be4ce9bcca03126d01e50c587e8d945464f61 Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
2018-08-02We pin on 4.9 linux-ti-staging for now.Jan-Simon Moeller1-0/+1
Revert "linux-ti-staging moved to 4.14" This reverts commit 9e0ff1e9829f3cac0d7a4b90c5456164b8a01b96. Change-Id: I00dc5ce4d249b28b7f9d4e8559aa78a37edbbea3
2018-08-02Remove touchscreen additionJan-Simon Möller1-3/+0
Kernel 4.14 does not ship the dtb anymore, we pin on 4.9 for now. Change-Id: I96228b014dc09efbc7379383b2795a8d4eadf022 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-01meta-agl-bsp/meta-rcar-gen3: modify audio card name on rcar deviceHarunobu Kurokawa1-1/+1
latest sound card name in R-Car Starter Kit is changed "ak4613" from rsnddai0ak4613h, that is described in device tree. Therefore, asound.state file should be updated. Change-Id: I35dc0521da3061eedfa17ba2e28e68ab36353087 Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
2018-07-30Re-add dra7-evm-lcd-lg.dtb as it the screen of the board in CIJan-Simon Möller1-0/+3
Change-Id: I3265c71669124c3ee94be86993d45604356c5735 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-28linux-ti-staging moved to 4.14Jan-Simon Möller1-1/+0
Remove the 4.9 patch queue. Change-Id: Iadd7d4b74085f21f9e487173e9f69ed8969c114b Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-24Bump gpu memory on rpi3Jan-Simon Möller1-1/+1
This gives the gfx core some more head room. Change-Id: Ibff2aa3ed7fac1a3a199fa738cb47982ac56a298 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-24Enable weston to use systemd notifyTadao Tanikawa1-0/+1
Enable weston to use systemd notify to reduce causes of race condition between window manager and homescreen. Bug-AGL: SPEC-1471 Change-Id: I6431b5d52f38b982f6691b2961938664cc4f0544 Signed-off-by: Tadao Tanikawa <tanikawa.tadao@jp.panasonic.com>
2018-07-23linux-renesas: kernel: backport pn533_usb fix from upstreamMatt Ranostay2-0/+146
Backport pn533_usb incorect stack use from linux-next kernel NOTE: this kernel is tracking LTS so at some point it will need to be reverted Bug-AGL: SPEC-1544 Change-Id: I90fd3e0339dfdb148eb01b6ef836353bc2ac6a43 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-18Activate missing kernel options for 4aRonan Le Martret1-0/+4
* without this options the kernel command "make oldconfig" can deactivate SND_ALOOP Change-Id: I132a1109da81aeb470a845e70f2084f57ad47a95 BUG-AGL: SPEC-1591 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-07-12Revert "linux-ti-staging moved on to 4.14"Jan-Simon Moeller1-0/+1
Too early. Need to wait for https://gerrit.automotivelinux.org/gerrit/#/c/15127/ This reverts commit 57fa6f2599942b87af20ae8791eeb40bec5569ef. Change-Id: Ie6eabc56c3b5f4af77c944b5eb15e0d36f719756
2018-07-12linux-ti-staging moved on to 4.14Jan-Simon Möller1-1/+0
Thus remove the linux-agl-4.9.inc. Change-Id: I4d3172a58f4bf3e44201b50c183294356d52a3b0 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-11linux-yocto: kernel: backport pn533_usb fix from upstreamMatt Ranostay2-0/+148
Backport pn533_usb incorect stack use from linux-next kernel Bug-AGL: SPEC-1544 Change-Id: Idc3614f0aedc47a6d69523bf4b8b817b4ed62f55 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-11meta-agl-bsp: linux: add NFC configuration fragmentMatt Ranostay2-0/+37
Add various NFC options to kernel configuration Bug-AGL: SPEC-1554 Change-Id: I94c985421a3b78466d44140ebadcec5c50166212 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-09Fix folder name to use entry in BBFILE_COLLECTIONSJan-Simon Möller6-0/+0
Thus meta-agl-bsp/meta-agl-profile-graphical needs to be meta-agl-bsp/meta-aglprofilegraphical Bug-AGL: SPEC-1552 Change-Id: I9a504a3e6c090ca8a8dea108a11c0394c0a27b14 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-04Fixing DCAN nodes addressesKhouloud Touil2-1/+24
Fix the DT node addresses to match the reg property addresses, which were verified to match the TRM Change-Id: I1ec1d52b48aa2af7d74779bf0eb6f30bc7a4a6cc Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
2018-07-04linux-intel: nfc: backport pn533_usb stack fixMatt Ranostay2-0/+148
pn533_usb based NFC devices wouldn't work on recent x86 builds, and requires a patchset from the upstream kernel Bug-AGL: SPEC-1553 Change-Id: I8113cccd1afc027b80495272bfa8aca42aec7691 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-07-04Set CAN modulesKhouloud Touil1-0/+2
Add the C_CAN and the C_CAN_PLATFORM modules to be built as a kernel modules, those modules supports the Bosch D_CAN and C_CAN peripheral IPs Change-Id: If5657ba12bb5fc5c2ad1e06554a89255fddd4745 Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
2018-07-04Enabling the DCAN2 interfaceKhouloud Touil2-0/+49
Modify the DTS file, to add the proper pinmux for the DCAN2 and enable it Change-Id: I21d233eab71d062484f322e8dd0f16df34f6fe76 Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
2018-07-02kernel: enable 4A-specific config option snd-aloopStephane Desneux2-0/+5
4A requires some specific options in the linux kernel, like CONFIG_SND_ALOOP for softmixer. This patch adds a config fragment to the default linux kernel recipe. This is a copy of what has been done on EE: * https://gerrit.automotivelinux.org/gerrit/#/c/14303/ * https://gerrit.automotivelinux.org/gerrit/#/c/14561/ Change-Id: I5f8879f4ac1b3685f6d801b385d9b0ce9f17f9c7 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-06-28[GEN3 KF] Configure GPS deviceRonan Le Martret3-0/+36
* For the Renesas Gen3 extention board Kingfisher, we must specify the GPS device for gpsd service. * Create a new machine type kingfisher. Bug-AGL: SPEC-1538 Change-Id: If6b7e49f6a006218e57c58e15855e0d65eb849cd Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-06-11[RCARGEN3] Update Renesas Rcar Gen3 BSP to 3.7Ronan Le Martret1-2/+2
Tested with agl-demo-platform image on: * M3+KF * H3+KF Test results: | Component | Status | |---------------------------------------------------------|------------| | Wifi (U52) | ok | | BT HCI (U52) | ok | | BT Audio(U52) | not tested | | USB2.0(host)(CN13) | not tested | | USB2.0(func)(CN13) | not tested | | USB2.0(on-the-go)(CN13) | not tested | | USB3.0(CN2) | fail | | Multichan Audio(SSI3,4) hphone(CN 32,33) lineout(CN12) | not tested | | CSI : Expansion Board (CN10) | not tested | | CSI : Expansion Board (CN11) | not tested | | CSI : Raspberry Pi camera(CN48) | not tested | | Video Input CMOS camera(CN29) | not tested | | HDMI out(CN49) | ok | | LVDS out(CN7) | not tested | | Radio (CN42, 43) | ok | | Gyro, Accel | ok | | GPS (CN16) | ok | | Serial (CN4) | not tested | | CAN(CN17, 18) | ok | | SD (CN47) | fail | | Mini PCIe(CN15) | not tested | | M.2 key M (CN5) | not tested | | MOST (CN22) | not tested | Change-Id: I0779cd6440bf1e8fc958f127aee3c3979da603bb Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-06-06kern-tools-native: fix fragments merging scriptStephane Desneux2-0/+40
When concatenating kernel config fragments, if a fragment file doesn't end with a carriage return, then the last config option of the fragment and the first one of the next fragment are on the same line in the result file. This leads to misconfiguration because some options are not taken into account. This commit includes a patch that will add a \n in the result file after each fragment. Bug-AGL: SPEC-1475 Change-Id: I52d13b42909f56f4608860af865a80d0d9b2579e Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-05-313rd part of the layer/profile rework [1/2]Jan-Simon Möller18-17/+87
This is the last larger commit in this series and deals with the graphical part. We introduce the graphical profiles: - meta-agl-profile-graphical -- meta-agl-profile-graphical-html5 -- meta-agl-profile-graphical-qt5 Notable changes: - weston-ini-conf moved to the meta-agl-bsp layer. Most BSPs have bbappends, so we need to have the recipes present (but unused) even in the console images. - new image: agl-image-boot = terminal-only + network + package-manaager. Ready for using package-feeds - new image/sdk: agl-image-minimal-crosssdk - agl-service-mediaplayer has a dependency on weston, thus it cannot be in the 'core'. Moved it to profile-graphical. - The wayland-ivi-extension moved to the agl-demo-platform. - The app-framework layer included and pulled 'web-runtime' as dependency. This broke console-only images. This has been moved to be in meta-agl-demo only for now. - added and massaged the agl-features. - found and added a useful script 'oe-depends-dot' that helps to work with the dot files (produced with bitbake -g) Todo: - we'll need another pass through the packagegroups. The dependencies for the layers/profiles are now sorted-out but we might have to add/shuffle a few packages. For further details, see meta-agl/docs/profiles.md. v2: fix meta-agl/meta-security/conf/layer.conf - the immediate expansion previously used in there caused some recipes not being added to BBFILES. v3: fix packagegroup renaming (packagegroup-agl-devel -> packagegroup-agl-core-devel) v4: fix missing packagegroup inclusion (tnx Jose, Scott, Stephane) v5: fix missing packagegroup inclusion v6: explicitely put profile-graphical-qt5 on-top of profile-graphical v7: re-add 'procps' when agl-devel feature is on Bug-AGL: SPEC-145 Change-Id: I24cdcd1118932758d0c55d333338238f2a770877 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-05-30Fix kernel .config file configurationRonan Le Martret1-1/+1
* A missing carriage return at the end of a cfg will break the kernel .config Bug-AGL: SPEC-1475 EE-MUST-FIX Change-Id: Ie0bc472153ae73b41c495161f83acba57d812b9a Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-05-28Merge "linux-linaro-qcomlt: delete bbappend of db820c"Jan-Simon Moeller1-3/+0
2018-05-28Merge "dragonboard-410c: update 96boards-tools recipe"Jan-Simon Moeller1-1/+1