summaryrefslogtreecommitdiffstats
path: root/meta-agl-core/recipes-graphics
AgeCommit message (Collapse)AuthorFilesLines
2023-05-08waltham: Drop waltham supportMarius Vlad10-332/+1
Given than we don't really have any users and more importantly no maintainers it would be best to remove Waltham support entirely from the tree. The AGL compositor will shortly follow-up to remove supporting code. Bug-AGL: SPEC-4669 Change-Id: I4df495bb873d70f380dcc09cb083686f11f0b2e2 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28805 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-05-08weston_10.0_aglcore: Add helper iterator to loop over debug scopesMarius Vlad2-1/+91
This is helpful for users to list the available scopes, that other compoments of libweston subscribed to. Bug-AGL: SPEC-4593 Change-Id: Idec02efe997104f6af8164281eee0f2e46f996bf Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28804 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-05-03weston-ini-conf: Add grpc-shell-server to no-activate iniMarius Vlad2-0/+7
This embeddeds the grpc-proxy configuration file into the no-activate configuration file, rather than creating a new no-activate-grpc-proxy, or no-activate-landscape-grpc-proxy. The grpc-proxy.cfg file is just a rename of grpc-server.cfg from meta-agl-demo/ tree, introduced with 1b347d8823, '[weston-ini-conf] Fix dependency issue with grpc in meta-agl-core'. Bug-AGL: SPEC-4776 Change-Id: Ie6183887cdb7b6e3f7cb431f01edb8da75e05946 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Suggested-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28738 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-04-19native-shell-client: update SRCREVScott Murray1-1/+1
Update SRCREV to pick up: c5a05b1 Bump agl-shell protocol version Bug-AGL: SPEC-4735 Change-Id: Iaf48d6ef06d099d8193f0744b2c01428d630e927 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28654 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-03-22agl-compositor_git: Bump SRCREV to latestMarius Vlad1-2/+2
This SRCREV bump updates includes some minor fixes when hot-plugging the connector, and includes set_app_float, set_app_normal and set_app_fullscreen together with an implementation for deactivation of windows using the gRPC API. With this bump we also provide a versioned so libexec_compositor library rather than a generic unversioned one. In detail the following changes have been added: - 4e4624dee9850b4a4e5 grpc-proxy: Add set_app_fullscreen functionality - 9eb8ca6ac7473107ebe shell: Reset normal state when getting back to maximized - 359a0612e48d7d21d52 protocol: Add set_app_normal request - 4af44df30c1784a69b9 protocol, grpc-proxy: Add support for set_app_float - 65fc5191f046ad8c7ba protocol/grpc-proxy: Add deactivate_app request - 28ec0cff16d62260fb1 compositor: Added layout_save/layout_restore - ee50083d93869aaa581 shell: Check for a valid ivi_surface - 02fcb317161c08bcf02 shell: Check for invalid outputs passed on when activating - d98b08f1fcb6ff6ccc7 compositor: Fix memleak when disabling the output - 53a039ff1c4b05aaacc ivi-compositor: Add support for multiple app_ids - ce8dd33f3762e0ec449 meson: Deprecate waltham and inform users of that - 6fd11a88c4d3c82e33b meson: Bump to version 0.0.21 - 4003cfb04b7bae04c32 shell: Reset the area activation Change-Id: I2a2ea18124a825e7e7709aab9c4a4285377a45b0 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28564 Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-02-27[agl-shell-activator] Decouple due to dependency on grpcJan-Simon Moeller2-24/+7
We also need to deal with DEPENDS and agl-shell-activator. The latter is a pure grpc implementation, thus move it to a dynamic layer. Bug-AGL: SPEC-4707 Change-Id: I308104b59333f69dfe416bd3721b11fb7e1b96c4 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28513 Reviewed-by: Denys Dmytriyenko <denys@konsulko.com> Reviewed-by: Marius Vlad <marius.vlad@collabora.com> Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account
2023-02-16[weston-ini-conf] Fix dependency issue with grpc in meta-agl-coreJan-Simon Moeller1-3/+0
grpc is not in the core layer but in meta-oe . Guard the dependency and only enable when prerequisites are met. This also affects weston-ini-conf. We move this into meta-agl-demo. Bug-AGL: SPEC-4707 Change-Id: Ia07cc8e32ac0c38586765985f367dae0cf8c429c Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28510 Reviewed-by: Marius Vlad <marius.vlad@collabora.com> Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account
2023-02-16Fix dependency issue with grpc in meta-agl-coreJan-Simon Moeller1-0/+1
grpc is not in the core layer but in meta-oe . Guard the dependency and only enable when prerequisites are met. Bug-AGL: SPEC-4707 Change-Id: I922a846108ca13d8e6d50e79c3003b0b32a002a7 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28509 Reviewed-by: Marius Vlad <marius.vlad@collabora.com> Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account
2023-02-09weston-ini-conf/core.cfg: Bring in shell-ext-clientMarius Vlad1-0/+3
Rather than messing up the ini file, bring it in from the core configuration file. This allows to start-up the gRPC proxy server at start-up. This is a follow from Revert "weston-ini-conf: Add agl-shell-grpc-server" This reverts commit 2f40613cbf42fd378feea57ccefbb3215ecc1355. Change-Id: I40ab339fe73efb07ac1e86e6778764a553a3cabe Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28441 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Scott Murray <scott.murray@konsulko.com> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-01-29weston-ini-conf: make remote output configuration dynamicScott Murray2-1/+5
Rework things to also update the remote output configuration fragment based on the value of TRANSMITTER_OUTPUT_HOST. This helps when using different IP addresses for e.g. the KVM demo configuration. Bug-AGL: SPEC-4618 Change-Id: I198ff3e6a30b3968b4749998354a39325c088933 Signed-off-by: Scott Murray <scott.murray@konsulko.com> (cherry picked from commit 39def8ebd98c98e67304517ab118f9bde4cdf8e7) Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28415 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-01-26Revert "weston-ini-conf: Add agl-shell-grpc-server"octopus_14.93.0octopus/14.93.014.93.0Jan-Simon Moeller1-2/+0
This reverts commit 2f40613cbf42fd378feea57ccefbb3215ecc1355. Reason for revert: This breaks the runtime with: Jan 25 04:07:51 qemuarm agl-compositor[456]: malformed section header: [shell-client-ext]\ncommand=/usr/lib/agl-compositor/agl-shell-grpc-server\n Jan 25 04:07:51 qemuarm agl-compositor[456]: [04:07:51.432] fatal: error opening or reading config file '/etc/xdg/weston/weston.ini'. Change-Id: I09f74614a9d7ec55550d46224ec1c1b96528eb0b Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28354 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-01-26weston-ini-conf: Add weston-ini-landscape-no-activateRoger Zanoni1-0/+16
This change adds an option to use a weston.ini config in landscape mode with automatic activation disabled by default, to be used by wam. Bug-AGL: SPEC-4647, SPEC-4528 Signed-off-by: Roger Zanoni <rzanoni@igalia.com> Change-Id: Ibaeefc4cae07b3f4cb4bbc619bb068fd259d81fc Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28371 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-01-23weston-ini-conf: Add agl-shell-grpc-serverMarius Vlad1-0/+2
Now that we have gRPC server implementation start the agl-shell-grpc server by default. Change-Id: I1d00b29306f90ababc5277ecb71a101eea1a46ca Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28364 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-01-23agl-shell-activator_git: Bump SRCREVMarius Vlad1-2/+2
This SRCREV bump adds gRPC support and removes agl-shell-desktop support. Change-Id: I946a9563321a6d9b5c756a364726fd3037ba5b63 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28363 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-01-23agl-compositor_git: Bump agl-compositor SRCREVMarius Vlad1-2/+3
This SRCREV bump includes the addition of agl-shell-grpc-server, an interface to agl-shell-desktop protocol, but instead of using wayland connection it uses Google's RPC. For the time being there's only a client using it, and that is agl-shell-activator. The plan is to phase out agl-shell-desktop entirely and use this interface as a way to perform additional window management. Further more this bump also includes a couple of connector hot-plug fixes and renames hide-cursor to disable-cursor entry section to better reflect its name. In more detail the following changes have been added: - 7ef34e0c465a7596 shell: Verify agl-shell version for bound_ok/bound_fail - c01b90ece22cc587 shell: Add fallback agl-shell version 1 - 0907e87f1576f8ad input: Fix minor issue while reporting disable cursor - c9d3edb4ee23a563 input: Rename hide-cursor to disable-cursor - 76fa1b83638310c2 src: Verify if the output is present - 79eac214d4866d84 src: Further hotplug connector fixes - 59375972f5642b7e grpc-proxy: Init gRPC - 0b766cf978b8b100 shell: Not not override the agl_shell interface resources - c42f50b567a0d5ad shell: Add a wrappers for sending events with agl-shell - 05bb0384732480a9 compositor: Allow to start other clients - 14a1292a39377472 agl-shell.xml: Introduce a new interface - 33997a7c96838795 compositor: Handle output destruction deferral Change-Id: I6df1d7fcf6d5d3abcc3c1c2b8a0cf820368a26de Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28318 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2023-01-20weston/0001-simple-touch-Add-maximized-fullscreen: Add maximized/fullscreen ↵Marius Vlad2-1/+138
for simple-touch simple-touch wasn't able to resize itself to max/fullscreen to this patch adds support for that. It is quite useful to have this client test out touch support, so we can re-use it whenever, for instance in the virtio aarch64 machine to test if we have indeed or not a touchscreen device. Upstream-Status: Submitted See: https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1095 Bug-AGL: SPEC-4656 Change-Id: I974b4c5ea8a85f1b3efe4a114f345de948441300 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28314 Tested-by: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-12-10Update cluster network configurationScott Murray3-3/+3
Update configuration files as appropriate with the IVI board as 192.168.10.2 and the cluster as 192.168.10.3. Bug-AGL: SPEC-4632 Change-Id: Idd41daa75fc6258d07d8f654848e78ced85dff35 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28154 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account
2022-12-08libsdl2: PACKAGECONFIG tweaksScott Murray2-0/+4
Add a couple of bbappends for libsdl2 to tweak its PACKAGECONFIG, based on Panasonic QEMU+KVM documentation. Bug-AGL: SPEC-4618 Change-Id: I7ceb4e46faa88f09311ad359a3b0b13a462f6cb2 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28192 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account
2022-11-23weston-ini-conf: add virtio-aarch64 configurationScott Murray1-0/+1
Add a WESTON_DISPLAYS tweak for the virtio-aarch64 machine so the demo platform image gets the required weston configuration when built for it. Bug-AGL: SPEC-4618 Change-Id: I90974a25d51fc3b4ad3d8e9450d98f8ae82f759a Signed-off-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28187 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-11-23native-shell-client: Add recipeScott Murray1-0/+16
Add recipe for native-shell-client simple agl-shell protocol client. It can be used for testing agl-compositor and also enables using it in simple usecases such as displaying the output from guest VMs with QEMU+KVM. Bug-AGL: SPEC-4618 Change-Id: I16b7c8b703b2aa3c875b7ffd78b24021eafd3a7f Signed-off-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28186 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-11-23agl-compositor: RDEPENDS fixesScott Murray1-0/+2
Changes: - Add the required xkeyboard-config RDEPENDS to the agl-compositor recipe to avoid surprises if nothing else that pulls that in is in an image. - Move the agl-compositor RDEPENDS on polkit directly into the recipe instead of getting indirectly via a meta-oe presence driven addition to packagegroup-agl-graphical-weston. This is more correct, avoids surprises if that packagegroup happens to not be used, and will work better with a binary packagefeed. The RDEPENDS is still conditional on the presence of "polkit" in DISTRO_FEATURES, which seems a reasonable alternative to using dynamic-layers. Bug-AGL: SPEC-4619 Change-Id: I595f55a9d598b4a15fe345f50d1a7a203616dd15 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28184 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-11-21agl-compositor: Bump SRCREVScott Murray1-1/+1
Bump agl-compositor SRCREV to pick up: adf173e layout: Allow background surface roles (to) be activated 77d94d8 agl-shell: Add support for defining an activation area Bug-AGL: SPEC-4594 Change-Id: I4d003c4ce26fe3e6b3e3fe07b845538a5a9e508c Signed-off-by: Scott Murray <scott.murray@konsulko.com> Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28181 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account
2022-10-18agl-compositor_git.bb: Bump SRCREVMarius Vlad1-1/+1
This SRCREV bump update brings in a helpful way to designate a certain area such that the compositor would use it when activating applications, rather than using the entire output. When not having panels the background surface would cover the entire output, making it impossible to keep visible areas of the background surface and, in the same time, display another's application surface. While the solution would be use panels specifically designed to handle this case, that's not always possible. We circumvent that by having this area specified manually in this update, with a direct follow-up to have a request in the agl-shell protocol that specifies that area programmatically. Besides that change, a few more changes made it through, all of them being added from upstream and adapted from weston to the AGL compositor, mostly related to how we handle signals. In detail the following changes made it through since the last SRCREV bump update: - 924473ef016b Add manual activation area configuration option - 897449688a9c compositor: Use sigaction to trap SIGINT - e8761762fcd0 compositor: Add missing SIGCHLD handler - 315496ddbb9f compositor: Stop trapping SIGQUIT - f980c0d90329 shell: Rewrite client_exec as client_launch - edb6d397a4c6 process-util: Move Xwayland fork helpers to shared - 86146a4e7455 shared: add str_printf() - 1b93121761e1 shared: introduce os_fd_clear_cloexec() Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I23e0aba9f2b77cab4fe81754a8feaeebb7cea340 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28056 ci-image-build: Jenkins Job builder account Tested-by: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-09-25weston-ini-conf.bb: Change from append to an inline editMarius Vlad1-2/+1
We don't really support section entries with the same name, so rather than appending a new key entry value under the same section, use sed to edit the configuration file in place. Fixes 6a8a33f99a66ae1 Bug-AGL: SPEC-4528 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I12b982dd7e6dd8d11e5fb373c8cba0b1e762c485 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28019 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-09-22weston-ini-conf: Add weston-ini-config-no-activateMarius Vlad1-0/+16
This patch adds a way to tick dynamically activate-by-default to false, and provide a safe migration towards disabling by default activation entirely. We do this with just only the Qt toolkit and will proceed with WAM/chromium once that has support as well for this. Bug-AGL: SPEC-4528 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I3573ea92d3ea865db223bd01e58b9ec202cfa7ae Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27990 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-09-22agl-compositor_git.bb: Bump SRCREV to grab latest changesMarius Vlad1-1/+1
This SRCREV bump update for the AGL compositor includes two new protocol updates, one that adds two new events, specifically bound_ok, bound_fail which would allow clients to determine if they're in charge of managing panels and background surfaces. The other protocol update fixes an issue with activation by default of applications but also paves the way to move out bits from the agl-shell-desktop protocol to just the agl-shell protocol. Note that the shell client supporting the latest change of the protocol will need to add at least add stubs for the v2 of the protocol, even if v2 isn't required to be supported at all. Updates to version 3 of the protocol will be required once we'll switch out from activation by default from true to false and finally remove support from the compositor entirely and let the shell client be the one in charge for activation. Additionally, this bump includes a few fixes, most notable handling remote surface roles much better, including migration, in real time of applications from one output to another, making possible a back-and-forth movement of applications. In more detail the following changes have been included: - d08a5b2010f6e6 desktop: Do not attempt to send terminate event - 0512e7251611e7 protocol/agl-shell.xml: Add an app_state event -- app state notification - bb730ca304a5f6 layout: Handle dynamic application/surface movement between outputs - b92397ef12626a shell: Remove the black curtain installed on outputs - 372eb222b17bbc layout: Detect when an application should be migrated to other outputs - 39c91d5ccae3b6 desktop: Avoid sending the dimensions for the first output - a99d56dad0ad4a layout: State explicity the output - fc783c19e6f6b9 layout: Use view's mapping once we placed the view in the hidden layer - e1b15f95e834ac desktop: Install a black background for REMOTE roles - bb79d12c92fa6e desktop: Include REMOTE role in initial configuration - 3e72564852a6f3 agl-shell: Add bound_ok and bound_fail events and a default destructor Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I25c53e9d69270651cd40c7ee9ec3edce28f899a6 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27989 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-09-01weston_10.0_aglcore.inc: Update wl_output to version 4Marius Vlad2-1/+118
This allows clients to query the output name and description name as seen by the compositor. Previously this was only possible only with xdg_output_manager extension but a recent update to the core wayland protocol allows us to do just that. Patch is posted upstream https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/987, but will take some time to get in, as we're in the process of a release. Bug-AGL: SPEC-4530 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I709b941a220e9906078944ee585435df7141d448 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27949 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-09-01recipes-graphics/wayland/weston: Add tile orientation statesMarius Vlad2-0/+170
This was recently integrated into libweston 11 pre-release, and should be removed once yocto updates its libweston version to at least 11. For the time being we'll rely on these to have split type of windows. Bug-AGL: SPEC-3906 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I7bc5caa6126d36d843d0f00cde56c020fa3f97dc Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27906 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-08-04Add empty for append syntaxChanghyeok Bae1-1/+1
Signed-off-by: Changhyeok Bae <changhyeok.bae@gmail.com> Change-Id: I3a67f2dca0148be04d96e5261a4bef4030e93fbf Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27852 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-07-29Fix a dependency issue when building the SDKJan-Simon Moeller1-0/+4
When using -c populate_sdk, then the -dev packages are installed. There is a hard dependency of the -dev package on the package. As we have multiple subtypes here and switch using ALTERNATIVES, this collides in this corner case. Fix it by not creating a -dev package in the first place as it is not needed here anyway. Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Change-Id: I21326c9edc5cb7571ed94593eae1075cf56353db Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27841 Reviewed-by: Scott Murray <scott.murray@konsulko.com> Reviewed-by: Marius Vlad <marius.vlad@collabora.com> Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account
2022-07-11agl-compositor_git: Bump SRCREV for AGL compositorMarius Vlad1-1/+1
Most notable in this this bump update, is the ability to receive focus (xdg-shell and input) even though there isn't any keyboard attached in the system. More than that, this update also includes a few fixes related to remote apps placement to different outputs and a fix on how we activate by default applications, in various circumstances. Specifically, this AGL compositor bump includes the following changes: - 2cc479fd8f3e53265 layout: Add a wrapper for adding the view to the hidden layer - baf8a28e6329fdb6c shell: Fix a typo when adding surface to pending list - 1797ef75adcb4c586 compositor: Allow passing continue-without-input - c859ca5a97d53a00c shell: Make sure that app_id is valid before checking it - 89440e0ffdfea2568 layout: Keep track of popup state to handle activation - 89f67c5cf793bc69c compositor: Perform activation from keybindings - 8cc1032b2f5542028 compositor: Pass flags when adding keybindgs - 9cccfe829aab45fd2 layout: Add a way common way activate views - 394b5da7676612600 shell: Extract some common functions - cac00851d454fcfe6 input: Migrate ivi_seat to ivi_compositor header - 2844fde1df83707f3 input: Remove keyboard listener keyboard focus activation - b4a52c732dbf3863b compositor: Properly dispose of fullscreen views at shutdown Bug-AGL: SPEC-2982 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I83fd9513114a6ffd4cb98a8506063544ccce377a Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27696 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-06-17weston: Delete four patches that are no longer usedduerpei4-320/+0
The following four patches are submitted in https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27257 to fix a potential memory leak problem. Now that Weston has been updated to 10.0, the original memory leak problem has been solved, and the following four patches are no longer required Bug-AGL: SPEC-4438 Signed-off-by: duerpei <duep.fnst@fujitsu.com> Change-Id: Ibe4191a2a902ddac9f9a32d4f6239ae5761894a4 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27665 Reviewed-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jenkins Job builder account
2022-05-26agl-shell-activator: Bump SRCREVMarius Vlad1-1/+1
A bug-fixing update, includes the following changes: - 0b21156c3b4f0493 Fix compilation error due to missing wl_output_listener fields initializers. - 22f8d43e58594012 Fix no reaction to 'Ctrl+C'. - 6ebbb41822da663b Remove unneeded wl_display_flush. Bug-AGL: SPEC-4324 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ieb68a256f891af5507e261a46e2e645ea5bf0608 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27484 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-05-16agl-compositor_git: Bump up SRCREVMarius Vlad1-1/+1
This SRCREV bump is a bug-fixing update: includes some fixes with fullscreen surface roles, uses libweston's _fini calls to verify and check-up and if cleaned up correctly when shutting down the compositor, and finally, does some minor clean-ups. Specifically, the following changes have been added since the last update: - 1304d412eb2bcefd4 shell: Do not set none role for applications w/o appid - 43bdf9a42bac33df1 shell: Let the output destroy handler handle layer fini - a89fbd6702dd82c4b desktop: Document the repaint schedule - 5274f6ea9da2f119f Revert "desktop: No need to schedule a compositor repaint" - 71deafe03f41738bf shell: Added missing layer fini calls - 41791c9fa1839e93a compositor: Proper indentation - 40f5e3bbfac73375b desktop: Remove dead code - 8f85581e96bc71512 desktop: No need to schedule a compositor repaint - c40f46aa4d2644b18 meson.build: Bump up meson version - 7a7b46bd7040b2814 layout: Inform client to resize for fullscreen roles - 13ac8bab43fffd002 layout: Send dimensions when setting up property as fullscreen - 2cd345013ccaaccd7 layout: Do perform a view update transform when unmapped - b13e185e7214218ca layout: Make the view mapped at activation completion - 7ecc8c2ee8a776bb1 compositor: Rename activated_by_default to mapped Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I3f5735fad1ea99fa6ce388fbb73796436f956bf6 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27450 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-05-03agl-shell-activator_git.bb: Update agl-shell-activatorMarius Vlad1-3/+3
Bumps agl-shell-activator to include the following changes: - b1006c97511b6e6ed script/agl-activator: No need for the script - 69bda7298f3ee3199 main: Handle agl-shell-desktop events - 81f41152446b315b7 meson.build: Update compositor protocols version Bug-AGL: SPEC-4324 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I46b7470f7731eaa83cf0dc0ef6e722d0124a8c82 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27384 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-05-02meta-agl-core: switch next branch users back to masterScott Murray2-2/+2
Remove the aglnext override that was added on the next branch to switch the couple of affected libweston users (agl-compositor and waltham-transmitter-plugin) to forked next branches for handling Weston 9.0 and 10.0 changes. Now that those changes have been merged to the master branches in the respective repositories, this is no longer required. As well, bump the SRCREVs to pick up the Weston update changes. Bug-AGL: SPEC-4343 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: I7a4598a9e776aefa3ec7b2bf13b2e89c086c0681 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27418
2022-03-30meta-agl-core: remove weston-init backportScott Murray4-142/+0
Remove backport of weston-init changes done for Marlin release, they are not required with post-hardknott releases of Yocto. Bug-AGL: SPEC-3819 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: I81e32fa082df174b3a8a705ac51085176bddb4b8
2022-03-29meta-agl-core: use next branch for weston dependent packagesScott Murray2-0/+4
Add a "aglnext" OVERRIDE in the distro configuration, and use it to select the "next" branches in the agl-compositor and waltham-transmitter-plugin recipes, and use AUTOREV for their SRCREV. The latter will allow rebasing the next branches in those repositories as next branch updates occur without requiring SRCREV updates every time. Bug-AGL: SPEC-3819 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: I4f2a57fface53374d9428b5af1c6ad02edfde7eb
2022-03-29meta-agl-core: update weston-ini-confScott Murray8-9/+14
Update weston-ini-conf recipe to handle weston 9.0 in poky master. The changes are to handle the flip of the meaning of 90 and 270 degree rotations in the transform option in weston.ini, and the rename of its values to "rotate-X" instead of just the number of degrees. Bug-AGL: SPEC-3819 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: I2bb316a195f7eb3733ff757a565535317db1da08
2022-03-29meta-agl-core: update westonScott Murray9-340/+11
Update weston bbappend for weston 10.0 in poky master, and remove now upstreamed patches. Bug-AGL: SPEC-3819 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: I5d10435ec9b7c18bb36e8a88f6853f1628e5b052
2022-03-18wayland/agl-compositor_git.bb: Bump SRCREVMarius Vlad1-1/+1
Another bump update for agl-compositor, addresses a small issue found while using the cursor + some left-overs which have been added with the previous update. Since the last SRCREV update, the following changes has been added: - cec4cf8fe409c layout: Address all other callsites w/ dirty+surface damage - 62e020b90b062 layout: Inflict surface damage - b06ffcc3ca1ed layout: Remove left-over comment - f24765124d3a5 Fix potential memory leak - 9cc8100eef72b meson.build: Don't set the dependency type for wayland-scanner - 26c37c4140ce5 Fix potential memory leak Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Id2ba7019777da1c06fdecec5a174c8bfeae1a7f3 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27252 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-03-18Fix potential memory leak of two pointers (xwayland and client)duerpei5-0/+324
This backports four patches from weston to solve a memory leak problem These four patches are: https://gitlab.freedesktop.org/wayland/weston/-/commit/5a6604a7a2e52e5cd84c1f53724b3f7c325b5dff.patch https://gitlab.freedesktop.org/wayland/weston/-/commit/f53c05d3c2c19c139c52e9bd621c2654dd3dac69.patch https://gitlab.freedesktop.org/wayland/weston/-/commit/e2583ca0844bd7a8ce4fc94da9ad67edf49ffd45.patch https://gitlab.freedesktop.org/wayland/weston/-/commit/8740037a93c7c4400cc381ecf3009d1e4014be07.patch The following is the valgrind log: 160 bytes in 1 blocks are definitely lost in loss record 39 of 66 at 0x484B64C: calloc (in /usr/lib/valgrind/vgpreload_memcheck-arm64-linux.so) by 0x4A73C87: ??? (in /usr/lib/libweston-desktop-8.so.0.0.0) by 0x4A7184F: weston_desktop_create (in /usr/lib/libweston-desktop-8.so.0.0.0) by 0x487096B: ivi_desktop_init (in /usr/lib/agl-compositor/libexec_compositor.so.0.0.0) by 0x486F5E7: wet_main (in /usr/lib/agl-compositor/libexec_compositor.so.0.0.0) by 0x48B010F: (below main) (in /lib/libc-2.31.so) In agl-compositor/src/composiotr.c "ivi->desktop->compositor->xwayland" is zalloced by wet_main()->ivi_desktop_init()->weston_desktop_create()->weston_desktop_xwayland_init() "ivi->desktop->compositor->xwayland->client" is zalloced by wet_main()->ivi_desktop_init()->weston_desktop_create()->weston_desktop_xwayland_init()->weston_desktop_client_create() "ivi->desktop->compositor->xwayland" and "ivi->desktop->compositor->xwayland->client" The memory pointed to has not been released Now, I want to free the memory pointed by the two pointers. What can do this is the function of weston_desktop_xwayland_fini() in 0003-libweston-desktop-add-weston_desktop_xwayland_fini.patch And the submission of this patch depends on the first three patches, so I submitted these four patches. Bug-AGL: SPEC-4291 Signed-off-by: duerpei <duep.fnst@fujitsu.com> Change-Id: I3b1140e88eadad9e378c2bb43221026e280ecd90 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27257 Reviewed-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jenkins Job builder account
2022-03-05Fix potential memory leakmarlin_12.93.0marlin/12.93.012.93.0duerpei2-0/+35
Bug-AGL：SPEC-4259 Signed-off-by: duerpei <duep.fnst@fujitsu.com> Change-Id: I4be57103eee67d64893baccf878d2dbebd1f9cf5 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27219 Reviewed-by: Marius Vlad <marius.vlad@collabora.com> Reviewed-by: Naoto YAMAGUCHI <naoto.yamaguchi@aisin.co.jp> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account
2022-01-19meta-agl-core/recipes-graphics/wayland: Backport two fixes for libweston-8Marius Vlad3-0/+86
This backports two small fixes for some potential libweston crashes happening on the DRM backend tear down, or EGL initailization failure paths. Bug-AGL: SPEC-4197 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Reported-by: Scott Murray <scott.murray@konsulko.com> Change-Id: Idc28bb7ef6d8fde8c149bb5eb35a2ba40a25706a Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27068 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Scott Murray <scott.murray@konsulko.com> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-01-19recipes-graphics/wayland/agl-compositor_git.bb: Do another SRCREV bumpMarius Vlad1-1/+1
As it seems I've broken the screenshoter for single ouputs, this bump is necessary to get it working again in CI. Specifically this bump includes the following changes: - 2ee86feebc8888d client/screenshooter: Compute the width/height for a single output - 838df78fe94e5bb agl-compositor: Add NULL check after creating surface/view Bug-AGL: SPEC-4217 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: If5ad858d2e9aed9f8fc074f7240b54334267538c Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27083 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-01-17weston_8.0_aglcore.inc: Set-up app_id for toytoolkit appsMarius Vlad2-0/+86
Necessary to allow weston-terminal to be able to set-up an app_id. Bug-AGL: SPEC-4218 Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: I221ed0160d33136b0fd51ce9eb1277b0ce21b815 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27085 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Scott Murray <scott.murray@konsulko.com> Reviewed-by: Arnaud Ferraris <arnaud.ferraris@collabora.com> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2022-01-12recipes-graphics/wayland/agl-compositor_git: Bump agl-compositor SRCVREVMarius Vlad1-1/+1
The most notable change is an update in the agl-shell protocol and with a version increase. A few other bug-fixes have also made it. Specifically, since the previous update the following changes have added: - 471a12ee38098aaa agl-compositor:Add NULL check after zalloc in src directory - 18918978ba5c0f91 agl-compositor:Add NULL check after zalloc in screenshooter.c - 6371b14eb0abbb23 agl-compositor: Correct several spell issues in the protocol xml files - 53046f8863e0320d agl-compositor: Correct several spell or grammar issues in the README.md file. - fd4708c898aafc58 layout: Remove explicit damage call - d456a0c59a316f8f layout: Inflict damage on all subsurfaces - c0bc469e505b91e0 meson.build: Bump compositor version - 9e9c768ad6360ef5 shell: Refactor pending surfaces for existing pending ones - 6d4038380b39f204 src/desktop: Add a compositor destroy listener - 5101851ecb304e75 src/shell: Add set_app_property_mode request - e4f4aef1a5b1feb9 layout: Fix-up the positions when placing the pop-up/dialog - 52df92d73985dba8 shell: Fix passing maximized state from the start - b25020f9a5055c4c meson.build: Add a waltham-transmitter pkg-config pc file - e5016cbc47b46b86 meson.build: Conditionally build with headless support - d6f64b665a39e0bd meson.build: Clarify out-of-tree build error - 5b8d4c56e7d793cf clients/screenshooter: Fix taking screenshot on multiple outputs Note that with this bump update, starting with `c0bc469e505b91e0 meson.build: Bump compositor version` all clients using the agl-shell protocol will have to be updated to use agl-compositor-protocols-0.0.20 version. Signed-off-by: Marius Vlad <marius.vlad@collabora.com> Change-Id: Ica7bb61f16664fb74f051fd7bf2e61120cb1dba7 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27074 ci-image-build: Jenkins Job builder account Tested-by: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Scott Murray <scott.murray@konsulko.com> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2021-12-08weston: allow weston to be started from a systemd user sessionArnaud Ferraris2-0/+76
As part of the App FW rework, we want weston to be started from a systemd user session, which is allowed by this patch (backported from upstream). Bug-AGL: SPEC-4161 Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com> Change-Id: I23961eaebb65bdbdcfd8c3d01ff1941f978385ec Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/26968 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Scott Murray <scott.murray@konsulko.com> Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2021-11-18Fix a couple of override syntax issuesScott Murray1-4/+4
Fix a couple of spots where use of the old-style override syntax has accidentally been added. Bug-AGL: SPEC-4052 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: I7f4d5b0ba0bf813f3e72b783e30cadc5ba0e030d Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/26874 Tested-by: Jenkins Job builder account ci-image-build: Jenkins Job builder account ci-image-boot-test: Jenkins Job builder account Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2021-11-04meta-agl-core: Update weston/agl-compositor initScott Murray7-1/+189
Changes/rework to get weston and agl-compositor starting again: - Since an upgrade to a newer Yocto release is in the near future, update weston-init and associated files to effectively backport the new weston startup behavior added in 3.3/Hardknott as our new base. The changes mean weston or agl-compositor will by default start as a "weston" user that replaces the "display" user that had been added previously in AGL. The goal is that any new work done on top of this base should hopefully work on 3.5/Kirkstone without further substantial rework. - Add new agl-compositor-init recipe that replaces the previous weston-init bbappend in meta-agl-demo. Having it as a separate recipe in core so weston or agl-compositor "just work" in simple test images seems like a better approach. - As part of the above, drop the --log option to agl-compositor in its command-line to address SPEC-4112. - Add SYSTEMD_DEFAULT_TARGET definition to agl-image-weston and in a new core-image-weston bbappend to result in agl-compositor and weston starting automatically in the corresponding images. This is required with the new weston-init behavior until we upgrade past 3.3/Hardknott, when "weston" in IMAGE_FEATURES can be used instead. Bug-AGL: SPEC-4121, SPEC-4112 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: Ia64894416846569abf8e744006ef26637279a895 Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/26782 Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Tested-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>