summaryrefslogtreecommitdiffstats
path: root/meta-agl-distro/conf/distro/poky-agl.conf
AgeCommit message (Collapse)AuthorFilesLines
2019-11-17Cut HH 8.0.3 releasehalibut_8.0.3halibut/8.0.38.0.3Jan-Simon Moeller1-3/+3
bump the distro config file. . Change-Id: I002fcf9fa25d52e71f0bbb21a3e90984390eda20 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2019-10-16Post 8.0.2 bump of the distro configurationJan-Simon Moeller1-2/+2
Bug-AGL: SPEC-2859 . Change-Id: Idf2c6c6a216c9239aeacdb2c50f38d11d3b1055a Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2019-10-06Change distro config for HH 8.0.2halibut_8.0.2halibut/8.0.28.0.2Jan-Simon Möller1-3/+3
Bug-AGL: SPEC-2859 Change-Id: If9a5a32c42b8d1e6f39ff39f6b737608571b5f7f Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-09-10Post 8.0.1 release bump of distro configJan-Simon Moeller1-2/+2
Development is open for 8.0.2. Change-Id: Ib9723af707b5713e8f6bb6776f3450b518c4b8b9 Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2019-09-04Prepare Happy Halibut v8.0.1 patch releasehalibut_8.0.1halibut/8.0.18.0.1Jan-Simon Moeller1-1/+1
Change the distro configuration. Change-Id: I4ea995a2b8504b30117dc514f55cc18b84bd116b Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
2019-07-30Bump the distro config for HH 8.0.0Jan-Simon Möller1-1/+1
Bump the distro config to match 8.0.0 Bug-AGL: SPEC-2700 Change-Id: I9e0d93cba8aa82595d71f0025790065cc95775cd Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-07-25Change AGL_BRANCH to halibutJan-Simon Möller1-1/+1
Release branches are created. Now use the new branches. Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org> Change-Id: I263ed30f347648a462c2bb4180e5a1faa7402b7d
2019-07-13Prepare Happy Halibut rc3 v7.99.3halibut_7.99.3halibut/7.99.37.99.3Jan-Simon Möller1-3/+3
Bump the AGLVERSION and the AGLRELEASETYPE. Change-Id: Ia2744798f717c59c28de520220a16d5d13e1a7cf Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-07-09Flip distro config post rc2Jan-Simon Möller1-2/+2
Change the distro config to post-RC2 . Change-Id: I5135ab220d2b38a5fa049661f2346eed010648a5 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-07-07Change the AGL mirror setup following the server changeJan-Simon Möller1-11/+22
The download server is currently http only. Add a fallback option to the MIRRORS in the distro configuration. Change-Id: Ic5403d921463a4f6aea813a150950c0d023aa77d Bug-AGL: SPEC-2604 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-07-01Prepare Happy Halibut rc2 releasehalibut_7.99.2halibut/7.99.27.99.2Jan-Simon Möller1-3/+3
Change the distro configuration in preparation of HH rc2. Change-Id: I6ca53cb2a2981c1c63133efd6d0222ede64f09f8 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-06-11Post HH rc1 bump of distro configbuild.automotivelinux.org1-2/+2
Once we release rc1, the window for rc2 is open again. Change-Id: Ic03710be9c8364d08ce8628e434c26388f3e39f2 Signed-off-by: build.automotivelinux.org <jenkins@automotivelinux.org>
2019-06-01Prepare HH RC1 releasehalibut_7.99.1halibut/7.99.17.99.1Jan-Simon Möller1-3/+3
Bump the distro configuration. Change-Id: Icb7ac269a6b8cdd74f2b2d1d4a85d51202c9225e Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-04-14Change the navigation application default to the new navigation applicationJan-Simon Möller1-0/+3
Now that the new navigation application is ready, change the default navigation application. This replaces https://gerrit.automotivelinux.org/gerrit/#/c/19831/ . Change-Id: Iac516672087d231d5ea0b43764ce12e3d3c20580 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-04-04Upgrade to thudScott Murray1-35/+8
Changes include: - Add LAYERSERIES_COMPAT definitions to layer.conf files - Remove now unnecessary SECURITY_*FLAGS over-rides from distro configuration - Set intel-corei7-64 preferred kernel version to 4.19 to match latest linux-intel kernel available in meta-intel - Update qemuarm preferred kernel version to 4.18 to match latest linux-yocto - Update firmware package and devicetree file names for raspberrypi3 - Remove linux-firmware bbappend specific to raspberrypi, it seems no longer required and breaks the cross SDK build - Update linux-intel bbappend to 4.19, remove now unnecessary patch - Remove now unnecessary lttng-modules backport - Update linux-raspberrypi bbappend to 4.14 kernel - Added kernel configuration fragment for raspberrypi to disable Kprobes. This is required until linux-raspberrypi is updated to greater than 4.14.104 to avoid a build failure in lttng-modules related to a check for known breakage in the kernel CONFIG_OPTPROBES code. - Replace obsolete base_conditional usage with oe.utils.conditional - Add gstreamer1.0-plugins-bad bbappend for raspberrypi3 to disable faad PACKAGECONFIG to avoid commercial license issues - Remove unused and unbuildable Vayu gstreamer recipes - Update linux-ti-staging bbappend for new BSP kernel - Regen dcan2_pinmux_enable.patch for linux-ti-staging to remove fuzz warning, and remove upstreamed fix_dcan_addresses.patch - Remove ipumm-fw from meta-agl-bsp/meta-ti, as newer version is available in the upstream BSP - Update meta-agl-bsp/meta-ti weston patch to apply against 5.0.0 - Update meta-agl-bsp/meta-ti wayland-ivi-extension patch to apply against 2.2.0 - Add ti-sgx-ddk-km patch to add AGL toolchain configuration file - Remove now unnecessary fdtoverlay recipe - Update core.cfg and ivishell.cfg in weston-ini-conf recipe to handle move of ivi-controller.so configuration in Weston 5.0.0 - Update connman-ncurses patch to remove fuzz warning - Add installation of systemd over-ride file for run-postinsts.service in run-postinsts bbappend to workaround race condition between ldconfig.service and the /sbin/ldconfig invocations in the post-install scripts run by run-postinsts.service. The observed failure was cynara's post-install script failing and its database not being created. - Remove now unnecessary valgrind backport - Add patches to fix most driver compilation against newer kernels - Update libmicrohttpd bbappend - Remove libssp-dev from agl-image-graphical-qt5-crosssdk and agl-demo-platform-html5-crosssdk, upstream have removed it from non-mingw32 platform SDKs - Update wayland-ivi-extension recipe to build 2.2.0, and update local patches - Update weston patches for 5.0.0. Patches: 0016-ivi-shell_add_screen_remove_layer_api.patch 0017-ivi-shell-register-ivi_layout_interface.patch have been removed as they have been applied upstream and are no longer necessary. Patches: 0018-compositor-add-output-type-to-weston_output.patch 0019-compositor-drm-introduce-drm_get_dmafd_from_view.patch (both related to Waltham) have been disabled for now as they need significant rework. - Remove weston-conf RRECOMMENDS in weston bbappend to avoid conflict with weston-ini-conf - Add OECMAKE_GENERATOR = "Unix Makefiles" to aglwgt.bbclass to work around CMake+ninja issue in cmake-apps-module - Update dbus cynara patches for 1.12.10 - Add do_install_append in cynara recipe to remove /var/cynara from cynara package so the directory creation and labelling in the post-install scriptlet will function as intended - Remove now unnecessary e2fsprogs backport - Remove now unnecessary libcap-ng backport - Update pulseaudio patches to remove fuzz warnings - Update neardal patch to remove fuzz warning - Update freetype patch to remove fuzz warning - Rename opencv bbappend to 3.% to handle 3.x backports in upstream - Updated qtwayland patch to remove fuzz warning Changes from Stephane Desneux <stephane.desneux@iot.bzh>: - Remove wayland-ivi-extension PREFERRED_VERSION - Remove now unnecessary nativesdk-cmake patch - Remove now unnecessary ptest-runner patches - Remove now unnecessary harfbuzz patches - Disable waltham-transmitter as it does not build against weston 5.0.0 - Update af-main, cynara, and security-manager to use pkg_postinst_ontarget - Bump connman-ncurses revision to avoid deprecated ncurses functions - Update libva package usage with new intel-vaapi-driver name - Add patches to security-manager to fix compilation with gcc8 - Updated systemd bbappend Changes from Jan-Simon Möller <jsmoeller@linuxfoundation.org>: - Remove meta-agl-bsp/ROCKO.FIXMEs - Remove linux-yocto_4.12.bbappend and now unnecessary associated patch - Remove now unneeded kern-tools-native patch - Bump gstreamer PREFERRED_VERSIONs to 1.14.x - Remove latencytop from packagegroup-agl-core-devel, it has been dropped by upstream - Remove now unnecessary rpm patches - Update pulseaudio bbappend to 12.2 - Update opencv bbappend to 3.4 - Update freetype bbappend to 2.9.1 - Update dbus bbappend to 1.12.10 - Update weston bbappend to 5.0.0 - Update cynara patches to remove fuzz warnings - Add patch to cynara to fix compilation with gcc8 - Add xmlsec1 bbappend to clear EXTRA_OECONF to fix compilation on sumo or newer Changes from Ronan Le Martet <ronan.lemartet@iot.bzh>: - Update meta-rcar-gen3-adas layer gstreamer1.0-plugin-vspfilter bbappend to version 1.0.1 Known issues (marked with FIXME): - CMake+ninja issue in cmake-apps-module has been worked around with OECMAKE_GENERATOR - waltham-transmitter and the patches to weston related to it have been disabled - Currently unclear if patch to libcap-native is actually required or not Bug-AGL: SPEC-1837 Change-Id: I7b8b9ef667aec2d229952eace6663dfc761654d0 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-02-08Change master branch to Happy Halibuthalibut_7.90.0halibut/7.90.07.90.0Jan-Simon Möller1-2/+2
The next AGL version will be updated to use YP 2.6 'thud' and have the nickname 'Happy Halibut'. Change-Id: I9fc47eeebf268361fe0c2fb2659cff28a65dfb40 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-02-05meta-agl-distro: poky-agl: add 3g to AGL_DISTRO_FEATURESMatt Ranostay1-1/+1
To enable WWAN support for AGL add 3g to AGL_DISTRO_FEATURES Change-Id: Ib43344a6b6796afe19296fee14fddb5b2b23636a Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-01-20Post-release bumpJan-Simon Möller1-2/+2
Change-Id: I5883f78b91740ffc06f77dba1fed6c33218370d9 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-01-19Cut GG rc4 v6.99.4guppy_6.99.4guppy/6.99.46.99.4Jan-Simon Möller1-3/+3
Cut the rc4 of guppy. Change-Id: I29803ddf028d6c46cb300d03f31fe2ade9931add Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-01-06Post rc3 bump of distro configStephane Desneux1-2/+2
we're heading towards rc4 now. Change-Id: I06afbe8fd76a4d7eaf8a72353eae0363ee8f8a53 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2018-12-27Update distro configuration for GG rc3 6.99.3guppy_6.99.3guppy/6.99.36.99.3Jan-Simon Möller1-3/+3
We cut GG rc3 after the CES integration session. Notable changes: - Microphones working - Bluetooth -- A2DP in mediaplayer -- HFP (one call due to pending bug) - Mediaplayer and Radio ramping (radio lower prio) - btwilink disabled on kingfisher (unstable) - agl-demo-preload feature (load maps, POI api key, ...) - nfc improvements Change-Id: I978dd02a0b4d5aefcfc0d7d46287b27bc1f1d396 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-12-09Post rc2 bump of distro configJan-Simon Möller1-2/+2
we're heading towards rc3 now. Change-Id: I294f40e5c6f779a6ee7db984c2d475e9e230f54d Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-11-30Prepare 6.99.2 Guppy RC2guppy_6.99.2guppy/6.99.26.99.2Jan-Simon Möller1-3/+3
Change the distro configuration in preparation of GG RC2. Change-Id: I2eb05adf8f4f909d90aed81b75ba04a0933ae02e Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-11-26Post-RC1 bumpJan-Simon Möller1-2/+2
Change-Id: I39ef7dc1023c80ca313ad80d5bd10df0c4fbe0c9 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-11-15Prepare Grumpy Guppy RC1Jan-Simon Möller1-3/+3
Modify the distro config to reflect the RC1 release. Change-Id: If46096e12c0917ee517835e5803ec32b80a6a37a Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-10-08Fix optee-client buildRonan Le Martret1-0/+1
optee-client fails to compile when enabling FORTIFY_SOURCE=2 option. Change-Id: I4e4a5fea098470f63a3d8b49b9bb4fc8b8c0bbbc Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-10-02Remove pulseaudio from AGL DISTRO_FEATURESRonan Le Martret1-1/+1
Bug-AGL: SPEC-1601 Change-Id: I5f6f82dad72cb5f1570c6354d360cebd056489a1 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-09-28Change SDKPATH for something more stable in timeRonan Le Martret1-1/+1
* The SDKPATH must be fix to be used with YoMo. Inside rpm nativesdk file all the path is prefed by SDKPATH/sysroots/${HOSTARCH}-${SDK_VENDOR}-${OSHOST}/ * have a (day) time stamp in ${DISTRO_VERSION} force the rebuild of the package every day. eg: At runtime /etc becomes: (old value): /opt/agl-sdk/6.90.0+snapshot-20180921-aarch64/sysroots/x86_64-aglsdk-linux/etc (new value): /opt/agl-sdk/6.90.0+snapshot-aarch64/sysroots/x86_64-aglsdk-linux/etc in native sdk Bug-AGL: SPEC-921 Bug-AGL: SPEC-1667 Change-Id: I28d7f8d140ba75d9d8c68c84ba5fc697e6011836 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-09-12Move master to guppyJan-Simon Möller1-5/+5
We move master to guppy and development. Change-Id: If6fc9f1e89298f604e94055b75362df7a7cbdde0 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-09-09Prepare Flounder rc6flounder_5.99.6flounder/5.99.65.99.6Jan-Simon Möller1-3/+3
Change the distro config for the RC6. Change-Id: I174d28086f7b9de8d94840f7451b65f8ba06c347 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-09-01Post FF rc5 merge window openJan-Simon Möller1-2/+2
Adapt the distro config. Change-Id: I216fc5071e8f7a6ff5df221224bd065698ee5a8d Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-09-01Cut Flounder RC5flounder_5.99.5flounder/5.99.55.99.5Jan-Simon Möller1-3/+3
Adapt distro conf. Change-Id: Ic4f5463967870d9caebdc0a1a47f5811faf3b60d Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-27Bump distro post-rc4Jan-Simon Möller1-3/+3
Open up development for rc5/final. Change-Id: I8a724aec556e4020c60dc6e920c97ed776cf7499 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-24Prepare FF RC4flounder_5.99.4flounder/5.99.45.99.4Jan-Simon Möller1-12/+24
Change the distro vars for RC4. Change-Id: I74af40b74fd55bae4c0779c055ba97499c354e75 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-23Change the default sdk install pathJan-Simon Möller1-0/+5
Installing 2 SDKs of the same version but different arch results in broken compilation due to a bug in the meta-qt5 sdk environment scripts. Mitigate it by adding the DEFAULTTUNE to the SDK installation folder until the issue can be addressed in SPEC-1686. Bug-AGL: SPEC-1667, SPEC-1686 v2 (jsmoeller): rewrite to use /opt and SDKPATH Change-Id: Id7e6c919631fc0bcc630a6b813a714f83adaf148 Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh> Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-23Bump post releaseJan-Simon Möller1-6/+6
Change-Id: Ibb43e5499ebc2c271843dad4ba0162b6cce9bf9c Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-23Port the latest version of valgrindRonan Le Martret1-0/+5
Some issues appear with the current version of valgrind on aarch64. (valgrind exits due to an unhandled instruction) An update of valgrind solves this problem. I guess other platform need a update on valgrind too, so this port is not gen3 exclusive. This port uses the yocto recipes(poky:7e7ee662f5dea4d090293045f7498093322802cc): * with some fix on the patch. * remove patch already merged in valgrind git. Bug-AGL: SPEC-1677 Change-Id: Ibf467bee03487252f24ef046b9fe4e4ff6d389da Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
2018-08-17Prepare rc3 releaseflounder_5.99.3flounder/5.99.35.99.3Jan-Simon Möller1-6/+6
Change the distro vars to FF rc3. Change-Id: I75afebf4dfed7fafd80cbfb2fcc5d369048fbefa Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-08-17Mask conflicting variables from package_write_rpm hashJan-Simon Möller1-0/+5
See https://jira.automotivelinux.org/browse/SPEC-1629 for the details. Bug-AGL: SPEC-1629 Change-Id: Id828aab52826b14005d69af5bfaddc4a4c709842 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-30Post-rc2 bumpJan-Simon Möller1-6/+6
Open-up the app builds again post-rc2. Change-Id: I231608c7aecb8180a9a50e4c95302f5d6cf0a546 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-25Matrix reloaded Funky Flounder RC2Jan-Simon Möller1-6/+6
respin rc2 Change-Id: If860a1797650625350350cf42ab8f0b996e9337c Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-19Enable autorev again for masterJan-Simon Möller1-6/+6
Change-Id: I7176338b5608f6cef857d3426c7e6f21e202bd3b Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-07-13Bump version number to FF rc2 v5.99.2Jan-Simon Möller1-6/+6
In preparation of the 2nd release candidate of Funky Flounder. Change-Id: Id26c91112c54a99a1fa8f16311049b15e0ac5544 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-06-29Post rc1 bump of poky-agl.confJan-Simon Möller1-6/+6
Change-Id: I6f9f494a5456bd7c2e9f6a11c7cf36d50f488571 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-06-29Prepare the Funky Flounder RC1 releaseflounder_5.99.1flounder/5.99.15.99.1Jan-Simon Möller1-7/+7
Modify the poky-agl.conf to match the rc1 version. Change-Id: I0619bcab2ab1274905477d53e62f924fa1141009 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-06-15Re-enable fix for cmake in sdkJan-Simon Möller1-2/+2
The hotfix is still necessary as of 2018-06-15 in the meta-qt5 version we use. Change-Id: If650d3056deb604107145dc501a4ba0bf95802e3 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-05-313rd part of the layer/profile rework [1/2]Jan-Simon Möller1-2/+8
This is the last larger commit in this series and deals with the graphical part. We introduce the graphical profiles: - meta-agl-profile-graphical -- meta-agl-profile-graphical-html5 -- meta-agl-profile-graphical-qt5 Notable changes: - weston-ini-conf moved to the meta-agl-bsp layer. Most BSPs have bbappends, so we need to have the recipes present (but unused) even in the console images. - new image: agl-image-boot = terminal-only + network + package-manaager. Ready for using package-feeds - new image/sdk: agl-image-minimal-crosssdk - agl-service-mediaplayer has a dependency on weston, thus it cannot be in the 'core'. Moved it to profile-graphical. - The wayland-ivi-extension moved to the agl-demo-platform. - The app-framework layer included and pulled 'web-runtime' as dependency. This broke console-only images. This has been moved to be in meta-agl-demo only for now. - added and massaged the agl-features. - found and added a useful script 'oe-depends-dot' that helps to work with the dot files (produced with bitbake -g) Todo: - we'll need another pass through the packagegroups. The dependencies for the layers/profiles are now sorted-out but we might have to add/shuffle a few packages. For further details, see meta-agl/docs/profiles.md. v2: fix meta-agl/meta-security/conf/layer.conf - the immediate expansion previously used in there caused some recipes not being added to BBFILES. v3: fix packagegroup renaming (packagegroup-agl-devel -> packagegroup-agl-core-devel) v4: fix missing packagegroup inclusion (tnx Jose, Scott, Stephane) v5: fix missing packagegroup inclusion v6: explicitely put profile-graphical-qt5 on-top of profile-graphical v7: re-add 'procps' when agl-devel feature is on Bug-AGL: SPEC-145 Change-Id: I24cdcd1118932758d0c55d333338238f2a770877 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2018-02-20Merge "move GPLv2 logic into agl-gplv2 feature"Jan-Simon Moeller1-9/+0
2018-02-13Upgrade wayland-ivi-extensionKazumasa Mitsunari1-1/+1
Upgrade wayland-ivi-extension version to 2.0.% from 1.13. Currently, version is 2.0.2 This change is for only master branch. Bug-AGL: SPEC-1244 Change-Id: I200c19837b8f7b646296a868c14423e55e98bf86 Signed-off-by: Kazumasa Mitsunari <knimitz@witz-inc.co.jp>
2018-02-13pokg-agl.conf: Use gstreamer v1.2Changhyeok Bae1-7/+7
Bug-AGL: SPEC-1181 Change-Id: Ib5aa07171a361210b9bae0f62f38595c62099dda Signed-off-by: Changhyeok Bae <changhyeok.bae@gmail.com>