summaryrefslogtreecommitdiffstats
path: root/meta-agl-profile-core
AgeCommit message (Collapse)AuthorFilesLines
2020-01-27packagegroup: agl-core-devel: add gcc-sanitizers packageMatt Ranostay1-0/+1
AddressSanitizers debugging requires shared libraries on runtime to function. Bug-AGL: SPEC-3040 Change-Id: Ibd7148f98f8ae9c9bd5989d4eeaef4256079955a Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-12-29dev-mapping: Add RPROVIDES mechanismScott Murray2-5/+5
Add RPROVIDES and PREFFERED_RPROVIDER definitions to define a new virtual/low-can-dev-mapping runtime package dependency that will enable providing a different device mapping configuration for demo setups. Bug-AGL: SPEC-3076 Change-Id: I73d253a0a1285dd4576bb3b5bf04568c3d05e60c Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-12-20Add cloc to hosttools and use patched sourcesJan-Simon Möller1-1/+5
to use the cloc bbclass, cloc needs to be installed on the host. Thus add it to HOSTTOOLS and also apply all patches. Change-Id: Ifd9a355d2d0dc75f55b683e9d7f398a8f46bae16 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-12-14Change the URL to gerritJan-Simon Moeller1-1/+1
to stay inline with all other recipes, change this to use gerrit. . Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org> Change-Id: If68c42c2dcda0b8c19fc6ed9d634789ae06448c7 (cherry picked from commit 86f6f0b033c52f1270199b8f5c884b2048b41e4f)
2019-12-12agl-service-signal-composer: switch to AGL_APP_REVISIONScott Murray1-3/+2
Switch agl-service-signal-composer's SRCREV to AGL_APP_REVISION so it will automatically pick up changes. This matches the configuration of all the other service bindings. Also change the SRC_URI from gitsm to just git, since submodules are no longer used. Bug-AGL: SPEC-3024 Change-Id: Ida819d937f9090134c885cd5e816342dad7b9c0b Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-12-11json-c: add --enable-threading to EXTRA_OECONFMatt Ranostay1-0/+1
Enable partial threading support to enable compiler atomic operations which in turn avoids refcount corruption issue that was causing aborts with moderate prolonged traffic. Bug-AGL: SPEC-3044 Change-Id: I0b9ab8c27f2c436910dbabf03be5bedaf1a28136 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-12-03low-level-can-generator: update to latest revisionScott Murray1-1/+1
Update SRCREV in low-level-can-generator recipe so that the toolchain will have a version that matches the low-can binding, changes: d9c40fd dd management of version and new decoder signature. 7869e2e Change enum type to flag and add iso tp protocol 93debbc Add generator for boolean fields afa9e97 Add some modifications (space, new line, coma, float). f61a6cb Add some options for J1939 support 0bb5744 Fix the default decoder using "states" da429cc Add gitreview Bug-AGL: SPEC-2976 Change-Id: I1dc3ece955548ced95ae24b9a382ce0ed3ad3b68 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
2019-12-03can-low-level: bump version to get latest changesRomain Forlot1-1/+1
Change-Id: I4f813b634421c781dbe34190417febc69336c649 Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
2019-12-01afb-test: add missing jq package to RDEPENDSMatt Ranostay1-1/+1
Bug-AGL: SPEC-3005 Change-Id: I4d28c2bb7b97ddf8aedbfedf1519362c27327b10 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-11-27Bump afb-test & libappcontrollerFrederic Marec2-2/+2
Bump afb-test & libappcontroller to fix missing event group during test Bug-AGL: SPEC-2795 Change-Id: Iaa87ac5512d5b54bf56922883c54cf38eaa6ce79 Signed-off-by: Frederic Marec <frederic.marec@iot.bzh> (cherry picked from commit b25f4ec97c4ef95dbbb85423fffe9be753b52f51)
2019-11-26systemd: Install canbus network script in nonarch_base_libdirMax Tomago1-1/+1
This is the directory where systemd keeps network scripts (e.g /lib rather than /lib64). Installing them in base_libdir breaks the build for multilib targets. Bug-AGL: SPEC-2966 Change-Id: If1f780a8cfed29f22f46b9ff1d08f36dee3296ee Signed-off-by: Max Tomago <max.tomago@codethink.co.uk> (cherry picked from commit 2ed82aa378099d18db268c146d9a53756c5f2890)
2019-11-17agl-service-hvac: rework configuration file packagingScott Murray3-10/+30
Move agl-service-hvac hvac.json configuration file install into its own recipe so that just it will be machine-specific, and replace m3ulcb-specific agl-service-hvac bbappend with a more generic do_install_append_ulcb in the new agl-service-hvac-conf recipe. Bug-AGL: SPEC-2949 Change-Id: Iabdfa2c204017a30bf82bed3eb6debbd3eb0be9c Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-10-15libafb-helpers: bump to latest revisionStephane Desneux1-1/+1
The following commits are added: * 019054d Pkg config files: use CMAKE_INSTALL_LIBDIR var * 826731f Add function to add one json array to another one Bug-AGL: SPEC-2846,SPEC-2867 Change-Id: Ie0c1db8a8c788fa95480dd855137ee0305c439b3 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-10-14lightmediascanner.service: Fix for the first bootLeon Anavi1-0/+4
Fix lightmediascanner systemd service to avoiding a race condition with /var/volatile/tmp on the first boot by running it after run-agl-postinsts.service. Furhtermore, for extra safety, a restart on failure has been added. Bug-AGL: SPEC-2869 Change-Id: Ib0cadfaa3b4da2a15ac3cfc04cf6d8174e63eb63 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> (cherry picked from commit 15c979005a29404bfc11da6055f29ee77254b876)
2019-10-10agl-service-navigation: add RDEPENDSScott Murray1-0/+2
Add RDEPENDS definition to indicate libjson-c and libdbus-c++ runtime dependency. This fixes a startup problem if libdbus-c++ is not pulled into an image by something else, which will then cause the POI app to crash. Bug-AGL: SPEC-2707 Change-Id: I02b6c120c0fefae972874284c10b6606bab5f647 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-10-06agl-devel.inc: Add modetestLeon Anavi1-0/+2
Add modetest if the agl-devel feature is enabled in images with graphical user interface (GUI), aka wayland. Modetest is part of libdrm and libdrm-tests. It is useful for verification of the DRM/KMS driver functionality. Bug-AGL: SPEC-2465 Change-Id: Iaee906a97b3ee38214b04f603322298fa7adb4c5 Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> (cherry picked from commit d6f491229bc3d978503c100df704bdcfd250984b)
2019-10-05bluez-alsa: update to latest masterGeorge Kiagiadakis1-2/+2
This adds, among others, the d-bus interface that is necessary for the pipewire gstreamer helper from meta-pipewire to work. The LICENSE file was changed to not include the contributors list, but otherwise the license is unchanged. Bug-AGL: SPEC-2792 Change-Id: I7d9e954691e617b3c8ba8165864b32f3831e28b7 Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2019-10-01meta-agl-profile-core: update curl and nghttp2Scott Murray4-0/+144
Backport newer curl and nghttp2 recipes, and bbappend curl to enable nghttp2 support by default when building for target. In concert with a change to mask out the curl bbappend in meta-aac, this should provide the requirements for alexa-voiceagent-service and avoid significant rebuilds when the agl-voiceagent-alexa feature is enabled/disabled. The curl recipe backport is from commit 0b7320b in upstream oe-core master branch, the nghttp2 recipe backport is from commit 5a9b6d3 in meta-networking in meta-openembedded master branch. Bug-AGL: SPEC-2839 Change-Id: Id1ec872dfcb4ecc7a9ba68bdefb114ceeff066c3 Signed-off-by: Scott Murray <scott.murray@konsulko.com> (cherry picked from commit 7f4b218599f3c6a0c7b77d1d2866e5b71d920179)
2019-09-13udisks: remove unneeded execute bit on automount.shMatt Ranostay1-0/+0
On do_install() the correct execute bits are set and shouldn't be in the repo version of automount.sh Bug-AGL: SPEC-2774 Change-Id: Ic66707f9e9367ed02c523f11cb6d6ba360e6fe9f Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> (cherry picked from commit bad943d52c413e35879cc48a0df257f983190de8)
2019-09-11agl-service-navigation: Switch to AGL GerritScott Murray1-4/+4
Update agl-service-navigation recipe to switch to using AGL Gerrit for the source repository. Bug-AGL: SPEC-2787 Change-Id: I9a494adb8972b8cf20681ab37d2756459448e13d Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-09-09freetype: add pixmap to PACKAGECONFIGMatt Ranostay1-0/+3
To allow rendering of color emojis the pixmap/libpng support needs to be enabled. Bug-AGL: SPEC-2701 Change-Id: I7f0dc2cf54f0cf587d72a81fbf06c5750bbdeefb Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> (cherry picked from commit dcda26bd13b88f51a197324d4894fe189f9dc504)
2019-08-20dbus-cynara: Simplifies build recipeJosé Bollo2-5/+4
Simplifies the way of building dbus-cynara by removing the specific recipes in favour of a recipe for dbus that handles the class-target build feature. It requires to remove fake dependencies of cynara. This is a suggestion of Tom Rini. Bug-AGL: SPEC-1839 Change-Id: Id7a736eb4b73cdb679fa9dde30e9ad8e56c2894e Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-07-31bluez5: add obex.service.d conf to fix smack label issuesMatt Ranostay2-0/+7
All data transfer from obexd need to be located in a direcory that has a User::App-Shared label for bindings to be able to access them. This is done by moving the TMPDIR to /run/user/UID/usrshr Bug-AGL: SPEC-2695 Change-Id: I076eb89d0ed14af67811d497217db583e4f5902b Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> (cherry picked from commit b999b3e4147d065b55c1a7ce53125f767c0a0c8f)
2019-07-29lightmediascanner: remove user media directories scanningMatt Ranostay1-1/+1
Since lightmediascanner is now a system service it shouldn't scan user directories of the running user. For any demo uses of preloaded media it should be put in a directory under /media Bug-AGL: SPEC-2655 Change-Id: Ib62527f0742673081e1f225e98fe7eff90738e0e Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-07-26recipes-multimedia: lightmediascanner: move database to globally accessible areaMatt Ranostay1-2/+1
On runtime the agl-service-mediaplayer needs to access the sqlite3 database from lightmediascanner. Thus the database needs to be in an accessible location, and with the correct permissions. Bug-AGL: SPEC-2655 Change-Id: Ia1fc9ce7fa2f782ebc1784e130152baebb441cad Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> (cherry picked from commit 03ef60ee0aed59deb1f554a3a194ad2ff54be276)
2019-07-25Bump cmake-apps-module revisionFrederic Marec1-1/+1
Bump revision following gerrit review 21859 bd9e1c9 Fix new target test-tree d9af887 Add automatic test tree creation 5a26df7 02-variables.cmake: Fix wrong variable tested 7593f0f Recurse path when using fallback zip tool 4e1d47b CMake Nav Panel: Changed configuration title afba79c CMake project arch: Fixed title to match nav panel c26a064 CMake Configuring: Updated topic title. b99684d CMake Overview: Added TOC links and edits. 0c10393 Book manual updates for CMake Templates f46dcf2 02-variables.cmake: project options for 3.12.4 1e0f297 02-variables.cmake: project options for 3.12.4 3490ab7 02-variables.cmake: warns - unset project options 9ad5e65 02-variables.cmake: fix project cmake-commands 74fd1a5 Fix cmake-apps-module document typo. 2345e80 CMake: Complete re-write of the CMake topic. 9c07127 CMake Topic book: Updated for the new file names. 2710740 CMake Section: Complete re-write. 16829a3 cmake-apps-module: New file names. a6daa45 autobuild: fix warnings due to cp command exit code bcdefaf docs: add yaml book f3ce787 Avoid a target to link against itself Bug-AGL: SPEC-2040 Change-Id: I51d60cf572eb2a9a49ed25d3bb162c4f70b0b316 Signed-off-by: Frederic Marec <frederic.marec@iot.bzh> (cherry picked from commit 47090c323cb7d3a17c7b0d99f0678311ed829447)
2019-07-25recipes-multimedia: lightmediascanner: switch from user dbus session to systemMatt Ranostay4-15/+69
To avoid multiple instances of lightmediascanner from being created it should run only once in the system dbus session. Bug-AGL: SPEC-2655 Change-Id: I6c9510926f82ec9eb5625d63d08998a145504227 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> (cherry picked from commit af1c6967f09a51c600742de6e299255ff07b4a47)
2019-07-24agl-service-steering-wheel: update SRCREVRaquel Medina1-2/+1
The SRCREV update brings in the following commits: 6d5d619 autobuild: set execute permission for autobuild scripts 932a226 Fix build warning of typecast e47b473 Change markdown syntax 07f4c99 autobuild: add autobuild scripts c404f25 Revert "Change steering to systemd service for ces2019" 1fed2c5 Change steering to systemd service for ces2019 Bug-AGL: SPEC-2164 Change-Id: Ic9e47595cb2a76084d9cd60fffb21c36a338a8cb Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
2019-07-16distro-build-manifest: add DIST_BUILD_TS in all manifestsStephane Desneux1-1/+5
The build timestamp is added to build manifests deployed in target images and SDK. Also, this patch adds a new option '-t|--timestamp' to distro-manifest-generator.sh to let the recipe pass the same timestamp as the one used for the image suffix (in Yocto 2.6/Thud, DATETIME is used). So DIST_BUILD_TS should have the same value as the image version suffix. Bug-AGL: SPEC-2649 Change-Id: I2a9d11b2ce59753bca31ebb8e82d46c224110d68 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-07-09agl-service-hvac: Install hvac.json into /etcHarunobu Kurokawa1-0/+4
agl-service-hvac has hvac.json file to set LED and CAN_DEV parameter, however this file is not installed. v2 move to main bb recipe file. fix wrong discription from WORKDIR to {S}. Bug-AGL: SPEC-2600 Change-Id: I8c0a416b3196b67cbb131d9351a1d20cc2dfe74f Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>
2019-07-03agl-core-connectivity: add avahi-daemon when agl-devel feature is setStephane Desneux1-0/+3
Accessing the boards using .local addresses is convenient. But avahi-daemon is not pulled explicitely in images. This patch adds packagegroup-base-zeroconf (containing avahi-daemon) in the core image only when agl-devel feature is set and zeroconf is enabled in DISTRO_FEATURES Bug-AGL: SPEC-2592 Change-Id: Iea899d98cd0d8628f9533641f7b42c04f4580c64 Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
2019-06-28recipes-core: systemd: move canbus-can.network scriptMatt Ranostay2-0/+9
Move canbus network script from meta-agl-profile-telematics to meta-profile-core. Since this is useful for more than just telematics Bug-AGL: SPEC-2580 Change-Id: I93666d87f1fb3eb037743d2858a8757d6939c5e3 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-26rtl-sdr: Install tweaked udev rulesScott Murray1-2/+8
To enable agl-service-radio to access the RTL-SDR USB devices, install the provided rtl-sdr.rules file in /etc/udev/rules.d, modifying it to tweak the device permissions, group, and SMACK label to meet the requirements for the new application framework audio permission. Bug-AGL: SPEC-2573 Change-Id: I22e2c624b8c57df0b5932ba7f8a377ae2c0d9566 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-06-25agl-service-unicens: add missing DEPENDSScott Murray1-1/+1
agl-service-unicens now needs libafb-helpers to build, add it to DEPENDS in its recipe. Bug-AGL: SPEC-2562 Change-Id: Ief299b51bffb288f2143bfae3cc7a646ba93b43b Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-06-23Move the agl-service-radio to the graphical profileJan-Simon Möller5-39/+0
The agl-service-radio relies on gstreamer. Unfortunately the gstreamer recipe is currently setup to also pull-in wayland (due to a compile-flag if wayland is in DISTRO_FEATURES). To keep the distro aligned, we don't want to change the DISTRO_FEATURES between the profiles, thus we move the agl-service radio to the graphical profile where we include weston anyway by default. For now this means there is no radio service (or mediaplayer service) w/o wayland installed as well. In case we get this requirement, we'll have to work on the gstreamer recipe and its split. v2: fix bbapend in meta-agl-bsp/meta-rcar-gen3 v3: put packagegroup-agl-graphical-multimedia.bbappend in graphical profile (not the best place IMHO) This fixes the non-graphical build. Bug-AGL: SPEC-2500 Change-Id: I5ebec7d7713510f3fcd50ae425d7f8cbb6328016 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-06-20meta-agl-profile-core: Add packagegroup-machine-base to imagesScott Murray2-1/+2
Add packagegroup-machine-base to packagegroup-agl-image-{boot,minimal}. This replicates its use in oe-core, where it gets pulled in via packagegroup-base into the core-image definition. AGL over-rides CORE_IMAGE_BASE_INSTALL, losing packagegroup-base entirely. However, it is useful to use packagegroup-machine-base to pick up any BSP definitions of MACHINE_EXTRA_RDEPENDS and MACHINE_EXTRA_RRECOMMENDS, which some of the machines defined in meta-freescale-3rdparty use for non-essential firmware for onboard peripherals. Bug-AGL: SPEC-2517 Change-Id: I1ee07955dc60da1388b21b7a531dab8483935194 Signed-off-by: Scott Murray <scott.murray@konsulko.com>
2019-06-20Reworked the automount scriptLoïc Collignon1-10/+84
You have to tweak mount options on a per filesystem basis so that the permissions set on the mount point allow the mediascanner and mediaplayer to read files. Bug-AGL: SPEC-545 Change-Id: I2579bf4b8be3d0bc05f08f762bb751d4f54651a8 Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
2019-06-19meta-agl-profile-core: recipes-connectivity: ofono: add SYSTEMD_AUTO_ENABLE ↵Matt Ranostay1-0/+2
to bbappend Re-enable ofono to be started on system bootup. Bug-AGL: SPEC-2512 Change-Id: Ia6638a3f4baf5e491e960c0c6e9ec414a6baee0b Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-19meta-agl-profile-core: recipes-connectivity: bluez: add notification statusMatt Ranostay2-1/+30
Add 'notfication' reporting for the Status property via the org.bluez.obex.Message1 interface. Bug-AGL: SPEC-2512 Upstream-Status: PENDING Change-Id: Idce51acdc6f0718f07cc2bb669c4bc71686588ee Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-19meta-agl-profile-core: recipes-connectivity: bluez: remove outdated patchMatt Ranostay2-30/+0
Remove compiler fix for version 5.22 which is no longer within the tree. Bug-AGL: SPEC-2512 Change-Id: I8ffc73ba108016214dab5da744339fc4e3da7c54 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-06-19agl-service-ca-low-level: run at platform scopeJosé Bollo1-1/+1
Integrate running at platform scope. Bug-AGL: SPEC-2006 Change-Id: I7d47512c0f7b29f91be9c18144400b02f62b562f Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-06-19libafb-helpers: Fix bug SPEC-2520José Bollo1-1/+1
This integrates the fix of the homescreen crashing after recent audiomixer change. Bug-AGL: SPEC-2520 Change-Id: Ia9899cbe23fc88179d26d8069c3e12463bdda5b6 Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-06-19lightmediascanner: change db directoryJosé Bollo1-1/+2
Lightmediascanner runs for one user and should not be able to look over the the shoulder of other users. So it should not run as root anymore. At the moment, lightmediascanner is a user daemon started in the user session by systemd, without capabilities but with the Smack label "System". To allow the service-mediascanner to access its database, the db must be set in a specific place with the User::App-shared label. Bug-AGL: SPEC-1016 Change-Id: Id4546e2567c4f5a0a5139d274d35d11e4879e42e Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-06-19Improve management of the group displayJosé Bollo1-2/+2
The group display protects accesses to display resources. When running as user, it should not be acquired by default but on need. Bug-AGL: SPEC-2006 Change-Id: I7c188720e5cfcb65f02af25d0e4262f59300d16a Signed-off-by: José Bollo <jose.bollo@iot.bzh>
2019-06-17agl-image-minimal-crosssdk: add afb-helpers & appcontroller libsThierry Bultel1-0/+2
Applications that no longer use the afb-helpers & appcontroller as submodules must be buildable with a minimal SDK. Bug-AGL: SPEC-2527 Change-Id: I31af05e2a9256db68394dcef88e424ecc8eb1ec2 Signed-off-by: Thierry Bultel <thierry.bultel@iot.bzh>
2019-06-10agl-core-services: build the radio service if pipewire is enabledGeorge Kiagiadakis1-1/+1
And we no longer need to care about older systems Bug-AGL: SPEC-2473 Change-Id: Iac46298183f7ed0e080c71fb94e57ed8f3e1283c Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2019-06-10agl-core-multimedia: update for the pipewire transitionGeorge Kiagiadakis1-10/+0
Only pipewire is supported now, all other switches can go away Bug-AGL: SPEC-2473 Change-Id: I443dba64bc92282dfbb440a05c792b631570fc92 Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2019-06-10agl-service-radio: update recipe for pipewireGeorge Kiagiadakis1-3/+0
Only pipewire is supported now as the backend, therefore we don't need the switches Bug-AGL: SPEC-2473 Change-Id: Ie5e9319c064e972f367d67fe3b898cb3ad142d6c Signed-off-by: George Kiagiadakis <george.kiagiadakis@collabora.com>
2019-05-31Fix the location of the qemu bbappendJan-Simon Möller1-0/+0
The previous commit had it in the wrong folder. Correct that. Change-Id: Iadced308d90f4bb0babb40cc7e37f4c20a93a860 Bug-AGL: SPEC-2450 Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
2019-05-23Move hmi-framework and eg-virt from meta-agl-devel to meta-aglJan-Simon Möller1-0/+1
Part of the layer cleanup. Bug-AGL: SPEC-2450 Change-Id: I0e0517c6f5aeaa1378715acde8adda6200119aba Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>