aboutsummaryrefslogtreecommitdiffstats
path: root/binding
AgeCommit message (Collapse)AuthorFilesLines
2020-08-31Change media_result response in no media caseScott Murray1-10/+5
Change the response from the media_result verb when there is no media present to a success with an empty media array instead of a failure. Bug-AGL: SPEC-3556 Signed-off-by: Scott Murray <scott.murray@konsulko.com> Change-Id: Iafa99d32062db197430a5daf99aee7e2ec0a9a5e
2020-02-10mediascanner: Clustered media-list & Code unificationFarshid Monhaseri3-160/+361
Bug-AGL: SPEC-3100 - Add clustered media-list view as an option when the user requests it with 'view':'clustered' ARGS on event subscription or 'media_result' verb call. If no ARGS passed, the scanner has its default media-list view. - Unify event scans & verb-call scans codes as much as possible. Now scan operation has single & transparent control flow. - Add 'ScanFilter_t' data structure and a few other modifications so managing new features and filters will be easier and clear. - Fix a few bugs. - Extract precise error messages from deeper functions and log & reply fail message to the client. Signed-off-by: Farshid Monhaseri <monhaseri.f@gmail.com> Change-Id: Ia3629af75614359260eb7af0c0331d6ef9f3bcbe
2020-01-25mediascanner: fix the service memory leakagesicefish_8.99.5icefish/8.99.58.99.5Farshid Monhaseri3-17/+55
Bug-AGL: SPEC-3103 - fix memory leakage in 'media_results_get' callback function which is called by 'media_result' verb. Set free-full the whole list with 'free_media_item' callback function(major leak). - fix memory leakage in 'MediaPlayerManagerInit' function, file object is not released(minor leak). - fix memory leakage in 'media_lightmediascanner_scan' function and avoid open sqlite3 connection and allocate whole sqlite resources again and again on every function execution (major leak). - fix memory leakage in 'on_interface_proxy_properties_changed' when iterating over 'changed_properties' and not release key & subValues. Signed-off-by: Farshid Monhaseri <monhaseri.f@gmail.com> Change-Id: I943a961b0c13be79c70c80e7a4f558958551f800
2020-01-11Add scan-type(audio,video,image,all) to scannerFarshid Monhaseri3-24/+175
Bug-AGL: SPEC-3096 User can pass 'types' as a request property with 'audio','video', 'image','all' values as a single 'string' value or as an array of 'string' values along 'media_result','subscribe','unsubscribe' verbs to scan or register the events with those scan-types. If the user doesn't provide the 'types' request property, the API will function as before with 'audio' and 'video' scan-types. Change-Id: I8ff49f89e2696f600dfb2935403d8b0c8246c07d Signed-off-by: Farshid Monhaseri <monhaseri.f@gmail.com>
2019-07-22binding: mediaplayer: switch to G_BUS_TYPE_SYSTEM dbus sessionicefish_8.99.4icefish_8.99.3icefish_8.99.2icefish_8.99.1icefish/8.99.4icefish/8.99.3icefish/8.99.2icefish/8.99.18.99.48.99.38.99.28.99.1Matt Ranostay1-1/+1
lightmediascanner now listens on the G_BUS_TYPE_SYSTEM dbus session and no longer the user's session. Bug-AGL: SPEC-2655 Change-Id: I054de128556b7d2cfcdd42d8ddc345befa3a2021 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2019-04-03binding: mediascanner: escape file uri pathshalibut_7.99.3halibut_7.99.2halibut_7.99.1halibut/7.99.3halibut/7.99.2halibut/7.99.17.99.37.99.27.99.1Matt Ranostay1-1/+5
To avoid prevent passing of non-input validated data to the agl-service-mediaplayer service the filename paths should be escaped. Change-Id: I7d0e9ddf26d02be5fcf127d810d84c3537ddbbce Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-10-20binding: mediaplayer: remove implicit type casting warningMatt Ranostay1-1/+1
Change-Id: Ieb88e2c7b99817a302e7e1cbdbca57781e2fdc8c Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-10-20binding: mediascanner: upgrade binding to afb version 3Matt Ranostay1-16/+10
Change-Id: Ieec8a71a815eeed02ecd5e17429bb81e84b0a9b5 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-10-09binding: mediascanner: update version of conf.d/app-templates submoduleMatt Ranostay1-5/+0
To allow coverage tests to be run it requires the app-templates to be updated to a recent release. Bug-AGL: SPEC-1799 Change-Id: I569f9e4885c0ac5a6764919947d50e6722f02fd7 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-06-09binding: mediascanner: fix race condition with dbus and lightmediascannerguppy_6.90.0guppy/6.90.0flounder_5.99.6flounder_5.99.5flounder_5.99.4flounder_5.99.3flounder_5.99.2flounder_5.99.1flounder/5.99.6flounder/5.99.5flounder/5.99.4flounder/5.99.3flounder/5.99.2flounder/5.99.16.90.05.99.65.99.55.99.45.99.35.99.25.99.1Matt Ranostay1-14/+14
There are edge conditions in which the media_result verb can be requested before lms_proxy has been initialized which will cause a segfault. This patchset reorders operations to be sure lms_proxy is initialized before running returning from .init() Bug-AGL: SPEC-1496 Change-Id: I160167e95b6e301aaaabc63efe08972976d18a63 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-03-29binding: mediascanner: optimize audio sql queryMatt Ranostay1-3/+3
Convert query to use INNER JOIN for the audios table Change-Id: I9c0b91ef4289ca66322aa805198873e4043f8f92 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2018-01-11binding: mediaplayer: tag media type in playlistMatt Ranostay3-0/+13
Some clients may not want or need both audio and video media in the the returned playlist. This change tags the media type in each playlist entries JSON output. Bug-AGL: SPEC-1236 Change-Id: I78a25b92f64eb73cca24f5f6a857913567c25f2c Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-12-22binding: mediascanner: fix media_result for videoTasuku Suzuki1-1/+2
media_result didn't work with video because of the SQL for video is not perfect. Change-Id: If0f8b9d104f4b3f293c6457c285035f55132f748 Bug-AGL: SPEC-1169 Signed-off-by: Tasuku Suzuki <tasuku.suzuki@qt.io>
2017-12-09binding: mediascanner: add video scan from lightmediascannerMatt Ranostay3-7/+30
Add to the playlist the video media found from the lightmediascanner database. Bug-AGL: SPEC-1169 Change-Id: I9ebf2e21805fe0e59a853dd081eacf02af501c96 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-11-03binding: mediascanner: remove superfluous local scan functioneel_4.99.3eel_4.99.2eel/4.99.3eel/4.99.24.99.34.99.2Matt Ranostay3-38/+0
Now lightmediascannerd scan the local ~/Music directory which has the plus of getting the metadata Bug-AGL: SPEC-1029 Change-Id: Iad13d343b8bd40cec803527b31763642bd141ded Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-10-10binding: mediascanner: don't add directories from local scanMatt Ranostay1-1/+12
Bug-AGL: SPEC-934 Change-Id: Ia881763c7c062f4a6aff74d43173fd19afdf3f4e Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-10-10binding: mediascanner: scan for local media firstMatt Ranostay3-7/+6
Scan for local media first to allow the playlist to be concise. Bug-AGL: SPEC-934 Change-Id: Ic3d1b3e80fd67ac79d4d51b602754d81a2ebf903 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-10-09binding: mediascanner: report only playlist for media insertedMatt Ranostay3-10/+30
Only generate an media_added event with the playlist of the media inserted. Bug-AGL: SPEC-934 Change-Id: I4e0897fbf06651f0d85c7dd5145edc7c898c68bf Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-10-06binding: mediascanner: correct local paths returnedMatt Ranostay1-1/+1
Local paths filenames weren't included in JSON output. Change-Id: I060886acdd7d890fd81b5164a131b95dd498eb2e Bug-AGL: SPEC-924 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-10-05binding: mediascanner: add media metadata to JSON outputMatt Ranostay3-6/+76
Add metadata of the tracks artist, title, album and genre to the JSON output for media results. Bug-AGL: SPEC-924 Change-Id: I240481b3b36909cb2de6ff7ba5c0a168d7973dc2 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-09-20binding: mediascanner: remove AFB_SESSION_CHECK from verbsMatt Ranostay1-4/+4
AFB_SESSION_CHECK is not needed for the mediascanner verbs, since there isn't a need of secured sessions. Bug-AGL: SPEC-904 Change-Id: I06b09b9d739ebbec22710463ab15212b929b5423 Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
2017-09-06binding: media: add binding to its own repoMatt Ranostay8-0/+7348
Initial commit for agl-service-media repo. This change enables cmake builds, and it being a standalone binding independent of the MediaPlayer application. Bug-AGL: SPEC-848 Change-Id: I1234c0d0dde4379b5697cc3fe3e16e27f8b73a7c Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>