The surfaces are managed by using the roles instead of the drawing names

Change-Id: I7373a54f2df334ac223b51a6cb9a643a88e7c33c
Signed-off-by: Yuta Doi <yuta-d@witz-inc.co.jp>

2 files changed, 32 insertions, 42 deletions

diff --git a/src/app.cpp b/src/app.cpp
index cf10cef..007ebd2 100644
--- a/src/app.cpp
+++ b/src/app.cpp
@@ -544,9 +544,12 @@ void App::check_flushdraw(int surface_id) {
 }
 
 void App::api_enddraw(char const *drawing_name) {
+   // Convert drawing_name to role
+   const char* role = this->convertDrawingNameToRole(drawing_name);
+
    for (unsigned i = 0, iend = this->pending_end_draw.size(); i < iend; i++) {
       auto n = this->lookup_name(this->pending_end_draw[i]);
-      if (n && *n == drawing_name) {
+      if (n && *n == role) {
          std::swap(this->pending_end_draw[i], this->pending_end_draw[iend - 1]);
          this->pending_end_draw.resize(iend - 1);
          this->activate(this->pending_end_draw[i]);
@@ -632,10 +635,10 @@ void App::surface_removed(uint32_t surface_id) {
    if (int(surface_id) == this->layers.main_surface) {
       this->deactivate_main_surface();
    } else {
-      auto drawing_name = this->lookup_name(surface_id);
-      if (drawing_name) {
+      auto role = this->lookup_name(surface_id);
+      if (role) {
          this->allocateWindowResource("deactivate",
-                                      drawing_name->c_str(), nullptr,
+                                      role->c_str(), nullptr,
                                       [](const char*){});
       }
    }
@@ -711,7 +714,9 @@ void App::emitCarRun() {
 }
 
 result<int> App::api_request_surface(char const *drawing_name) {
-   auto lid = this->layers.get_layer_id(std::string(drawing_name));
+   // Convert drawing_name to role
+   const char* role = this->convertDrawingNameToRole(drawing_name);
+   auto lid = this->layers.get_layer_id(std::string(role));
    if (!lid) {
       /**
        * register drawing_name as fallback and make it displayed.
@@ -723,10 +728,10 @@ result<int> App::api_request_surface(char const *drawing_name) {
       }
    }
 
-   auto rname = this->lookup_id(drawing_name);
+   auto rname = this->lookup_id(role);
    if (!rname) {
       // name does not exist yet, allocate surface id...
-      auto id = int(this->id_alloc.generate_id(drawing_name));
+      auto id = int(this->id_alloc.generate_id(role));
       this->layers.add_surface(id, *lid);
 
       // set the main_surface[_name] here and now
@@ -736,24 +741,11 @@ result<int> App::api_request_surface(char const *drawing_name) {
          HMI_DEBUG("wm", "Set main_surface id to %u", id);
       }
 
-#if 0 // @@@@@
-      // TODO:
-      // This process will be implemented in SystemManager
-      {
-          // Generate app id
-          auto id = int(this->app_id_alloc_.generate_id(drawing_name));
-          this->appname2appid_[drawing_name] = id;
-      }
-#endif
-
       // Set map of (role, surface_id)
-      const char* role = this->convertDrawingNameToRole(drawing_name);
       this->role2surfaceid_[role] = id;
 
-      // Set map of (role, app)
-      // If the new app which has the same role which is had by existing app is requested,
-      // the role is given to the new app.
-      this->role2app_[role] = std::string(drawing_name);
+      // Set map of (role, drawing_name)
+      this->role2drawingname_[role] = std::string(drawing_name);
 
       return Ok<int>(id);
    }
@@ -821,8 +813,11 @@ result<json_object *> App::api_get_display_info() {
 result<json_object *> App::api_get_area_info(char const *drawing_name) {
    HMI_DEBUG("wm", "called");
 
+   // Convert drawing_name to role
+   const char* role = this->convertDrawingNameToRole(drawing_name);
+
    // Check drawing name, surface/layer id
-   auto const &surface_id = this->lookup_id(drawing_name);
+   auto const &surface_id = this->lookup_id(role);
    if (!surface_id) {
       return Err<json_object *>("Surface does not exist");
    }
@@ -864,11 +859,9 @@ void App::activate(int id) {
       char const *label =
          this->lookup_name(id).value_or("unknown-name").c_str();
 
-      // FOR CES DEMO >>>
-      if ((0 == strcmp(label, "Radio"))
-          || (0 == strcmp(label, "MediaPlayer"))
-          || (0 == strcmp(label, "Music"))
-          || (0 == strcmp(label, "Navigation"))) {
+      if ((0 == strcmp(label, "radio"))
+          || (0 == strcmp(label, "music"))
+          || (0 == strcmp(label, "map"))) {
         for (auto i = surface_bg.begin(); i != surface_bg.end(); ++i) {
             if (id == *i) {
                // Remove id
@@ -889,7 +882,7 @@ void App::activate(int id) {
             }
          }
       }
-      // <<< FOR CES DEMO
+
       this->layout_commit();
 
       this->emit_visible(label);
@@ -903,11 +896,9 @@ void App::deactivate(int id) {
       char const *label =
          this->lookup_name(id).value_or("unknown-name").c_str();
 
-      // FOR CES DEMO >>>
-      if ((0 == strcmp(label, "Radio"))
-          || (0 == strcmp(label, "MediaPlayer"))
-          || (0 == strcmp(label, "Music"))
-          || (0 == strcmp(label, "Navigation"))) {
+      if ((0 == strcmp(label, "radio"))
+          || (0 == strcmp(label, "music"))
+          || (0 == strcmp(label, "map"))) {
 
          // Store id
          this->surface_bg.push_back(id);
@@ -927,7 +918,6 @@ void App::deactivate(int id) {
       else {
          this->controller->surfaces[id]->set_visibility(0);
       }
-      // <<< FOR CES DEMO
 
       this->layout_commit();
 
@@ -937,14 +927,14 @@ void App::deactivate(int id) {
 }
 
 void App::deactivate(std::string role) {
-    std::string app = this->role2app_[role];
-    auto const &id = this->lookup_id(app.c_str());
+    auto const &id = this->lookup_id(role.c_str());
     if (!id) {
       HMI_ERROR("wm", "Surface does not exist");
       return;
     }
-    HMI_DEBUG("wm", "Deactivate role:%s (app:%s)",
-              role.c_str(), app.c_str());
+    std::string drawing_name = this->role2drawingname_[role];
+    HMI_DEBUG("wm", "Deactivate role:%s (drawing_name:%s)",
+              role.c_str(), drawing_name.c_str());
 
     this->deactivate(*id);
 }
@@ -1126,8 +1116,8 @@ void App::setSurfaceSize(const char* role, const char* area) {
               size.x, size.y, size.w, size.h);
 
     // Emit syncDraw event
-    const char* app = this->role2app_[role].c_str();
-    this->emit_syncdraw(app, area,
+    const char* drawing_name = this->role2drawingname_[role].c_str();
+    this->emit_syncdraw(drawing_name, area,
                         size.x, size.y, size.w, size.h);
 
     // Enqueue flushDraw event
diff --git a/src/app.hpp b/src/app.hpp
index f6b809a..245e2e7 100644
--- a/src/app.hpp
+++ b/src/app.hpp
@@ -254,7 +254,7 @@ private:
    LayoutManager lm_;
    std::unordered_map<std::string, int> role2surfaceid_;
    std::unordered_map<std::string, std::string> drawingname2role_;
-   std::unordered_map<std::string, std::string> role2app_;
+   std::unordered_map<std::string, std::string> role2drawingname_;
    std::unordered_map<int, int> appid2role_;
    CarInfo crr_car_info_;