aboutsummaryrefslogtreecommitdiffstats
path: root/src/hs-proxy.cpp
diff options
context:
space:
mode:
authorMarius Vlad <marius.vlad@collabora.com>2021-02-01 11:44:05 +0800
committerMarius Vlad <marius.vlad@collabora.com>2021-05-06 12:04:17 +0300
commit4d7ff60ae87f00b9bd9bfa68f4f92b5af7581e3d (patch)
treefd62ab77e15839584d48314ecdc80f1531cbc8cc /src/hs-proxy.cpp
parent496e9aa2539afbe922d6df9f3da1b0384b1b1351 (diff)
Fix potential memory leakjellyfish
json structure allocating code should be placed in where it is used, if there is a condition check which may cause a return before the before-mentioned place in the function. Bug-AGL: SPEC-3584 (cherry-picked from f19cfe46d7172b512f06f5acf657b8d56e69a0b3) Change-Id: I5f88c7ce0b9257b2782144548f11a0e1d7ab388a Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com> Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
Diffstat (limited to 'src/hs-proxy.cpp')
-rw-r--r--src/hs-proxy.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/hs-proxy.cpp b/src/hs-proxy.cpp
index 30c258d..cdbf249 100644
--- a/src/hs-proxy.cpp
+++ b/src/hs-proxy.cpp
@@ -172,7 +172,6 @@ int HS_AfmMainProxy::detail(afb_api_t api, const std::string &id, struct json_ob
*/
void HS_AfmMainProxy::start(struct hs_instance *instance, afb_req_t request, const std::string &id)
{
- struct json_object *args = json_object_new_string(id.c_str());
struct closure_data *cdata;
/* tentatively store the client and client context, as the afb_req_t